Skip to content

Conversation

@liutang123
Copy link
Contributor

@liutang123 liutang123 commented May 15, 2025

What problem does this PR solve?

intruduced from #50696
both method truncateTable(org.apache.doris.nereids.trees.plans.commands.TruncateTableCommand) in org.apache.doris.datasource.ExternalCatalog and method truncateTable(org.apache.doris.analysis.TruncateTableStmt) in org.apache.doris.datasource.iceberg.IcebergDLFExternalCatalog match
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • [*] Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@liutang123 liutang123 requested a review from morningman May 15, 2025 04:11
@liutang123 liutang123 changed the title Fix IcebergDLFExternalCatalogTest compile error (Fix](compile) IcebergDLFExternalCatalogTest compile error May 15, 2025
@liutang123 liutang123 changed the title (Fix](compile) IcebergDLFExternalCatalogTest compile error [fix](compile)IcebergDLFExternalCatalogTest compile error May 15, 2025
@liutang123
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 15, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants