Skip to content

Conversation

@wuwenchi
Copy link
Contributor

bp: #50696

wuwenchi added 2 commits May 15, 2025 19:13
…dlf type. (apache#50696)

### What problem does this PR solve?

Table operations are not supported for catalogs of the dlf type.
@wuwenchi wuwenchi requested a review from dataroaring as a code owner May 15, 2025 11:37
@Thearas
Copy link
Contributor

Thearas commented May 15, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39912 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7aad46f633220e16a01738d451b4a2966766342e, data reload: false

------ Round 1 ----------------------------------
q1	17570	6673	6587	6587
q2	2084	171	173	171
q3	10655	1052	1167	1052
q4	10485	787	716	716
q5	7742	2857	2874	2857
q6	216	134	133	133
q7	986	626	596	596
q8	9366	1949	2033	1949
q9	6609	6398	6412	6398
q10	7059	2291	2302	2291
q11	465	262	265	262
q12	418	220	210	210
q13	17784	2961	2951	2951
q14	236	205	206	205
q15	514	463	461	461
q16	661	573	573	573
q17	978	588	535	535
q18	7131	6572	6731	6572
q19	1454	1086	1105	1086
q20	472	196	206	196
q21	4005	3174	3126	3126
q22	1108	994	985	985
Total cold run time: 107998 ms
Total hot run time: 39912 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6601	6543	6508	6508
q2	326	226	225	225
q3	2923	2742	2809	2742
q4	2088	1813	1766	1766
q5	5769	5721	5832	5721
q6	209	134	129	129
q7	2238	1787	1856	1787
q8	3350	3536	3501	3501
q9	8887	8772	8823	8772
q10	3573	3512	3520	3512
q11	593	489	489	489
q12	800	622	613	613
q13	9820	3168	3117	3117
q14	304	269	268	268
q15	505	463	467	463
q16	673	626	627	626
q17	1823	1641	1594	1594
q18	8178	7698	7709	7698
q19	1637	1589	1529	1529
q20	2046	1884	1845	1845
q21	5406	5196	5145	5145
q22	1098	1063	1045	1045
Total cold run time: 68847 ms
Total hot run time: 59095 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196557 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7aad46f633220e16a01738d451b4a2966766342e, data reload: false

query1	1327	901	907	901
query2	6251	1993	2025	1993
query3	10824	4482	4163	4163
query4	60528	28739	23410	23410
query5	5184	454	443	443
query6	398	178	179	178
query7	5453	313	311	311
query8	318	227	226	226
query9	8580	2653	2627	2627
query10	459	283	262	262
query11	17614	15480	15559	15480
query12	167	103	105	103
query13	1419	462	452	452
query14	9868	6788	7194	6788
query15	218	172	175	172
query16	7098	507	505	505
query17	1139	570	579	570
query18	1861	313	332	313
query19	212	165	163	163
query20	119	116	110	110
query21	208	104	106	104
query22	4541	4474	4617	4474
query23	34297	33752	33913	33752
query24	6285	2915	2921	2915
query25	562	422	429	422
query26	664	168	175	168
query27	1939	364	368	364
query28	4447	2451	2456	2451
query29	715	475	446	446
query30	243	159	164	159
query31	1008	806	847	806
query32	68	54	55	54
query33	422	305	275	275
query34	941	527	536	527
query35	844	733	753	733
query36	1082	942	959	942
query37	114	64	83	64
query38	4031	3966	4000	3966
query39	1550	1476	1461	1461
query40	213	98	100	98
query41	50	47	48	47
query42	115	102	101	101
query43	549	491	508	491
query44	1221	830	811	811
query45	197	168	170	168
query46	1164	745	726	726
query47	2041	1902	1906	1902
query48	493	392	395	392
query49	732	393	408	393
query50	862	431	432	431
query51	7565	7326	7268	7268
query52	102	95	93	93
query53	274	195	193	193
query54	591	469	481	469
query55	83	79	82	79
query56	264	254	271	254
query57	1299	1142	1161	1142
query58	228	211	240	211
query59	3320	3089	3129	3089
query60	290	256	255	255
query61	109	155	107	107
query62	779	683	684	683
query63	230	195	190	190
query64	1399	670	633	633
query65	3263	3168	3229	3168
query66	697	286	291	286
query67	15950	15461	15358	15358
query68	4133	596	576	576
query69	432	291	267	267
query70	1152	1150	1112	1112
query71	359	251	251	251
query72	6381	3999	3886	3886
query73	747	356	369	356
query74	10407	8915	8937	8915
query75	3332	2659	2636	2636
query76	1963	1068	1029	1029
query77	486	281	269	269
query78	10512	9594	9564	9564
query79	2046	592	600	592
query80	1372	438	440	438
query81	525	241	237	237
query82	1253	89	88	88
query83	204	144	143	143
query84	279	83	78	78
query85	988	297	284	284
query86	390	279	285	279
query87	4382	4213	4241	4213
query88	3784	2440	2409	2409
query89	419	294	288	288
query90	1977	188	185	185
query91	214	147	145	145
query92	59	49	50	49
query93	2881	562	554	554
query94	783	304	274	274
query95	356	260	259	259
query96	630	283	292	283
query97	3347	3120	3108	3108
query98	207	203	200	200
query99	1631	1324	1299	1299
Total cold run time: 314709 ms
Total hot run time: 196557 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.6 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7aad46f633220e16a01738d451b4a2966766342e, data reload: false

query1	0.04	0.03	0.02
query2	0.07	0.03	0.03
query3	0.22	0.07	0.07
query4	1.63	0.10	0.10
query5	0.52	0.51	0.49
query6	1.13	0.73	0.72
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.56	0.50	0.50
query10	0.55	0.55	0.55
query11	0.14	0.10	0.10
query12	0.14	0.11	0.12
query13	0.61	0.59	0.60
query14	2.84	2.83	2.74
query15	0.90	0.82	0.82
query16	0.38	0.38	0.39
query17	1.08	1.04	1.05
query18	0.23	0.22	0.22
query19	1.90	1.80	2.00
query20	0.01	0.01	0.01
query21	15.36	0.58	0.57
query22	2.66	1.98	1.71
query23	17.07	0.95	0.75
query24	3.13	0.70	1.87
query25	0.11	0.08	0.18
query26	0.47	0.14	0.13
query27	0.05	0.05	0.04
query28	9.83	0.53	0.46
query29	12.57	3.26	3.29
query30	0.25	0.06	0.05
query31	2.87	0.37	0.37
query32	3.29	0.45	0.45
query33	2.96	3.00	3.03
query34	16.82	4.49	4.46
query35	4.51	4.45	4.51
query36	0.66	0.49	0.50
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.03	0.02
query40	0.16	0.13	0.12
query41	0.09	0.03	0.02
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.11 s
Total hot run time: 31.6 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 24, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 868cc91 into apache:branch-3.0 Jun 24, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants