Skip to content

[fix](jsonb) Avoid crashing caused by invalid path #50978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
May 17, 2025
Merged

[fix](jsonb) Avoid crashing caused by invalid path #50978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions be/src/util/jsonb_document.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1499,6 +1499,10 @@ inline bool JsonbPath::parsePath(Stream* stream, JsonbPath* path) {
// advance past the .
stream->skip(1);

if (stream->exhausted()) {
return false;
}

// $.[0]
if (stream->peek() == BEGIN_ARRAY) {
return parse_array(stream, path);
Expand All @@ -1523,6 +1527,10 @@ inline bool JsonbPath::parse_array(Stream* stream, JsonbPath* path) {
stream->set_leg_ptr(const_cast<char*>(stream->position()));
stream->add_leg_len();
stream->skip(1);
if (stream->exhausted()) {
return false;
}

if (stream->peek() == END_ARRAY) {
std::unique_ptr<leg_info> leg(
new leg_info(stream->get_leg_ptr(), stream->get_leg_len(), 0, ARRAY_CODE));
Expand Down
21 changes: 21 additions & 0 deletions regression-test/suites/query_p0/sql_functions/conditional_functions/test_json_parse.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,5 +49,26 @@ suite("test_json_parse") {
check_fold_consistency "json_parse_error_to_null('null')"
check_fold_consistency "json_parse_error_to_null('123')"
check_fold_consistency "json_parse_error_to_null('[1, 2, 3]')"


sql """DROP TABLE IF EXISTS `test_invalid_path_tbl`;"""
sql """
CREATE TABLE `test_invalid_path_tbl` (
`id` int NULL,
`v` json NULL,
`s` text NULL
) ENGINE=OLAP
DUPLICATE KEY(`id`)
DISTRIBUTED BY RANDOM BUCKETS AUTO
PROPERTIES (
"replication_allocation" = "tag.location.default: 1");
"""

sql """ insert into test_invalid_path_tbl values (1, '{"key": "value"}', '\$.\$.'); """

test {
sql "SELECT id, json_exists_path(v, s) FROM test_invalid_path_tbl;"
exception "Json path error: Invalid Json Path for value: \$.\$."
}
}

Loading