Skip to content

Conversation

@mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented May 18, 2025

What problem does this PR solve?

pick #50978

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@mrhhsg mrhhsg requested a review from dataroaring as a code owner May 18, 2025 02:56
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mrhhsg
Copy link
Member Author

mrhhsg commented May 18, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40113 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1c1f38a6734896dfb482501225035f62af21fe9d, data reload: false

------ Round 1 ----------------------------------
q1	17579	7591	6682	6682
q2	2070	169	171	169
q3	10621	1096	1162	1096
q4	10572	773	680	680
q5	7742	2877	2801	2801
q6	220	135	132	132
q7	966	611	594	594
q8	9359	1934	2027	1934
q9	6642	6379	6411	6379
q10	6945	2305	2248	2248
q11	455	256	258	256
q12	398	209	202	202
q13	17784	2978	2960	2960
q14	240	206	204	204
q15	515	469	455	455
q16	640	592	578	578
q17	987	629	585	585
q18	7320	6719	6687	6687
q19	1404	1103	969	969
q20	499	214	201	201
q21	4037	3311	3342	3311
q22	1081	990	990	990
Total cold run time: 108076 ms
Total hot run time: 40113 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6610	6574	6565	6565
q2	327	231	232	231
q3	2883	2806	2894	2806
q4	2023	1762	1750	1750
q5	5779	5730	5744	5730
q6	208	129	127	127
q7	2196	1827	1813	1813
q8	3359	3578	3517	3517
q9	8928	8826	8908	8826
q10	3564	3537	3500	3500
q11	601	495	474	474
q12	788	597	634	597
q13	10080	3126	3144	3126
q14	292	261	265	261
q15	513	465	462	462
q16	676	657	683	657
q17	1856	1597	1605	1597
q18	8295	7909	7861	7861
q19	1710	1527	1452	1452
q20	2009	1816	1856	1816
q21	5523	5257	5192	5192
q22	1156	1059	1028	1028
Total cold run time: 69376 ms
Total hot run time: 59388 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198197 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1c1f38a6734896dfb482501225035f62af21fe9d, data reload: false

query1	1296	917	902	902
query2	6265	1981	1982	1981
query3	10865	4501	4483	4483
query4	59661	29356	23818	23818
query5	5184	453	438	438
query6	397	164	175	164
query7	5549	312	301	301
query8	304	224	217	217
query9	8836	2618	2600	2600
query10	472	276	259	259
query11	18107	15199	15655	15199
query12	165	103	101	101
query13	1499	467	433	433
query14	10527	7412	7529	7412
query15	207	179	192	179
query16	7186	518	486	486
query17	1122	596	577	577
query18	2003	334	322	322
query19	214	166	161	161
query20	118	109	111	109
query21	214	101	102	101
query22	4667	4706	4642	4642
query23	34584	33921	34055	33921
query24	6164	2899	2932	2899
query25	531	429	413	413
query26	655	173	174	173
query27	1703	358	354	354
query28	3961	2513	2476	2476
query29	735	432	417	417
query30	256	161	156	156
query31	1022	817	815	815
query32	68	55	56	55
query33	408	298	284	284
query34	923	508	527	508
query35	893	719	729	719
query36	1098	951	961	951
query37	112	68	69	68
query38	4056	4028	3946	3946
query39	1540	1500	1497	1497
query40	194	100	101	100
query41	48	51	48	48
query42	119	106	103	103
query43	530	494	487	487
query44	1169	832	836	832
query45	189	165	167	165
query46	1246	729	713	713
query47	1964	1906	1951	1906
query48	474	381	400	381
query49	719	388	401	388
query50	849	442	435	435
query51	7335	7242	7206	7206
query52	103	90	90	90
query53	265	182	180	180
query54	573	459	462	459
query55	79	77	75	75
query56	256	250	251	250
query57	1286	1172	1150	1150
query58	226	202	210	202
query59	3139	3086	3077	3077
query60	291	260	261	260
query61	141	113	116	113
query62	827	702	684	684
query63	223	194	192	192
query64	1425	699	655	655
query65	3342	3208	3230	3208
query66	708	290	298	290
query67	15957	15604	15715	15604
query68	4307	573	574	573
query69	430	265	264	264
query70	1200	1156	1144	1144
query71	350	248	249	248
query72	6339	4012	4125	4012
query73	756	343	351	343
query74	10247	9372	8862	8862
query75	3303	2658	2679	2658
query76	2134	982	1008	982
query77	512	282	274	274
query78	10451	9637	9595	9595
query79	2062	608	600	600
query80	1261	424	427	424
query81	540	240	239	239
query82	528	91	89	89
query83	169	143	139	139
query84	276	79	77	77
query85	957	302	289	289
query86	370	300	283	283
query87	4539	4304	4311	4304
query88	3817	2370	2352	2352
query89	420	290	293	290
query90	2004	188	186	186
query91	182	150	147	147
query92	60	49	51	49
query93	2467	555	553	553
query94	764	302	303	302
query95	359	276	258	258
query96	622	276	281	276
query97	3314	3130	3120	3120
query98	215	205	197	197
query99	1555	1278	1310	1278
Total cold run time: 313754 ms
Total hot run time: 198197 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.4 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1c1f38a6734896dfb482501225035f62af21fe9d, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.10	0.11
query5	0.53	0.51	0.50
query6	1.13	0.73	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.02
query9	0.58	0.50	0.50
query10	0.55	0.56	0.57
query11	0.14	0.10	0.10
query12	0.14	0.10	0.11
query13	0.61	0.59	0.59
query14	2.75	2.74	2.77
query15	0.89	0.83	0.83
query16	0.38	0.38	0.37
query17	1.00	1.04	1.01
query18	0.24	0.20	0.20
query19	1.87	1.83	2.04
query20	0.02	0.01	0.00
query21	15.37	0.60	0.59
query22	2.61	2.34	1.66
query23	16.88	0.93	0.90
query24	3.04	0.39	0.64
query25	0.27	0.15	0.05
query26	0.30	0.14	0.13
query27	0.05	0.05	0.04
query28	11.45	0.47	0.45
query29	12.59	3.24	3.19
query30	0.24	0.06	0.06
query31	2.87	0.37	0.38
query32	3.25	0.46	0.46
query33	2.98	2.99	3.04
query34	17.10	4.50	4.48
query35	4.52	4.56	4.55
query36	0.70	0.48	0.48
query37	0.09	0.06	0.06
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.12	0.11
query41	0.07	0.02	0.02
query42	0.05	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.53 s
Total hot run time: 31.4 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 16.67% (1/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.04% (10839/26410)
Line Coverage 31.86% (92528/290456)
Region Coverage 30.94% (47756/154350)
Branch Coverage 27.40% (24444/89204)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 18, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit e06e252 into apache:branch-3.0 May 18, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants