Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #51058

### What problem does this PR solve?

Related PR: #40715

Problem Summary:

this problem intro by #40715, when do replace view, full schema do not
be set correctly. So view's schema will lost after replace.
@github-actions github-actions bot requested a review from dataroaring as a code owner May 20, 2025 07:32
@Thearas
Copy link
Contributor

Thearas commented May 20, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this May 20, 2025
@Thearas
Copy link
Contributor

Thearas commented May 20, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39650 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 806b00dcfecf367be594405df1d9ab4d1a9d1919, data reload: false

------ Round 1 ----------------------------------
q1	17563	6679	6575	6575
q2	2073	167	174	167
q3	10572	1082	1139	1082
q4	10526	722	802	722
q5	7722	2860	2771	2771
q6	217	133	132	132
q7	957	607	601	601
q8	9364	1960	2005	1960
q9	6577	6364	6351	6351
q10	7038	2244	2285	2244
q11	469	256	255	255
q12	399	218	209	209
q13	17786	2975	2966	2966
q14	240	211	211	211
q15	512	466	470	466
q16	662	591	580	580
q17	962	572	515	515
q18	7202	6622	6550	6550
q19	1483	1070	1050	1050
q20	458	201	208	201
q21	3931	3106	3073	3073
q22	1114	987	969	969
Total cold run time: 107827 ms
Total hot run time: 39650 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6562	6586	6531	6531
q2	326	228	227	227
q3	2858	2740	2762	2740
q4	2043	1795	1771	1771
q5	5775	5721	5740	5721
q6	209	127	127	127
q7	2185	1785	1812	1785
q8	3333	3522	3500	3500
q9	8914	8698	8852	8698
q10	3529	3493	3549	3493
q11	580	487	500	487
q12	792	606	563	563
q13	9899	3168	3114	3114
q14	312	282	264	264
q15	492	465	468	465
q16	691	673	654	654
q17	1840	1653	1594	1594
q18	8233	7825	7736	7736
q19	1690	1488	1572	1488
q20	2091	1833	1899	1833
q21	5518	5333	5446	5333
q22	1143	1031	1025	1025
Total cold run time: 69015 ms
Total hot run time: 59149 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196838 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 806b00dcfecf367be594405df1d9ab4d1a9d1919, data reload: false

query1	1289	899	903	899
query2	6223	1971	1982	1971
query3	10827	4424	4285	4285
query4	65799	28723	23452	23452
query5	4937	442	439	439
query6	400	179	169	169
query7	5523	316	307	307
query8	295	213	210	210
query9	8666	2604	2618	2604
query10	454	269	250	250
query11	17242	15156	15768	15156
query12	164	103	106	103
query13	1487	450	436	436
query14	10693	7326	7376	7326
query15	200	182	191	182
query16	7168	480	458	458
query17	1089	630	584	584
query18	1964	322	307	307
query19	205	157	158	157
query20	123	119	113	113
query21	206	103	101	101
query22	4532	4326	4360	4326
query23	35053	34109	34218	34109
query24	6306	2903	2949	2903
query25	525	416	422	416
query26	660	169	169	169
query27	1887	353	364	353
query28	4240	2511	2460	2460
query29	696	434	427	427
query30	239	161	161	161
query31	968	823	828	823
query32	69	53	57	53
query33	432	276	287	276
query34	934	519	516	516
query35	827	721	746	721
query36	1088	933	959	933
query37	110	63	69	63
query38	4070	4003	4015	4003
query39	1499	1452	1472	1452
query40	201	99	96	96
query41	50	46	46	46
query42	113	102	104	102
query43	525	486	485	485
query44	1173	819	803	803
query45	183	169	173	169
query46	1161	731	751	731
query47	2043	1904	1952	1904
query48	493	389	380	380
query49	723	394	390	390
query50	822	424	429	424
query51	7385	7294	7154	7154
query52	99	88	93	88
query53	251	178	186	178
query54	557	450	444	444
query55	75	76	83	76
query56	256	230	241	230
query57	1238	1085	1097	1085
query58	208	198	203	198
query59	3079	2882	2918	2882
query60	273	252	249	249
query61	111	155	111	111
query62	800	666	671	666
query63	212	183	182	182
query64	1359	653	632	632
query65	3272	3187	3201	3187
query66	710	286	292	286
query67	15626	15733	15494	15494
query68	4217	595	584	584
query69	431	262	266	262
query70	1159	1074	1105	1074
query71	353	255	255	255
query72	6415	3991	4099	3991
query73	744	348	369	348
query74	10248	9176	9024	9024
query75	3362	2644	2647	2644
query76	1891	1093	1186	1093
query77	518	273	297	273
query78	10534	9541	9523	9523
query79	1414	596	605	596
query80	889	432	435	432
query81	508	246	238	238
query82	980	89	90	89
query83	162	151	142	142
query84	283	73	77	73
query85	830	298	290	290
query86	326	298	293	293
query87	4412	4244	4244	4244
query88	3822	2410	2370	2370
query89	416	290	285	285
query90	2046	184	186	184
query91	183	149	146	146
query92	61	51	52	51
query93	1752	562	557	557
query94	811	302	280	280
query95	356	246	252	246
query96	602	283	281	281
query97	3288	3135	3152	3135
query98	212	197	194	194
query99	2036	1296	1321	1296
Total cold run time: 317348 ms
Total hot run time: 196838 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.21 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 806b00dcfecf367be594405df1d9ab4d1a9d1919, data reload: false

query1	0.03	0.04	0.03
query2	0.07	0.03	0.03
query3	0.23	0.06	0.06
query4	1.64	0.11	0.10
query5	0.53	0.51	0.50
query6	1.14	0.73	0.72
query7	0.02	0.01	0.02
query8	0.03	0.03	0.03
query9	0.57	0.52	0.51
query10	0.54	0.54	0.55
query11	0.15	0.10	0.10
query12	0.16	0.12	0.11
query13	0.62	0.60	0.60
query14	2.84	2.84	2.76
query15	0.90	0.82	0.83
query16	0.39	0.38	0.38
query17	1.06	1.05	1.03
query18	0.23	0.22	0.20
query19	1.85	1.72	2.07
query20	0.01	0.01	0.02
query21	15.35	0.61	0.56
query22	2.67	2.15	2.43
query23	16.81	1.20	0.79
query24	3.41	0.90	1.20
query25	0.17	0.09	0.04
query26	0.56	0.14	0.14
query27	0.04	0.05	0.04
query28	10.24	0.53	0.49
query29	12.55	3.25	3.26
query30	0.24	0.06	0.07
query31	2.86	0.39	0.39
query32	3.25	0.46	0.46
query33	2.96	3.01	3.01
query34	16.99	4.46	4.42
query35	4.51	4.53	4.48
query36	0.67	0.46	0.48
query37	0.08	0.06	0.06
query38	0.04	0.03	0.04
query39	0.04	0.02	0.02
query40	0.16	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.76 s
Total hot run time: 32.21 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 53e33c8 into branch-3.0 May 21, 2025
23 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-51058-branch-3.0 branch May 21, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants