Skip to content

[fix](case)fix mark_join and right_semi_mark_join has same table name #51124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
starocean999 merged 3 commits into from
May 22, 2025
Merged

[fix](case)fix mark_join and right_semi_mark_join has same table name #51124

starocean999 merged 3 commits into from
May 22, 2025

Conversation

@zddr
Copy link
Contributor

@zddr zddr commented May 21, 2025 •
edited by morrySnow
Loading

What problem does this PR solve?

Related PR: #50720

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented May 21, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zddr
Copy link
Contributor Author

zddr commented May 21, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2025

PR approved by anyone and no changes requested.

zfr9527
zfr9527 approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor

@zfr9527 zfr9527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@starocean999 starocean999 merged commit 4dfafd4 into apache:master May 22, 2025
34 checks passed
@mrhhsg mrhhsg mentioned this pull request May 22, 2025
Closed
16 tasks
mrhhsg pushed a commit to mrhhsg/doris that referenced this pull request May 22, 2025
@zddr @mrhhsg
[fix](case)fix mark_join and right_semi_mark_join has same table name (…
5b5f7ac 
…apache#51124)

Related PR: apache#50720
@mrhhsg mrhhsg mentioned this pull request May 22, 2025
Merged
16 tasks
zddr added a commit to zddr/incubator-doris that referenced this pull request May 22, 2025
@zddr
[fix](case)fix mark_join and right_semi_mark_join has same table name (…
538da7e 
…apache#51124)

Related PR: apache#50720
@zddr zddr mentioned this pull request May 22, 2025
Merged
zddr added a commit to zddr/incubator-doris that referenced this pull request May 22, 2025
@zddr
[fix](case)fix mark_join and right_semi_mark_join has same table name (…
4ea19ab 
…apache#51124)

Related PR: apache#50720
@zddr zddr mentioned this pull request May 22, 2025
Closed
yiguolei pushed a commit that referenced this pull request May 22, 2025
@zddr
branch-2.1:[fix](case)fix mark_join and right_semi_mark_join has same…
8cca998 
… table name… (#51158)

… (#51124)

pick: #51124
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@zddr @koarz
[fix](case)fix mark_join and right_semi_mark_join has same table name (…
d921e1d 
…apache#51124)

Related PR: apache#50720
dataroaring pushed a commit that referenced this pull request Jun 11, 2025
@mrhhsg @zddr
[fix](join)Consider mark join when computing right_col_idx(#50720) (#…
ea52c3f 
…51156)

### What problem does this PR solve?

Pick #50720 #50993 #51124

Co-authored-by: zhangdong <zhangdong@selectdb.com>
zddr added a commit to zddr/incubator-doris that referenced this pull request Jun 20, 2025
@zddr
[fix](case)fix mark_join and right_semi_mark_join has same table name (…
d701467 
…apache#51124)

Related PR: apache#50720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999 starocean999 starocean999 approved these changes

@morrySnow morrySnow morrySnow approved these changes

+1 more reviewer

@zfr9527 zfr9527 zfr9527 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.11-merged dev/3.0.7-merged dev/3.1.0-merged p0_test reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zddr @Thearas @starocean999 @zfr9527 @morrySnow @yiguolei @dataroaring