-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](nereids) fix sum0 cannot pass multi distinct check #51234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](nereids) fix sum0 cannot pass multi distinct check #51234
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 34142 ms |
TPC-DS: Total hot run time: 192397 ms |
ClickBench: Total hot run time: 29.14 s |
|
run buildall |
TPC-H: Total hot run time: 33931 ms |
TPC-DS: Total hot run time: 193499 ms |
ClickBench: Total hot run time: 29.14 s |
| (4,5,6),(4,5,7),(4,5,8), | ||
| (5,0,0),(5,0,0),(5,0,0); | ||
| """ | ||
| sql "select sum0(distinct b),sum(distinct c) from test_sum0_multi_distinct_with_group_by group by a" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test all null case, could sum0(distinct b) get right result?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
0c53bcd to
9cb7dd0
Compare
|
run buildall |
TPC-H: Total hot run time: 33772 ms |
TPC-DS: Total hot run time: 186223 ms |
ClickBench: Total hot run time: 28.98 s |
|
run feut |
1 similar comment
|
run feut |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
### What problem does this PR solve? Related PR: #32541 Problem Summary: Before this pr, execute below sql will report error: sum0(DISTINCT c#2) can't support multi distinct. This pr change the check, and the sql can be executed. sql is: select sum0(distinct b),sum(distinct c) from test_sum0_multi_distinct_with_group_by group by a
### What problem does this PR solve? Related PR: apache#32541 Problem Summary: Before this pr, execute below sql will report error: sum0(DISTINCT c#2) can't support multi distinct. This pr change the check, and the sql can be executed. sql is: select sum0(distinct b),sum(distinct c) from test_sum0_multi_distinct_with_group_by group by a
### What problem does this PR solve? Related PR: #32541 Problem Summary: Before this pr, execute below sql will report error: sum0(DISTINCT c#2) can't support multi distinct. This pr change the check, and the sql can be executed. sql is: select sum0(distinct b),sum(distinct c) from test_sum0_multi_distinct_with_group_by group by a
### What problem does this PR solve? Related PR: apache#32541 Problem Summary: Before this pr, execute below sql will report error: sum0(DISTINCT c#2) can't support multi distinct. This pr change the check, and the sql can be executed. sql is: select sum0(distinct b),sum(distinct c) from test_sum0_multi_distinct_with_group_by group by a
### What problem does this PR solve? Related PR: apache#32541 Problem Summary: Before this pr, execute below sql will report error: sum0(DISTINCT c#2) can't support multi distinct. This pr change the check, and the sql can be executed. sql is: select sum0(distinct b),sum(distinct c) from test_sum0_multi_distinct_with_group_by group by a
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #32541
Problem Summary:
Before this pr,
sql like this will report error: sum0(DISTINCT c#2) can't support multi distinct.
This pr change the check, and the sql can be executed.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)