-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improvement](jdbc catalog) Optimize the acquisition of indentity type in SQLServer #51285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
run buildall |
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 34117 ms |
TPC-DS: Total hot run time: 185743 ms |
ClickBench: Total hot run time: 29.21 s |
|
run buildall |
TPC-H: Total hot run time: 33786 ms |
TPC-DS: Total hot run time: 192286 ms |
ClickBench: Total hot run time: 29.08 s |
3944744 to
9c107be
Compare
|
run buildall |
TPC-H: Total hot run time: 33645 ms |
TPC-DS: Total hot run time: 191976 ms |
ClickBench: Total hot run time: 29.33 s |
|
PR approved by at least one committer and no changes requested. |
…e in SQLServer (#51285) 1、In SQLServer, if a type is indentity, then the display of its original type may be changed, such as decimal -> decima(), so we get the string from subscript 0 to ( before as typename 2、For decimal, we should use the unified createDecimalOrStringType method to build the type
…e in SQLServer (apache#51285) 1、In SQLServer, if a type is indentity, then the display of its original type may be changed, such as decimal -> decima(), so we get the string from subscript 0 to ( before as typename 2、For decimal, we should use the unified createDecimalOrStringType method to build the type
…e in SQLServer (apache#51285) 1、In SQLServer, if a type is indentity, then the display of its original type may be changed, such as decimal -> decima(), so we get the string from subscript 0 to ( before as typename 2、For decimal, we should use the unified createDecimalOrStringType method to build the type
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
1、In SQLServer, if a type is indentity, then the display of its original type may be changed, such as decimal -> decima(), so we get the string from subscript 0 to ( before as typename
2、For decimal, we should use the unified createDecimalOrStringType method to build the type
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)