Skip to content

[enhancement](memoryfailed) throw exception if block.serialize meet error status #51335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BiteTheDDDDt merged 1 commit into from
May 29, 2025
Merged

[enhancement](memoryfailed) throw exception if block.serialize meet error status #51335

BiteTheDDDDt merged 1 commit into from
May 29, 2025

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented May 28, 2025 •
edited
Loading

What problem does this PR solve?

throw exception if block.serialize meet error status
related with #49876

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented May 28, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented May 28, 2025

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels May 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2025

PR approved by anyone and no changes requested.

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented May 29, 2025

run buildall

1 similar comment
@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented May 29, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented May 29, 2025

BE Regression && UT Coverage Report

Increment line coverage 60.00% (3/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 79.37% (20908/26342)
Line Coverage 72.24% (214981/297612)
Region Coverage 70.22% (126169/179670)
Branch Coverage 63.92% (65226/102036)

@hello-stephen
Copy link
Contributor

hello-stephen commented May 29, 2025

BE Regression && UT Coverage Report

Increment line coverage 60.00% (3/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 79.61% (20970/26342)
Line Coverage 72.75% (216515/297612)
Region Coverage 70.94% (127457/179670)
Branch Coverage 64.61% (65921/102036)

@BiteTheDDDDt BiteTheDDDDt merged commit 56eee07 into apache:master May 29, 2025
34 of 37 checks passed
github-actions bot pushed a commit that referenced this pull request May 29, 2025
@BiteTheDDDDt
[enhancement](memoryfailed) throw exception if block.serialize meet e…
c7bef62 
…rror status (#51335)

throw exception if block.serialize meet error status
@github-actions github-actions bot mentioned this pull request May 29, 2025
Merged
github-actions bot pushed a commit that referenced this pull request May 29, 2025
@BiteTheDDDDt
[enhancement](memoryfailed) throw exception if block.serialize meet e…
8606b59 
…rror status (#51335)

throw exception if block.serialize meet error status
@github-actions github-actions bot mentioned this pull request May 29, 2025
Merged
BiteTheDDDDt added a commit to BiteTheDDDDt/incubator-doris that referenced this pull request May 29, 2025
@BiteTheDDDDt
[enhancement](memoryfailed) throw exception if block.serialize meet e…
15bec9b 
…rror status (apache#51335)

throw exception if block.serialize meet error status
@BiteTheDDDDt BiteTheDDDDt mentioned this pull request May 29, 2025
Closed
yiguolei pushed a commit that referenced this pull request May 30, 2025
@github-actions @BiteTheDDDDt
branch-2.1: [enhancement](memoryfailed) throw exception if block.seri…
92fa037 
…alize meet error status #51335 (#51365)

Cherry-picked from #51335

Co-authored-by: Pxl <xl@selectdb.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@BiteTheDDDDt @koarz
[enhancement](memoryfailed) throw exception if block.serialize meet e…
8e15f28 
…rror status (apache#51335)

throw exception if block.serialize meet error status
dataroaring pushed a commit that referenced this pull request Jun 11, 2025
@github-actions @BiteTheDDDDt
branch-3.0: [enhancement](memoryfailed) throw exception if block.seri…
3836a96 
…alize meet error status #51335 (#51364)

Cherry-picked from #51335

Co-authored-by: Pxl <xl@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@zhangstar333 zhangstar333 zhangstar333 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.x dev/2.1.11-merged dev/3.0.7-merged dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@BiteTheDDDDt @hello-stephen @yiguolei @zhangstar333 @dataroaring @morrySnow