[fix](inverted index) fix error when open empty index file #51393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
TPC-H: Total hot run time: 34007 ms |
TPC-DS: Total hot run time: 192460 ms |
ClickBench: Total hot run time: 29.12 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
dataroaring
force-pushed
the
fix-empty-index
branch
from
5f5041d to
f79a685
Compare
Contributor
|
run buildall |
TPC-H: Total hot run time: 34030 ms |
TPC-DS: Total hot run time: 192980 ms |
ClickBench: Total hot run time: 29.2 s |
airborne12
force-pushed
the
fix-empty-index
branch
from
f79a685 to
2596de1
Compare
Member
Author
|
run buildall |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the error that occurs when attempting to open an empty inverted index file by adding a proper empty file check and error reporting.
- Added a condition to verify if the file size is zero.
- Sets an error message and returns false to prevent CLucene errors.
Comments suppressed due to low confidence (1)
be/src/olap/rowset/segment_v2/inverted_index_fs_directory.cpp:116
- Consider caching h->_reader->size() in a local variable to avoid multiple calls, ensuring consistency and potentially improving performance.
if (h->_reader->size() == 0) {
TPC-H: Total hot run time: 33757 ms |
TPC-DS: Total hot run time: 186117 ms |
ClickBench: Total hot run time: 28.51 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
airborne12
force-pushed
the
fix-empty-index
branch
from
2596de1 to
b69af6d
Compare
Contributor
|
PR approved by anyone and no changes requested. |
Member
Author
|
run buildall |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
TPC-H: Total hot run time: 34034 ms |
TPC-DS: Total hot run time: 186501 ms |
ClickBench: Total hot run time: 29.25 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions bot
pushed a commit
that referenced
this pull request
Jun 3, 2025
Related PR: #50937 Problem Summary: This PR fixes the error that occurs when attempting to open an empty inverted index file by adding a proper empty file check and error reporting. Added a condition to verify if the file size is zero. Sets an error message and returns false to prevent CLucene errors.
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
) Related PR: apache#50937 Problem Summary: This PR fixes the error that occurs when attempting to open an empty inverted index file by adding a proper empty file check and error reporting. Added a condition to verify if the file size is zero. Sets an error message and returns false to prevent CLucene errors.
dataroaring
pushed a commit
that referenced
this pull request
Jun 11, 2025
16 tasks
airborne12
added a commit
that referenced
this pull request
Jun 20, 2025
Related PR: #51393 Problem Summary: This PR ensures that copying an empty inverted index segment no longer throws an exception.
zhiqiang-hhhh
pushed a commit
to zhiqiang-hhhh/doris
that referenced
this pull request
Jul 2, 2025
…#51984) Related PR: apache#51393 Problem Summary: This PR ensures that copying an empty inverted index segment no longer throws an exception.
zhiqiang-hhhh
pushed a commit
to zhiqiang-hhhh/doris
that referenced
this pull request
Jul 2, 2025
…#51984) Related PR: apache#51393 Problem Summary: This PR ensures that copying an empty inverted index segment no longer throws an exception.
airborne12
added a commit
to airborne12/apache-doris
that referenced
this pull request
Jul 7, 2025
…#51984) Related PR: apache#51393 Problem Summary: This PR ensures that copying an empty inverted index segment no longer throws an exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #50937
Problem Summary:
This PR fixes the error that occurs when attempting to open an empty inverted index file by adding a proper empty file check and error reporting.
Added a condition to verify if the file size is zero.
Sets an error message and returns false to prevent CLucene errors.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)