Skip to content

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Jun 10, 2025

pick #45287

… `RowsetMetaCloudPB` exceeds fdb's 100KB limits (apache#45287)

In cloud mode, `RowsetMetaCloudPB` will be stored as a value in fdb.
Segment key bounds is a member of `RowsetMetaCloudPB`. When the key
columns has long data, segment key bounds may be very large, causing the
size of `RowsetMetaCloudPB` be larger than the fdb 100KB limit, and will
cause load txn fail when put `RowsetMetaCloudPB` KV in fdb.

This PR add a config `segments_key_bounds_truncation_threshold` to limit
the max length of segment key bounds to avoid the problem. Segment key
bounds which are larger than the value of this config will be truncated.
The config will take effect when rowset is generated(load/schema
change/compaction/snapshot).

**Note that as long as the config
`segments_key_bounds_truncation_threshold` has ever been turned on,
cluster downgrade and backup restore are not supported any more.**
@bobhan1 bobhan1 requested a review from dataroaring as a code owner June 10, 2025 02:06
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jun 10, 2025

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.13% (1094/1316)
Line Coverage 66.35% (18242/27492)
Region Coverage 66.09% (9025/13655)
Branch Coverage 55.95% (4884/8730)

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jun 10, 2025

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.13% (1094/1316)
Line Coverage 66.38% (18248/27492)
Region Coverage 66.07% (9022/13655)
Branch Coverage 55.92% (4882/8730)

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 86.73% (85/98) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.11% (10876/26455)
Line Coverage 31.96% (93045/291161)
Region Coverage 31.04% (48006/154646)
Branch Coverage 27.53% (24603/89368)

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jun 10, 2025

run buildall

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.13% (1094/1316)
Line Coverage 66.34% (18238/27492)
Region Coverage 66.09% (9024/13655)
Branch Coverage 55.90% (4880/8730)

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 86.87% (86/99) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.10% (10874/26455)
Line Coverage 31.95% (93012/291161)
Region Coverage 31.02% (47974/154646)
Branch Coverage 27.52% (24598/89368)

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jun 10, 2025

run performance

1 similar comment
@bobhan1
Copy link
Contributor Author

bobhan1 commented Jun 10, 2025

run performance

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 68d2127 into apache:branch-3.0 Jun 11, 2025
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants