-
Notifications
You must be signed in to change notification settings - Fork 3.7k
branch-3.0: [opt](rowset meta) truncate segments key bounds if too large to avoid RowsetMetaCloudPB exceeds fdb's 100KB limits (#45287)
#51595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… `RowsetMetaCloudPB` exceeds fdb's 100KB limits (apache#45287) In cloud mode, `RowsetMetaCloudPB` will be stored as a value in fdb. Segment key bounds is a member of `RowsetMetaCloudPB`. When the key columns has long data, segment key bounds may be very large, causing the size of `RowsetMetaCloudPB` be larger than the fdb 100KB limit, and will cause load txn fail when put `RowsetMetaCloudPB` KV in fdb. This PR add a config `segments_key_bounds_truncation_threshold` to limit the max length of segment key bounds to avoid the problem. Segment key bounds which are larger than the value of this config will be truncated. The config will take effect when rowset is generated(load/schema change/compaction/snapshot). **Note that as long as the config `segments_key_bounds_truncation_threshold` has ever been turned on, cluster downgrade and backup restore are not supported any more.**
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run performance |
1 similar comment
|
run performance |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pick #45287