[fix](audit) fix potential NPE when auditing #51620

morningman · 2025-06-10T13:40:53Z

What problem does this PR solve?

2025-05-13 04:56:37,695 WARN (mysql-nio-pool-0|120) [AuditLogHelper.logAuditLog():77] Failed to write audit log.
java.lang.NullPointerException: Cannot invoke "String.equalsIgnoreCase(String)" because the return value of "org.apache.doris.nereids.trees.plans.commands.info.CreateTableInfo.getEngineName()" is null
at org.apache.doris.nereids.trees.plans.commands.CreateTableCommand.needAuditEncryption(CreateTableCommand.java:247) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.nereids.trees.plans.commands.NeedAuditEncryption.geneEncryptionSQL(NeedAuditEncryption.java:36) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.qe.AuditLogHelper.logAuditLogImpl(AuditLogHelper.java:280) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.qe.AuditLogHelper.logAuditLog(AuditLogHelper.java:75) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.qe.ConnectProcessor.auditAfterExec(ConnectProcessor.java:230) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.qe.ConnectProcessor.executeQuery(ConnectProcessor.java:377) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.qe.ConnectProcessor.handleQuery(ConnectProcessor.java:249) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.qe.MysqlConnectProcessor.handleQuery(MysqlConnectProcessor.java:233) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.qe.MysqlConnectProcessor.dispatch(MysqlConnectProcessor.java:261) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.qe.MysqlConnectProcessor.processOnce(MysqlConnectProcessor.java:444) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.mysql.ReadListener.lambda$handleEvent$0(ReadListener.java:52) ~[doris-fe.jar:1.2-SNAPSHOT]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
at java.lang.Thread.run(Thread.java:833) ~[?:?]

java.lang.NullPointerException: Cannot read field "start" because "properties" is null
at org.apache.doris.nereids.parser.LogicalPlanBuilderForEncryption.visitTableValuedFunction(LogicalPlanBuilderForEncryption.java:124) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.nereids.parser.LogicalPlanBuilderForEncryption.visitTableValuedFunction(LogicalPlanBuilderForEncryption.java:36) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.nereids.DorisParser$TableValuedFunctionContext.accept(DorisParser.java:41762) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.nereids.parser.LogicalPlanBuilder.plan(LogicalPlanBuilder.java:3226) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.nereids.parser.LogicalPlanBuilder.visitRelation(LogicalPlanBuilder.java:3142) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.nereids.parser.LogicalPlanBuilder.withRelations(LogicalPlanBuilder.java:3977) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.nereids.parser.LogicalPlanBuilder.lambda$visitRelations$39(LogicalPlanBuilder.java:3152) ~[doris-fe.jar:1.2-SNAPSHOT]

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2025-06-10T13:40:58Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

morningman · 2025-06-10T13:41:15Z

run buildall

doris-robot · 2025-06-10T14:10:01Z

TPC-H: Total hot run time: 34629 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 44d42d88e40d6ca353ea628defe5787fd07247f5, data reload: false

------ Round 1 ----------------------------------
q1	26081	5155	5152	5152
q2	1957	296	199	199
q3	10245	1319	695	695
q4	10217	1039	528	528
q5	7955	2502	2408	2408
q6	198	165	130	130
q7	956	737	628	628
q8	9314	1463	1290	1290
q9	6782	5347	5396	5347
q10	6847	2331	1889	1889
q11	491	281	275	275
q12	352	360	215	215
q13	17767	3725	3097	3097
q14	235	240	218	218
q15	560	490	488	488
q16	421	435	363	363
q17	594	917	371	371
q18	7665	7189	7226	7189
q19	1085	1063	602	602
q20	346	362	219	219
q21	4015	3204	2360	2360
q22	1080	1053	966	966
Total cold run time: 115163 ms
Total hot run time: 34629 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5349	5344	5315	5315
q2	255	332	224	224
q3	2202	2650	2325	2325
q4	1373	1850	1563	1563
q5	4566	4469	4404	4404
q6	254	171	126	126
q7	2028	1897	1781	1781
q8	2755	2783	2767	2767
q9	7140	7140	7250	7140
q10	3041	3189	2740	2740
q11	633	508	492	492
q12	683	762	604	604
q13	3509	3953	3267	3267
q14	277	292	265	265
q15	518	475	470	470
q16	448	486	430	430
q17	1180	1707	1446	1446
q18	7696	7547	7475	7475
q19	870	878	1086	878
q20	1978	2030	1846	1846
q21	4964	4363	4251	4251
q22	1077	1044	1005	1005
Total cold run time: 52796 ms
Total hot run time: 50814 ms

doris-robot · 2025-06-10T14:21:37Z

TPC-DS: Total hot run time: 186076 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 44d42d88e40d6ca353ea628defe5787fd07247f5, data reload: false

query1	995	488	512	488
query2	6567	1853	1875	1853
query3	6741	226	221	221
query4	26545	23654	23677	23654
query5	4569	634	471	471
query6	309	208	211	208
query7	4631	508	300	300
query8	267	223	213	213
query9	8634	2631	2643	2631
query10	478	335	272	272
query11	15652	15420	14784	14784
query12	172	111	109	109
query13	1648	512	411	411
query14	9597	6149	6140	6140
query15	203	194	190	190
query16	7553	625	452	452
query17	1173	685	543	543
query18	1997	407	302	302
query19	195	180	180	180
query20	135	124	121	121
query21	214	125	103	103
query22	4128	4062	3952	3952
query23	33950	33072	33071	33071
query24	8499	2411	2416	2411
query25	563	497	431	431
query26	1228	272	155	155
query27	2738	509	346	346
query28	4314	2162	2132	2132
query29	763	565	452	452
query30	291	236	188	188
query31	943	855	764	764
query32	77	66	70	66
query33	577	406	334	334
query34	800	846	532	532
query35	774	817	737	737
query36	971	979	892	892
query37	114	106	81	81
query38	4070	4181	4079	4079
query39	1482	1426	1414	1414
query40	219	131	114	114
query41	70	113	60	60
query42	125	110	108	108
query43	488	508	474	474
query44	1305	808	832	808
query45	181	174	174	174
query46	842	1030	626	626
query47	1732	1775	1748	1748
query48	399	419	308	308
query49	743	476	399	399
query50	629	685	423	423
query51	4152	4166	4140	4140
query52	106	102	104	102
query53	221	247	185	185
query54	569	570	511	511
query55	84	84	81	81
query56	354	295	286	286
query57	1173	1198	1130	1130
query58	271	264	250	250
query59	2707	2696	2632	2632
query60	322	316	299	299
query61	132	128	140	128
query62	795	726	654	654
query63	232	189	183	183
query64	4274	1033	718	718
query65	4278	4125	4162	4125
query66	1095	423	310	310
query67	15762	15523	15313	15313
query68	8924	909	528	528
query69	464	319	263	263
query70	1240	1113	1051	1051
query71	466	315	296	296
query72	5301	4751	4857	4751
query73	747	624	356	356
query74	8908	9265	8650	8650
query75	4266	3198	2682	2682
query76	3678	1194	751	751
query77	844	378	292	292
query78	10061	10175	9434	9434
query79	2075	788	586	586
query80	607	518	453	453
query81	496	268	223	223
query82	447	126	93	93
query83	283	256	233	233
query84	303	112	96	96
query85	798	414	322	322
query86	385	288	274	274
query87	4379	4406	4244	4244
query88	3421	2266	2274	2266
query89	383	321	282	282
query90	1868	218	212	212
query91	148	150	116	116
query92	80	65	60	60
query93	1628	935	577	577
query94	680	414	314	314
query95	373	300	291	291
query96	498	563	287	287
query97	2728	2733	2630	2630
query98	234	216	202	202
query99	1414	1393	1289	1289
Total cold run time: 275944 ms
Total hot run time: 186076 ms

doris-robot · 2025-06-10T14:26:47Z

ClickBench: Total hot run time: 28.78 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 44d42d88e40d6ca353ea628defe5787fd07247f5, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.11	0.11
query3	0.26	0.19	0.20
query4	1.59	0.19	0.19
query5	0.45	0.44	0.44
query6	1.17	0.66	0.66
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.59	0.51	0.53
query10	0.56	0.58	0.55
query11	0.17	0.11	0.11
query12	0.15	0.11	0.12
query13	0.61	0.60	0.61
query14	0.79	0.83	0.79
query15	0.87	0.84	0.86
query16	0.38	0.37	0.38
query17	1.01	1.06	1.03
query18	0.24	0.21	0.20
query19	1.90	1.83	1.89
query20	0.02	0.01	0.01
query21	15.41	0.87	0.55
query22	0.75	1.36	0.72
query23	14.73	1.39	0.60
query24	6.85	1.79	0.58
query25	0.51	0.19	0.06
query26	0.48	0.16	0.13
query27	0.05	0.05	0.05
query28	9.66	0.86	0.44
query29	12.53	3.99	3.29
query30	0.25	0.08	0.06
query31	2.82	0.61	0.39
query32	3.23	0.56	0.47
query33	3.00	3.04	3.11
query34	15.87	5.12	4.49
query35	4.51	4.49	4.50
query36	0.67	0.50	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.17	0.14	0.13
query41	0.08	0.02	0.03
query42	0.03	0.02	0.03
query43	0.03	0.02	0.02
Total cold run time: 102.79 s
Total hot run time: 28.78 s

github-actions · 2025-06-11T07:02:15Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-06-11T07:02:17Z

PR approved by anyone and no changes requested.

[fix](audit) fix potential NPE when auditing

44d42d8

morrySnow approved these changes Jun 11, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 11, 2025

github-actions bot added the reviewed label Jun 11, 2025

morningman added dev/2.1.x dev/3.0.x labels Jun 11, 2025

CalvinKirs approved these changes Jun 11, 2025

View reviewed changes

hubgeter approved these changes Jun 11, 2025

View reviewed changes

morningman merged commit dd71c1a into apache:master Jun 11, 2025
33 of 35 checks passed

github-actions bot added dev/3.0.x-conflict dev/2.1.x-conflict labels Jun 11, 2025

morningman removed dev/2.1.x dev/2.1.x-conflict labels Jun 14, 2025

morningman added dev/3.1.x and removed dev/3.0.x dev/3.0.x-conflict labels Jun 24, 2025

github-actions bot added the dev/3.1.x-conflict label Jun 24, 2025

morningman added the not-merge/3.1 label Jul 25, 2025

morrySnow removed dev/3.1.x dev/3.1.x-conflict labels Jul 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[fix](audit) fix potential NPE when auditing #51620

[fix](audit) fix potential NPE when auditing #51620

Uh oh!

morningman commented Jun 10, 2025 •

edited

Loading

Uh oh!

hello-stephen commented Jun 10, 2025

Uh oh!

morningman commented Jun 10, 2025

Uh oh!

doris-robot commented Jun 10, 2025

Uh oh!

doris-robot commented Jun 10, 2025

Uh oh!

doris-robot commented Jun 10, 2025

Uh oh!

github-actions bot commented Jun 11, 2025

Uh oh!

github-actions bot commented Jun 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[fix](audit) fix potential NPE when auditing #51620

[fix](audit) fix potential NPE when auditing #51620

Uh oh!

Conversation

morningman commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Jun 10, 2025

Uh oh!

morningman commented Jun 10, 2025

Uh oh!

doris-robot commented Jun 10, 2025

Uh oh!

doris-robot commented Jun 10, 2025

Uh oh!

doris-robot commented Jun 10, 2025

Uh oh!

github-actions bot commented Jun 11, 2025

Uh oh!

github-actions bot commented Jun 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

morningman commented Jun 10, 2025 •

edited

Loading