Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions be/src/cloud/cloud_tablet_mgr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@

namespace doris {
uint64_t g_tablet_report_inactive_duration_ms = 0;
bvar::Adder<uint64_t> g_base_compaction_not_frozen_tablet_num(
"base_compaction_not_frozen_tablet_num");
bvar::Adder<uint64_t> g_cumu_compaction_not_frozen_tablet_num(
"cumu_compaction_not_frozen_tablet_num");
namespace {

// port from
Expand Down Expand Up @@ -387,19 +391,25 @@ Status CloudTabletMgr::get_topn_tablets_to_compact(
using namespace std::chrono;
auto now = duration_cast<milliseconds>(system_clock::now().time_since_epoch()).count();
auto skip = [now, compaction_type](CloudTablet* t) {
int32_t max_version_config = t->max_version_config();
if (compaction_type == CompactionType::BASE_COMPACTION) {
return now - t->last_base_compaction_success_time_ms < config::base_compaction_freeze_interval_s * 1000 ||
now - t->last_base_compaction_failure_time() < config::min_compaction_failure_interval_ms;
bool is_recent_failure = now - t->last_base_compaction_failure_time() < config::min_compaction_failure_interval_ms;
bool is_frozen = (now - t->last_load_time_ms > config::compaction_load_max_freeze_interval_s * 1000
&& now - t->last_base_compaction_success_time_ms < config::base_compaction_freeze_interval_s * 1000
&& t->fetch_add_approximate_num_rowsets(0) < max_version_config / 2);
g_base_compaction_not_frozen_tablet_num << !is_frozen;
return is_recent_failure || is_frozen;
}

// If tablet has too many rowsets but not be compacted for a long time, compaction should be performed
// regardless of whether there is a load job recently.

int32_t max_version_config = t->max_version_config();
return now - t->last_cumu_compaction_failure_time() < config::min_compaction_failure_interval_ms ||
now - t->last_cumu_no_suitable_version_ms < config::min_compaction_failure_interval_ms ||
(now - t->last_load_time_ms > config::cu_compaction_freeze_interval_s * 1000
bool is_recent_failure = now - t->last_cumu_compaction_failure_time() < config::min_compaction_failure_interval_ms;
bool is_recent_no_suitable_version = now - t->last_cumu_no_suitable_version_ms < config::min_compaction_failure_interval_ms;
bool is_frozen = (now - t->last_load_time_ms > config::compaction_load_max_freeze_interval_s * 1000
&& now - t->last_cumu_compaction_success_time_ms < config::cumu_compaction_interval_s * 1000
&& t->fetch_add_approximate_num_rowsets(0) < max_version_config / 2);
g_cumu_compaction_not_frozen_tablet_num << !is_frozen;
return is_recent_failure || is_recent_no_suitable_version || is_frozen;
};
// We don't schedule tablets that are disabled for compaction
auto disable = [](CloudTablet* t) { return t->tablet_meta()->tablet_schema()->disable_auto_compaction(); };
Expand Down
2 changes: 1 addition & 1 deletion be/src/cloud/config.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ DEFINE_mInt32(sync_rowsets_slow_threshold_ms, "1000");

DEFINE_mInt64(min_compaction_failure_interval_ms, "5000");
DEFINE_mInt64(base_compaction_freeze_interval_s, "7200");
DEFINE_mInt64(cu_compaction_freeze_interval_s, "1200");
DEFINE_mInt64(compaction_load_max_freeze_interval_s, "1200");
DEFINE_mInt64(cumu_compaction_interval_s, "1800");

DEFINE_mInt32(compaction_timeout_seconds, "86400");
Expand Down
2 changes: 1 addition & 1 deletion be/src/cloud/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ DECLARE_mInt64(min_compaction_failure_interval_ms);
DECLARE_mBool(enable_new_tablet_do_compaction);
// For cloud read/write separate mode
DECLARE_mInt64(base_compaction_freeze_interval_s);
DECLARE_mInt64(cu_compaction_freeze_interval_s);
DECLARE_mInt64(compaction_load_max_freeze_interval_s);
DECLARE_mInt64(cumu_compaction_interval_s);

DECLARE_mInt32(compaction_timeout_seconds);
Expand Down
Loading