Skip to content

Fix MaterializedView select with CTE bug #5165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kangkaisen merged 2 commits into from
Jan 4, 2021
Merged

Fix MaterializedView select with CTE bug #5165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
356e5c0
Fix MaterializedView select with CTE bug
kangkaisen Dec 28, 2020
e5fd00c
Fix import
kangkaisen Jan 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@
import java.util.Map;
import java.util.HashSet;
import java.util.Set;
import java.util.UUID;

/**
* Constructs a non-executable single-node plan from an analyzed parse tree.
Expand All @@ -86,7 +85,7 @@ public class SingleNodePlanner {

private final PlannerContext ctx_;
private final ArrayList<ScanNode> scanNodes = Lists.newArrayList();
private Map<UUID, List<ScanNode>> selectStmtToScanNodes = Maps.newHashMap();
private Map<Analyzer, List<ScanNode>> selectStmtToScanNodes = Maps.newHashMap();
Copy link
Contributor

@EmmyMiao87 EmmyMiao87 Dec 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the Analyzer of CTE same as outer query?

Copy link
Contributor Author

@kangkaisen kangkaisen Dec 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.
For SQL

select id, t1 from(
select id, a as t1 from t
union all
select id, aaa as t1 from t
) k2;

The analyzer instances for select id, a as t1 from t and select id, aaa as t1 from t are different.
Such as, The analyzer instances for select id, a as t1 from t is 6177, which ancestors are[6219,6220,6221],
The analyzer instances for select id, aaa as t1 from t is 6225, which ancestors are[6247,6220,6221].


public SingleNodePlanner(PlannerContext ctx) {
ctx_ = ctx;
Expand Down Expand Up @@ -778,7 +777,7 @@ public boolean selectMaterializedView(QueryStmt queryStmt, Analyzer analyzer)
((InlineViewRef) tableRef).getAnalyzer());
}
}
List<ScanNode> scanNodeList = selectStmtToScanNodes.get(selectStmt.getId());
List<ScanNode> scanNodeList = selectStmtToScanNodes.get(selectStmt.getAnalyzer());
if (scanNodeList == null) {
return selectFailed;
}
Expand Down Expand Up @@ -1455,7 +1454,7 @@ private PlanNode createScanNode(Analyzer analyzer, TableRef tblRef, SelectStmt s
analyzer.materializeSlots(scanNode.getConjuncts());

scanNodes.add(scanNode);
List<ScanNode> scanNodeList = selectStmtToScanNodes.computeIfAbsent(selectStmt.getId(), k -> Lists.newArrayList());
List<ScanNode> scanNodeList = selectStmtToScanNodes.computeIfAbsent(selectStmt.getAnalyzer(), k -> Lists.newArrayList());
scanNodeList.add(scanNode);
return scanNode;
}
Expand Down