Skip to content

[Bug](function) fix wrong result of hll_to_base64 #51831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BiteTheDDDDt merged 1 commit into from
Jun 18, 2025
Merged

[Bug](function) fix wrong result of hll_to_base64 #51831

BiteTheDDDDt merged 1 commit into from
Jun 18, 2025

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Jun 17, 2025 •
edited
Loading

What problem does this PR solve?

W20250617 18:57:43.532994 1586470 status.h:435] meet error status: [RUNTIME_ERROR]hll_from_base64 decode failed: base64: AuQDAAAMAAMtAAFGAAN0AAOYAAG8AAXKAALaAAHiAALqAALyAAQoAQMrAQFVAQJuAQF3AQR6AQR/

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 17, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Jun 17, 2025

run buildall

HappenLee
HappenLee approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 17, 2025

BE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 56.33% (15048/26713)
Line Coverage 45.10% (134580/298374)
Region Coverage 44.24% (67683/152984)
Branch Coverage 38.83% (34732/89440)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 17, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 61.23% (16098/26290)
Line Coverage 50.76% (151386/298216)
Region Coverage 48.18% (86708/179958)
Branch Coverage 41.65% (42590/102246)

@BiteTheDDDDt BiteTheDDDDt merged commit 0cd4a15 into apache:master Jun 18, 2025
28 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 18, 2025
@BiteTheDDDDt
[Bug](function) fix wrong result of hll_to_base64 (#51831)
ae7730e 
W20250617 18:57:43.532994 1586470 status.h:435] meet error status:
[RUNTIME_ERROR]hll_from_base64 decode failed: base64:
AuQDAAAMAAMtAAFGAAN0AAOYAAG8AAXKAALaAAHiAALqAALyAAQoAQMrAQFVAQJuAQF3AQR6AQR/
@github-actions github-actions bot mentioned this pull request Jun 18, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jun 18, 2025
@BiteTheDDDDt
[Bug](function) fix wrong result of hll_to_base64 (#51831)
e989a3b 
W20250617 18:57:43.532994 1586470 status.h:435] meet error status:
[RUNTIME_ERROR]hll_from_base64 decode failed: base64:
AuQDAAAMAAMtAAFGAAN0AAOYAAG8AAXKAALaAAHiAALqAALyAAQoAQMrAQFVAQJuAQF3AQR6AQR/
@github-actions github-actions bot mentioned this pull request Jun 18, 2025
Merged
dataroaring pushed a commit that referenced this pull request Jun 18, 2025
@github-actions @BiteTheDDDDt
branch-3.0: [Bug](function) fix wrong result of hll_to_base64 #51831 (#…
3d28b86 
…51849)

Cherry-picked from #51831

Co-authored-by: Pxl <xl@selectdb.com>
github-actions bot pushed a commit that referenced this pull request Jun 19, 2025
@BiteTheDDDDt
[Bug](function) fix wrong result of hll_to_base64 (#51831)
255ba69 
W20250617 18:57:43.532994 1586470 status.h:435] meet error status:
[RUNTIME_ERROR]hll_from_base64 decode failed: base64:
AuQDAAAMAAMtAAFGAAN0AAOYAAG8AAXKAALaAAHiAALqAALyAAQoAQMrAQFVAQJuAQF3AQR6AQR/
@github-actions github-actions bot mentioned this pull request Jun 19, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jun 19, 2025
@github-actions @BiteTheDDDDt
branch-3.1: [Bug](function) fix wrong result of hll_to_base64 #51831 (#…
ee00251 
…51919)

Cherry-picked from #51831

Co-authored-by: Pxl <xl@selectdb.com>
yiguolei pushed a commit that referenced this pull request Jun 20, 2025
@github-actions @BiteTheDDDDt
branch-2.1: [Bug](function) fix wrong result of hll_to_base64 #51831 (#…
523879e 
…51855)

Cherry-picked from #51831

Co-authored-by: Pxl <xl@selectdb.com>
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

+1 more reviewer

@Mryange Mryange Mryange approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.11-merged dev/3.0.7-merged dev/3.1.0-merged p0_w reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@BiteTheDDDDt @hello-stephen @HappenLee @Mryange @yiguolei @dataroaring @morrySnow