Skip to content

branch-3.0: [fix](filecache) fix load_cache_info_into_memory crash #51684 #51904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Jun 19, 2025
Merged

branch-3.0: [fix](filecache) fix load_cache_info_into_memory crash #51684 #51904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion be/src/io/cache/block_file_cache.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,6 @@ class BlockFileCache {
size_t _max_query_cache_size = 0;

mutable std::mutex _mutex;
std::unique_ptr<FileCacheStorage> _storage;
bool _close {false};
std::mutex _close_mtx;
std::condition_variable _close_cv;
Expand Down Expand Up @@ -575,6 +574,11 @@ class BlockFileCache {
std::shared_ptr<bvar::LatencyRecorder> _evict_in_advance_latency_us;
std::shared_ptr<bvar::LatencyRecorder> _recycle_keys_length_recorder;
std::shared_ptr<bvar::LatencyRecorder> _ttl_gc_latency_us;
// keep _storage last so it will deconstruct first
// otherwise, load_cache_info_into_memory might crash
// coz it will use other members of BlockFileCache
// so join this async load thread first
std::unique_ptr<FileCacheStorage> _storage;
};

} // namespace doris::io
Loading