Skip to content

[refactor](fe) Merge MasterOpExecutor and FEOpExecutor (#50776) #51915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
morningman wants to merge 3 commits into from
Closed

[refactor](fe) Merge MasterOpExecutor and FEOpExecutor (#50776) #51915

morningman wants to merge 3 commits into from

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Jun 19, 2025

bp #50776

@morningman
[refactor](fe) Merge MasterOpExecutor and FEOpExecutor (apache#50776)
c1a50b2 
Related PR: apache#34685

Problem Summary:

This PR apache#34685 introduced `FEOpExecutor`, which is just a copy of
`MasterOpExecutor`.
Both class are used to forwarding request to a specific FE node, and
there are lots of duplicate code.
So I refactor the code to let `MasterOpExecutor` extends from
`FEOpExecutor`.

No logic being changed in this PR.
@morningman morningman requested a review from dataroaring as a code owner June 19, 2025 04:26
@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 19, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

morningman commented Jun 19, 2025

run buildall

@morningman
Copy link
Contributor Author

morningman commented Jun 19, 2025

run buildall

@morningman
Copy link
Contributor Author

morningman commented Jun 19, 2025

run buildall

@morningman morningman closed this Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring Awaiting requested review from dataroaring

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@morningman @hello-stephen