Skip to content

brach-3.0 cherry-pick [Fix](Variant) fix serialize with json key contains . as name #51930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jun 26, 2025
Merged

brach-3.0 cherry-pick [Fix](Variant) fix serialize with json key contains . as name #51930

dataroaring merged 1 commit into from
Jun 26, 2025

Conversation

@eldenmoon
Copy link
Member

@eldenmoon eldenmoon commented Jun 19, 2025

cherry-pick from #51857

@eldenmoon eldenmoon requested a review from dataroaring as a code owner June 19, 2025 06:54
@Thearas
Copy link
Contributor

Thearas commented Jun 19, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@eldenmoon
Copy link
Member Author

eldenmoon commented Jun 19, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 19, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.16% (1096/1318)
Line Coverage 66.41% (18342/27621)
Region Coverage 66.22% (9098/13739)
Branch Coverage 56.06% (4931/8796)

@eldenmoon
Copy link
Member Author

eldenmoon commented Jun 19, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jun 19, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/8) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.16% (10903/26487)
Line Coverage 31.96% (93238/291696)
Region Coverage 31.06% (48104/154898)
Branch Coverage 27.52% (24638/89528)

@dataroaring
Copy link
Contributor

dataroaring commented Jun 25, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 25, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.03% (1101/1326)
Line Coverage 66.45% (18551/27919)
Region Coverage 66.26% (9179/13854)
Branch Coverage 56.16% (4987/8880)

@doris-robot
Copy link

doris-robot commented Jun 25, 2025

TPC-H: Total hot run time: 40222 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 86c0614d3d2755b3ea29215ce72e2463fbe2ce04, data reload: false

------ Round 1 ----------------------------------
q1	17646	6910	6641	6641
q2	2073	176	166	166
q3	10624	1081	1196	1081
q4	10573	778	716	716
q5	7752	2909	2799	2799
q6	215	136	142	136
q7	969	623	605	605
q8	9365	2010	2067	2010
q9	6605	6485	6490	6485
q10	6984	2353	2312	2312
q11	463	269	264	264
q12	406	222	209	209
q13	17828	3039	3017	3017
q14	240	224	210	210
q15	504	462	478	462
q16	519	385	379	379
q17	997	598	614	598
q18	7503	6792	6730	6730
q19	1438	1092	1140	1092
q20	478	206	215	206
q21	4100	3233	3134	3134
q22	1107	982	970	970
Total cold run time: 108389 ms
Total hot run time: 40222 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6592	6557	6560	6557
q2	333	229	238	229
q3	2893	2761	2982	2761
q4	2116	1923	1852	1852
q5	5792	5793	5754	5754
q6	222	137	133	133
q7	2221	1807	1823	1807
q8	3408	3598	3537	3537
q9	8963	8882	9046	8882
q10	3580	3583	3508	3508
q11	608	497	490	490
q12	812	608	627	608
q13	9147	3253	3131	3131
q14	309	273	268	268
q15	521	475	460	460
q16	505	449	458	449
q17	1855	1642	1619	1619
q18	8263	7706	7796	7706
q19	1718	1599	1485	1485
q20	2088	1819	1898	1819
q21	5237	5115	5122	5115
q22	1155	1104	1080	1080
Total cold run time: 68338 ms
Total hot run time: 59250 ms

@doris-robot
Copy link

doris-robot commented Jun 25, 2025

TPC-DS: Total hot run time: 197420 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 86c0614d3d2755b3ea29215ce72e2463fbe2ce04, data reload: false

query1	1320	918	907	907
query2	6303	1933	1920	1920
query3	10964	4519	4378	4378
query4	62139	29853	23411	23411
query5	5170	466	455	455
query6	412	184	172	172
query7	5480	331	333	331
query8	310	233	228	228
query9	8725	2656	2684	2656
query10	464	272	252	252
query11	17584	15217	16301	15217
query12	172	108	107	107
query13	1441	458	434	434
query14	10400	7107	7204	7107
query15	201	179	190	179
query16	7113	485	475	475
query17	1136	590	614	590
query18	1923	333	315	315
query19	229	170	160	160
query20	115	110	108	108
query21	208	103	106	103
query22	4677	4458	4766	4458
query23	35128	33837	34188	33837
query24	6274	2937	2931	2931
query25	532	398	410	398
query26	652	171	164	164
query27	1883	364	359	359
query28	4252	2241	2218	2218
query29	683	439	442	439
query30	236	162	161	161
query31	979	805	838	805
query32	65	54	57	54
query33	434	298	304	298
query34	917	506	543	506
query35	841	724	725	724
query36	1072	975	970	970
query37	110	66	70	66
query38	4104	4036	3940	3940
query39	1512	1461	1456	1456
query40	209	99	100	99
query41	50	51	50	50
query42	125	108	102	102
query43	538	504	489	489
query44	1214	847	841	841
query45	190	175	171	171
query46	1162	759	760	759
query47	2017	1901	1944	1901
query48	485	384	389	384
query49	740	404	409	404
query50	844	434	426	426
query51	7525	7395	7233	7233
query52	101	92	92	92
query53	269	202	200	200
query54	581	475	488	475
query55	80	81	86	81
query56	290	258	252	252
query57	1309	1260	1208	1208
query58	228	213	228	213
query59	3248	3075	3225	3075
query60	268	252	241	241
query61	115	117	112	112
query62	773	674	674	674
query63	221	187	192	187
query64	1354	669	640	640
query65	3237	3168	3197	3168
query66	693	300	298	298
query67	15940	15697	15581	15581
query68	4064	601	581	581
query69	419	267	262	262
query70	1170	1135	1116	1116
query71	347	268	252	252
query72	6355	4107	4227	4107
query73	762	344	357	344
query74	10331	9289	9012	9012
query75	3321	2639	2661	2639
query76	1947	1095	1156	1095
query77	496	270	268	268
query78	10505	9623	9609	9609
query79	1439	597	605	597
query80	868	422	437	422
query81	488	222	217	217
query82	1257	89	88	88
query83	245	152	149	149
query84	283	86	77	77
query85	890	303	294	294
query86	342	309	300	300
query87	4393	4232	4222	4222
query88	3692	2441	2405	2405
query89	421	292	292	292
query90	1985	186	188	186
query91	183	150	153	150
query92	65	51	51	51
query93	1923	553	555	553
query94	741	297	302	297
query95	350	263	260	260
query96	624	287	285	285
query97	3334	3147	3171	3147
query98	213	214	202	202
query99	1562	1327	1296	1296
Total cold run time: 314981 ms
Total hot run time: 197420 ms

@doris-robot
Copy link

doris-robot commented Jun 25, 2025

ClickBench: Total hot run time: 32.06 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 86c0614d3d2755b3ea29215ce72e2463fbe2ce04, data reload: false

query1	0.04	0.03	0.03
query2	0.09	0.04	0.04
query3	0.23	0.06	0.06
query4	1.64	0.08	0.08
query5	0.53	0.51	0.51
query6	1.13	0.76	0.75
query7	0.02	0.02	0.02
query8	0.05	0.04	0.05
query9	0.56	0.52	0.51
query10	0.56	0.54	0.57
query11	0.17	0.13	0.12
query12	0.16	0.12	0.13
query13	0.61	0.60	0.61
query14	0.78	0.80	0.79
query15	0.85	0.86	0.84
query16	0.38	0.38	0.37
query17	1.01	1.07	1.01
query18	0.18	0.20	0.19
query19	1.87	1.85	1.92
query20	0.02	0.01	0.01
query21	15.40	0.67	0.67
query22	3.65	6.53	2.86
query23	18.24	1.43	1.49
query24	2.22	0.24	0.23
query25	0.15	0.09	0.08
query26	0.29	0.19	0.18
query27	0.08	0.08	0.08
query28	13.26	0.64	0.58
query29	12.74	3.35	3.32
query30	0.26	0.05	0.06
query31	2.86	0.42	0.41
query32	3.23	0.50	0.49
query33	3.02	3.00	2.99
query34	16.80	4.55	4.57
query35	4.62	4.57	4.65
query36	0.67	0.47	0.50
query37	0.20	0.16	0.17
query38	0.17	0.15	0.15
query39	0.06	0.04	0.05
query40	0.16	0.13	0.13
query41	0.10	0.05	0.05
query42	0.06	0.05	0.04
query43	0.05	0.05	0.05
Total cold run time: 109.17 s
Total hot run time: 32.06 s

dataroaring
dataroaring approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 1c2ba48 into apache:branch-3.0 Jun 26, 2025
21 of 25 checks passed
koarz pushed a commit to koarz/doris that referenced this pull request Jul 3, 2025
@eldenmoon @koarz
brach-3.0 cherry-pick [Fix](Variant) fix serialize with json key cont…
c3db552 
…ains `.` as name (apache#51930)

cherry-pick from apache#51857
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eldenmoon @Thearas @hello-stephen @doris-robot @dataroaring