Skip to content

Conversation

@zhangstar333
Copy link
Contributor

What problem does this PR solve?

Problem Summary:
pick from master (#38259) (#47676) (#51293) (#49381)

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

zhangstar333 and others added 4 commits June 20, 2025 10:14
…t set bug. (apache#47676)

### What problem does this PR solve?

split_by_regexp function's third parameter doesn't support tinyint. This
pr is to fix it.

```
mysql> select split_by_regexp('aa,bb,cc', ',', 1);
ERROR 1105 (HY000): errCode = 2, detailMessage = the third parameter of split_by_regexp function must be a positive constant: split_by_regexp('aa,bb,cc', ',', 1)
```
…pache#51293)

when pattern is empty, it's should split all alone , not return error
msg
`mysql> select id,name,score, k,v from table_test lateral view
posexplode(split_by_regexp(name,'')) tmp as k,v order by id;
ERROR 1105 (HY000): errCode = 2, detailMessage =
(10.16.10.2)[RUNTIME_ERROR]Invalid pattern:`
…arams (apache#49381)

support lead/lag function could input column
eg: lead(col,1,col)/lag(col,1,col)
@zhangstar333 zhangstar333 requested a review from morrySnow as a code owner June 20, 2025 02:23
@zhangstar333
Copy link
Contributor Author

run buildall

@Thearas
Copy link
Contributor

Thearas commented Jun 20, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.19% (1099/1321)
Line Coverage 66.44% (18502/27848)
Region Coverage 66.15% (9148/13830)
Branch Coverage 55.94% (4941/8832)

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 6.39% (17/266) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.17% (10902/26482)
Line Coverage 31.98% (93256/291586)
Region Coverage 31.05% (48086/154869)
Branch Coverage 27.52% (24632/89512)

@morrySnow morrySnow merged commit d538b6f into apache:branch-3.1 Jun 20, 2025
20 of 24 checks passed
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 20, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants