[Bug](aggregate) fix bitmap_union return error result in query sql #52033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
16 tasks
TPC-H: Total hot run time: 34060 ms |
TPC-DS: Total hot run time: 185134 ms |
ClickBench: Total hot run time: 29.22 s |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
zhangstar333
added a commit
to zhangstar333/incubator-doris
that referenced
this pull request
Jul 9, 2025
…pache#52033) Problem Summary: the bitmap union maybe could call add_batch firstly, and the call add function, so if add_batch function not update is_first variable, it's will be loss data in union. ``` static void add(BitmapValue& res, const BitmapValue& data, bool& is_first) { if (UNLIKELY(is_first)) { res = data; is_first = false; } else { res |= data; } } static void add_batch(BitmapValue& res, std::vector<const BitmapValue*>& data, bool& is_first) { res.fastunion(data); is_first = false; // before not set this } ```
zhangstar333
added a commit
to zhangstar333/incubator-doris
that referenced
this pull request
Jul 9, 2025
…pache#52033) Problem Summary: the bitmap union maybe could call add_batch firstly, and the call add function, so if add_batch function not update is_first variable, it's will be loss data in union. ``` static void add(BitmapValue& res, const BitmapValue& data, bool& is_first) { if (UNLIKELY(is_first)) { res = data; is_first = false; } else { res |= data; } } static void add_batch(BitmapValue& res, std::vector<const BitmapValue*>& data, bool& is_first) { res.fastunion(data); is_first = false; // before not set this } ```
This was referenced Jul 9, 2025
dataroaring
pushed a commit
that referenced
this pull request
Jul 9, 2025
…y sql (#52033) (#52999) ### What problem does this PR solve? Problem Summary: cherry-pick from master (#52033) ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
the bitmap union maybe could call add_batch firstly, and the call add function,
so if add_batch function not update is_first variable, it's will be loss data in union.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)