Skip to content

Conversation

@yiguolei
Copy link
Contributor

@yiguolei yiguolei commented Jun 20, 2025

What problem does this PR solve?

pick #51786
pick #51929

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@yiguolei yiguolei requested a review from morrySnow as a code owner June 20, 2025 09:37
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Contributor

run buildall

@morrySnow morrySnow changed the title [branch-3.1](pick) fix memory leak for tabletschema and result cache and fix memleak in arrow input stream branch-3.1: [fix](memleak) fix memory leak for tabletschema and result cache and fix memleak in arrow input stream Jun 20, 2025
@doris-robot
Copy link

TPC-H: Total hot run time: 39711 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 04076b6d01df23bc9f5fd0c7cd9fb80fadcda302, data reload: false

------ Round 1 ----------------------------------
q1	17807	7038	6602	6602
q2	2069	170	163	163
q3	10653	1083	1143	1083
q4	10432	765	806	765
q5	7760	2866	2888	2866
q6	212	138	141	138
q7	970	632	608	608
q8	9350	1944	1992	1944
q9	6751	6471	6396	6396
q10	7039	2257	2312	2257
q11	464	261	262	261
q12	395	208	209	208
q13	17783	2978	2989	2978
q14	238	206	214	206
q15	496	461	459	459
q16	479	369	373	369
q17	992	536	607	536
q18	7384	6792	6632	6632
q19	1438	1028	1015	1015
q20	463	199	190	190
q21	3899	3246	3069	3069
q22	1114	980	966	966
Total cold run time: 108188 ms
Total hot run time: 39711 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6621	6549	6545	6545
q2	323	231	234	231
q3	2918	2760	2891	2760
q4	2033	1799	1741	1741
q5	5743	5750	5734	5734
q6	209	130	129	129
q7	2207	1786	1795	1786
q8	3409	3590	3527	3527
q9	8955	8783	8909	8783
q10	3577	3552	3533	3533
q11	606	483	491	483
q12	801	616	609	609
q13	9261	3140	3230	3140
q14	310	262	257	257
q15	505	462	461	461
q16	493	456	462	456
q17	1834	1623	1596	1596
q18	8114	7991	7773	7773
q19	1692	1794	1507	1507
q20	2042	1824	1838	1824
q21	5266	5137	5079	5079
q22	1122	1055	1071	1055
Total cold run time: 68041 ms
Total hot run time: 59009 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195522 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 04076b6d01df23bc9f5fd0c7cd9fb80fadcda302, data reload: false

query1	1271	889	910	889
query2	6376	1840	1852	1840
query3	10912	4465	4410	4410
query4	62446	29434	23453	23453
query5	5199	467	457	457
query6	419	177	175	175
query7	5457	310	307	307
query8	313	225	223	223
query9	8530	2547	2560	2547
query10	426	264	253	253
query11	17523	15236	15790	15236
query12	157	105	106	105
query13	1401	443	436	436
query14	10259	6671	6583	6583
query15	201	181	177	177
query16	7133	501	518	501
query17	1178	619	583	583
query18	1892	316	307	307
query19	211	161	158	158
query20	114	111	106	106
query21	209	102	109	102
query22	4695	4484	4783	4484
query23	34163	33992	33977	33977
query24	6245	2851	2904	2851
query25	498	411	402	402
query26	662	163	161	161
query27	2156	352	347	347
query28	3798	2137	2114	2114
query29	691	464	419	419
query30	253	161	162	161
query31	991	821	818	818
query32	64	60	64	60
query33	420	302	308	302
query34	939	499	527	499
query35	877	720	708	708
query36	1074	947	965	947
query37	110	65	67	65
query38	4044	3968	3889	3889
query39	1525	1459	1439	1439
query40	192	99	100	99
query41	52	49	47	47
query42	121	100	99	99
query43	543	468	476	468
query44	1152	799	809	799
query45	185	167	170	167
query46	1137	746	708	708
query47	2001	1935	1939	1935
query48	489	375	385	375
query49	724	399	389	389
query50	839	412	417	412
query51	7316	7316	7195	7195
query52	102	98	88	88
query53	259	183	185	183
query54	560	462	457	457
query55	79	75	76	75
query56	271	259	236	236
query57	1300	1213	1210	1210
query58	225	207	210	207
query59	3134	2925	2854	2854
query60	276	249	250	249
query61	119	106	112	106
query62	780	684	669	669
query63	219	191	189	189
query64	1351	657	637	637
query65	3268	3177	3168	3168
query66	727	292	293	292
query67	15823	15703	15550	15550
query68	4160	587	569	569
query69	425	259	277	259
query70	1143	1135	1089	1089
query71	353	255	254	254
query72	6347	4028	3959	3959
query73	757	346	346	346
query74	10209	8893	8998	8893
query75	3396	2670	2641	2641
query76	1931	1007	992	992
query77	478	273	266	266
query78	10531	9537	9544	9537
query79	1288	578	592	578
query80	818	434	418	418
query81	495	220	219	219
query82	987	88	87	87
query83	166	147	147	147
query84	278	79	79	79
query85	837	354	353	353
query86	325	287	301	287
query87	4374	4209	4189	4189
query88	3739	2406	2391	2391
query89	426	295	289	289
query90	2053	185	182	182
query91	194	165	158	158
query92	63	52	54	52
query93	1511	543	557	543
query94	741	296	301	296
query95	390	249	254	249
query96	619	280	278	278
query97	3320	3155	3102	3102
query98	213	205	190	190
query99	1592	1276	1306	1276
Total cold run time: 312235 ms
Total hot run time: 195522 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.77 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 04076b6d01df23bc9f5fd0c7cd9fb80fadcda302, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.06	0.06
query4	1.61	0.10	0.10
query5	0.52	0.51	0.49
query6	1.15	0.73	0.72
query7	0.02	0.03	0.01
query8	0.04	0.03	0.02
query9	0.56	0.52	0.49
query10	0.54	0.55	0.57
query11	0.14	0.10	0.10
query12	0.14	0.12	0.11
query13	0.60	0.59	0.59
query14	0.78	0.78	0.81
query15	0.85	0.82	0.82
query16	0.41	0.39	0.39
query17	1.05	0.99	1.07
query18	0.23	0.21	0.21
query19	1.91	1.82	1.83
query20	0.01	0.01	0.00
query21	15.39	0.56	0.56
query22	2.60	1.82	1.59
query23	16.88	1.19	0.80
query24	3.09	0.90	1.61
query25	0.24	0.12	0.06
query26	0.40	0.13	0.13
query27	0.04	0.04	0.04
query28	10.14	0.51	0.49
query29	12.60	3.26	3.22
query30	0.25	0.06	0.07
query31	2.87	0.39	0.39
query32	3.22	0.47	0.45
query33	2.93	3.07	3.01
query34	17.18	4.54	4.46
query35	4.55	4.56	4.52
query36	0.66	0.47	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.02	0.02
query40	0.17	0.12	0.12
query41	0.07	0.02	0.02
query42	0.03	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 104.42 s
Total hot run time: 29.77 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 87.50% (7/8) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.15% (10899/26489)
Line Coverage 31.96% (93283/291829)
Region Coverage 31.03% (48085/154986)
Branch Coverage 27.50% (24634/89584)

@morrySnow morrySnow merged commit dffb4bb into apache:branch-3.1 Jun 20, 2025
20 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants