Skip to content

Conversation

@wenzhenghu
Copy link
Contributor

@wenzhenghu wenzhenghu commented Jun 23, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

when enable file cache, the scan_bytes_from_local_storage and scan_bytes_from_remote_storage shoud not be zero, and scan_bytes should be scan_bytes_from_local_storage + scan_bytes_from_remote_storage

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…tes_from_remote_storage shoud not be zero, and scan_bytes should be scan_bytes_from_local_storage + scan_bytes_from_remote_storage

apache#51872
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@freemandealer
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33730 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e01c62029bd3a2fdd9509ca4b1faf22a98c3c6b9, data reload: false

------ Round 1 ----------------------------------
q1	17588	5247	5056	5056
q2	1964	296	199	199
q3	10267	1266	700	700
q4	10217	1018	522	522
q5	7536	2369	2322	2322
q6	190	163	135	135
q7	903	756	602	602
q8	9329	1263	1135	1135
q9	6748	5070	5022	5022
q10	6944	2389	1946	1946
q11	488	301	272	272
q12	340	358	214	214
q13	17769	3720	3055	3055
q14	240	225	223	223
q15	577	492	478	478
q16	423	435	375	375
q17	597	877	372	372
q18	7578	7210	6943	6943
q19	2611	1143	562	562
q20	324	329	224	224
q21	3641	3216	2382	2382
q22	1050	1005	991	991
Total cold run time: 107324 ms
Total hot run time: 33730 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5307	5108	5104	5104
q2	242	316	228	228
q3	2165	2649	2293	2293
q4	1415	1779	1329	1329
q5	4201	4127	4342	4127
q6	209	175	130	130
q7	2030	1862	1765	1765
q8	2576	2543	2491	2491
q9	7095	7010	7040	7010
q10	3055	3240	2860	2860
q11	565	504	486	486
q12	655	776	627	627
q13	3524	3939	3269	3269
q14	277	306	277	277
q15	513	477	474	474
q16	442	485	456	456
q17	1161	1548	1396	1396
q18	7471	7097	6901	6901
q19	779	755	834	755
q20	1948	1954	1806	1806
q21	4694	4407	4150	4150
q22	1099	1029	996	996
Total cold run time: 51423 ms
Total hot run time: 48930 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185819 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e01c62029bd3a2fdd9509ca4b1faf22a98c3c6b9, data reload: false

query1	1005	398	406	398
query2	6581	1800	1809	1800
query3	6751	224	230	224
query4	26744	23714	23112	23112
query5	4358	636	488	488
query6	324	220	209	209
query7	4637	498	287	287
query8	270	226	215	215
query9	8652	2645	2675	2645
query10	491	353	278	278
query11	15536	15043	14862	14862
query12	174	110	109	109
query13	1668	548	407	407
query14	9772	6010	6137	6010
query15	210	192	182	182
query16	7417	607	492	492
query17	1206	734	586	586
query18	2095	410	310	310
query19	202	204	162	162
query20	120	114	115	114
query21	215	127	115	115
query22	3951	4126	4108	4108
query23	33875	32980	33135	32980
query24	8430	2354	2385	2354
query25	512	493	387	387
query26	854	269	150	150
query27	2705	501	337	337
query28	4284	2109	2083	2083
query29	687	542	452	452
query30	287	236	195	195
query31	941	843	774	774
query32	70	66	62	62
query33	574	370	320	320
query34	786	866	518	518
query35	783	820	728	728
query36	928	981	876	876
query37	113	102	81	81
query38	4133	4132	4007	4007
query39	1460	1420	1420	1420
query40	217	117	110	110
query41	63	59	57	57
query42	131	113	112	112
query43	491	485	461	461
query44	1287	826	829	826
query45	178	172	173	172
query46	847	1100	634	634
query47	1782	1772	1710	1710
query48	384	429	314	314
query49	712	476	393	393
query50	635	678	399	399
query51	4125	4088	4125	4088
query52	121	114	102	102
query53	225	269	185	185
query54	567	572	513	513
query55	91	87	87	87
query56	303	286	290	286
query57	1189	1188	1139	1139
query58	273	273	260	260
query59	2704	2624	2552	2552
query60	359	328	313	313
query61	145	126	125	125
query62	790	718	661	661
query63	218	187	188	187
query64	3450	1039	675	675
query65	4228	4193	4224	4193
query66	953	422	359	359
query67	15664	15611	15360	15360
query68	9067	894	533	533
query69	479	298	262	262
query70	1139	1141	1101	1101
query71	468	324	309	309
query72	5313	4769	4966	4769
query73	747	671	357	357
query74	8907	9148	8964	8964
query75	4272	3202	2704	2704
query76	3603	1188	748	748
query77	803	413	291	291
query78	9997	10178	9388	9388
query79	1440	830	586	586
query80	607	561	450	450
query81	489	264	222	222
query82	476	129	100	100
query83	253	245	243	243
query84	253	99	90	90
query85	807	354	309	309
query86	337	314	286	286
query87	4402	4466	4419	4419
query88	2912	2295	2273	2273
query89	387	328	287	287
query90	1934	222	212	212
query91	142	153	113	113
query92	77	67	62	62
query93	1087	955	599	599
query94	682	409	289	289
query95	382	301	296	296
query96	496	575	284	284
query97	2759	2753	2668	2668
query98	248	209	211	209
query99	1443	1380	1286	1286
Total cold run time: 272341 ms
Total hot run time: 185819 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.73 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e01c62029bd3a2fdd9509ca4b1faf22a98c3c6b9, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.04
query3	0.24	0.07	0.08
query4	1.60	0.11	0.10
query5	0.42	0.44	0.40
query6	1.16	0.67	0.66
query7	0.03	0.01	0.02
query8	0.04	0.04	0.03
query9	0.58	0.52	0.51
query10	0.57	0.57	0.58
query11	0.15	0.11	0.11
query12	0.15	0.11	0.12
query13	0.64	0.61	0.61
query14	0.80	0.81	0.81
query15	0.89	0.85	0.87
query16	0.40	0.39	0.40
query17	1.06	1.12	1.06
query18	0.23	0.21	0.21
query19	2.06	1.87	1.86
query20	0.01	0.01	0.01
query21	15.42	0.91	0.57
query22	0.77	1.16	0.60
query23	14.99	1.43	0.62
query24	7.37	1.78	0.96
query25	0.49	0.20	0.19
query26	0.67	0.17	0.14
query27	0.07	0.05	0.06
query28	9.76	0.83	0.44
query29	12.59	4.03	3.35
query30	0.25	0.10	0.06
query31	2.84	0.60	0.40
query32	3.25	0.55	0.47
query33	3.05	3.08	3.08
query34	16.12	5.40	4.75
query35	4.83	4.80	4.78
query36	0.69	0.50	0.49
query37	0.09	0.07	0.07
query38	0.04	0.04	0.04
query39	0.03	0.03	0.03
query40	0.17	0.14	0.14
query41	0.08	0.02	0.03
query42	0.03	0.02	0.03
query43	0.03	0.03	0.03
Total cold run time: 104.77 s
Total hot run time: 29.73 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/27) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 56.58% (15109/26702)
Line Coverage 45.37% (135396/298438)
Region Coverage 44.46% (68047/153047)
Branch Coverage 39.03% (34937/89508)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 62.96% (17/27) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 61.98% (16281/26269)
Line Coverage 51.53% (153670/298237)
Region Coverage 48.86% (87959/180021)
Branch Coverage 42.28% (43247/102276)

@freemandealer
Copy link
Contributor

run cloud_p0

@wenzhenghu wenzhenghu closed this Jul 11, 2025
@wenzhenghu
Copy link
Contributor Author

#52232 this pr is better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants