[Feature](function) support like with escape clause #52146

BiteTheDDDDt · 2025-06-23T10:36:17Z

What problem does this PR solve?

support like with escape clause

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes. update like with escape clause doc doris-website#2552

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2025-06-23T10:36:22Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

BiteTheDDDDt · 2025-06-23T10:36:32Z

run buildall

regression-test/suites/query_p0/sql_functions/string_functions/test_like_escape.groovy

fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Like.java

hello-stephen · 2025-06-23T14:07:29Z

BE UT Coverage Report

Increment line coverage 17.31% (9/52) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	56.58% (15110/26705)
Line Coverage	45.38% (135458/298473)
Region Coverage	44.53% (68173/153081)
Branch Coverage	39.09% (35001/89532)

yiguolei · 2025-06-24T01:10:13Z

be/src/vec/functions/like.cpp

+std::string replace_pattern_by_escape(const StringRef& pattern, char escape_char) {
+    std::string result;
+    result.reserve(pattern.size);
+    for (size_t i = 0; i < pattern.size; ++i) {


这个代码得加单测

fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Like.java

BiteTheDDDDt · 2025-06-24T02:30:13Z

run buildall

hello-stephen · 2025-06-24T03:41:58Z

FE UT Coverage Report

Increment line coverage 31.03% (9/29) 🎉
Increment coverage report
Complete coverage report

hello-stephen · 2025-06-24T04:35:33Z

BE UT Coverage Report

Increment line coverage 17.31% (9/52) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	56.62% (15126/26714)
Line Coverage	45.41% (135618/298621)
Region Coverage	44.57% (68249/153117)
Branch Coverage	39.16% (35079/89578)

hello-stephen · 2025-06-24T05:23:20Z

BE Regression && UT Coverage Report

Increment line coverage 17.31% (9/52) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	61.92% (16274/26282)
Line Coverage	51.41% (153431/298439)
Region Coverage	48.81% (87905/180099)
Branch Coverage	42.28% (43274/102354)

BiteTheDDDDt · 2025-06-24T06:22:54Z

run buildall

hello-stephen · 2025-06-24T08:32:49Z

BE UT Coverage Report

Increment line coverage 55.77% (29/52) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	56.63% (15130/26717)
Line Coverage	45.45% (135714/298628)
Region Coverage	44.65% (68368/153106)
Branch Coverage	39.25% (35158/89576)

hello-stephen · 2025-06-24T08:42:19Z

BE Regression && UT Coverage Report

Increment line coverage 55.77% (29/52) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	61.98% (16291/26285)
Line Coverage	51.55% (153848/298446)
Region Coverage	48.99% (88227/180084)
Branch Coverage	42.49% (43485/102350)

yiguolei · 2025-06-25T10:57:22Z

be/src/vec/functions/like.h

+inline std::string replace_pattern_by_escape(const StringRef& pattern, char escape_char) {
+    std::string result;
+    result.reserve(pattern.size);
+    for (size_t i = 0; i < pattern.size; ++i) {


like "\n" --> like "\n"
like "\a"

like "\n" escape 'b'

\a

...e-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/LikeToEqualRewrite.java

fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Like.java

BiteTheDDDDt · 2025-06-26T06:20:26Z

run buildall

hello-stephen · 2025-06-26T08:20:31Z

BE UT Coverage Report

Increment line coverage 55.77% (29/52) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	57.05% (15366/26934)
Line Coverage	46.15% (139457/302211)
Region Coverage	45.48% (70676/155405)
Branch Coverage	40.23% (37334/92790)

BiteTheDDDDt · 2025-06-27T03:35:52Z

run buildall

github-actions · 2025-06-30T09:11:14Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-06-30T09:11:17Z

PR approved by anyone and no changes requested.

support like with escape clause

#52549) Cherry-picked from #52146

support like with escape clause

pick from #52146

…#52146 (apache#52549) Cherry-picked from apache#52146

yiguolei added dev/3.0.x dev/3.1.x labels Jun 23, 2025

yiguolei reviewed Jun 23, 2025

View reviewed changes

regression-test/suites/query_p0/sql_functions/string_functions/test_like_escape.groovy Show resolved Hide resolved

yiguolei reviewed Jun 23, 2025

View reviewed changes

regression-test/suites/query_p0/sql_functions/string_functions/test_like_escape.groovy Show resolved Hide resolved

morrySnow reviewed Jun 23, 2025

View reviewed changes

fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Like.java Outdated Show resolved Hide resolved

yiguolei reviewed Jun 24, 2025

View reviewed changes

fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Like.java Show resolved Hide resolved

yiguolei reviewed Jun 25, 2025

View reviewed changes

BiteTheDDDDt added 4 commits June 25, 2025 21:30

support like with escape clause

304e943

update fe

3a5436b

update

5b96582

update

d29f22f

morrySnow reviewed Jun 25, 2025

View reviewed changes

update

686f487

BiteTheDDDDt force-pushed the dev_0623 branch from 8eb3b97 to 686f487 Compare June 26, 2025 06:20

yiguolei approved these changes Jun 30, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 30, 2025

github-actions bot added the reviewed label Jun 30, 2025

morrySnow approved these changes Jun 30, 2025

View reviewed changes

BiteTheDDDDt merged commit 1bfad89 into apache:master Jun 30, 2025
25 of 28 checks passed

github-actions bot added dev/3.0.x-conflict dev/3.1.x-conflict labels Jun 30, 2025

BiteTheDDDDt added a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Jun 30, 2025

[Feature](function) support like with escape clause (apache#52146)

5d7fe51

support like with escape clause

BiteTheDDDDt mentioned this pull request Jun 30, 2025

[Feature](function) support like with escape clause (#52146) #52540

Merged

BiteTheDDDDt added a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Jun 30, 2025

[Feature](function) support like with escape clause (apache#52146)

eca2a04

support like with escape clause

BiteTheDDDDt mentioned this pull request Jun 30, 2025

branch-3.1: [Feature](function) support like with escape clause #52146 #52549

Merged

morrySnow pushed a commit that referenced this pull request Jul 2, 2025

branch-3.1: [Feature](function) support like with escape clause #52146 (

e4a5270

#52549) Cherry-picked from #52146

morrySnow added dev/3.1.0-merged and removed dev/3.1.x dev/3.1.x-conflict labels Jul 2, 2025

koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025

[Feature](function) support like with escape clause (apache#52146)

062c4e7

support like with escape clause

koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025

[Feature](function) support like with escape clause (apache#52146)

a69775d

support like with escape clause

koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025

[Feature](function) support like with escape clause (apache#52146)

7a90f74

support like with escape clause

dataroaring pushed a commit that referenced this pull request Jul 7, 2025

[Feature](function) support like with escape clause (#52146) (#52540)

4edfac5

pick from #52146

dataroaring added dev/3.0.7-merged usercase Important user case type label and removed dev/3.0.x dev/3.0.x-conflict labels Jul 7, 2025

BiteTheDDDDt added a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Sep 1, 2025

ranch-3.1: [Feature](function) support like with escape clause apache…

ba6dee6

…#52146 (apache#52549) Cherry-picked from apache#52146

[Feature](function) support like with escape clause #52146

[Feature](function) support like with escape clause #52146

Uh oh!

Conversation

BiteTheDDDDt commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Jun 23, 2025

Uh oh!

BiteTheDDDDt commented Jun 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hello-stephen commented Jun 23, 2025

BE UT Coverage Report

Uh oh!

yiguolei Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BiteTheDDDDt commented Jun 24, 2025

Uh oh!

hello-stephen commented Jun 24, 2025

FE UT Coverage Report

Uh oh!

hello-stephen commented Jun 24, 2025

BE UT Coverage Report

Uh oh!

hello-stephen commented Jun 24, 2025

BE Regression && UT Coverage Report

Uh oh!

BiteTheDDDDt commented Jun 24, 2025

Uh oh!

hello-stephen commented Jun 24, 2025

BE UT Coverage Report

Uh oh!

hello-stephen commented Jun 24, 2025

BE Regression && UT Coverage Report

Uh oh!

yiguolei Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BiteTheDDDDt commented Jun 26, 2025

Uh oh!

hello-stephen commented Jun 26, 2025

BE UT Coverage Report

Uh oh!

BiteTheDDDDt commented Jun 27, 2025

Uh oh!

github-actions bot commented Jun 30, 2025

Uh oh!

github-actions bot commented Jun 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

BiteTheDDDDt commented Jun 23, 2025 •

edited

Loading