Skip to content

branch-3.1: [fix](be) Fix be aws-sdk-cpp memory leak #52185 #52213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Jun 24, 2025
Merged

branch-3.1: [fix](be) Fix be aws-sdk-cpp memory leak #52185 #52213

morrySnow merged 1 commit into from
Jun 24, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jun 24, 2025

Cherry-picked from #52185

@swjtu-zhanglei
[fix](be) Fix be aws-sdk-cpp memory leak (#52185)
7966571 
* aws/aws-sdk-cpp#2314
* In the aws-sdk-cpp code, there is a suggestion: "Please call
ShutdownAPI from the same thread from which InitAPI() has been called"
otherwise it will cause memory leak.

```
=================================================================
==3271527==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 216 byte(s) in 1 object(s) allocated from:
    #0 0x555f9ecf55ee in malloc (/mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster0/be/lib/doris_be+0x370815ee) (BuildId: 22b637395dd039b0)
    #1 0x555fd8e19bd7 in CRYPTO_zalloc (/mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster0/be/lib/doris_be+0x711a5bd7) (BuildId: 22b637395dd039b0)
    #2 0x555fda7c9d14 in aws_mqtt_library_init (/mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster0/be/lib/doris_be+0x72b55d14) (BuildId: 22b637395dd039b0)
    #3 0x555fda74ed1f in Aws::Crt::ApiHandle::ApiHandle(aws_allocator*) (/mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster0/be/lib/doris_be+0x72adad1f) (BuildId: 22b637395dd039b0)
    #4 0x555fa365f0c9 in doris::S3ClientFactory::instance() /root/doris/be/src/util/s3_util.cpp:188:28
    #5 0x555f9f13b87b in doris::io::ObjClientHolder::init() /root/doris/be/src/io/fs/s3_file_system.cpp:78:15
    #6 0x555f9f140eee in doris::io::S3FileSystem::init() /root/doris/be/src/io/fs/s3_file_system.cpp:182:21
    ......
```
@github-actions github-actions bot requested a review from morrySnow as a code owner June 24, 2025 08:46
@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 24, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jun 24, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 24, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jun 24, 2025

TPC-H: Total hot run time: 39689 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 79665717530d2fdc8cadf537969bfbdfad99ad3e, data reload: false

------ Round 1 ----------------------------------
q1	18245	7059	6639	6639
q2	3060	187	162	162
q3	12148	1150	1188	1150
q4	10690	731	738	731
q5	7963	2936	2857	2857
q6	211	138	133	133
q7	994	620	620	620
q8	9367	1942	1960	1942
q9	6674	6401	6401	6401
q10	7040	2254	2327	2254
q11	479	259	262	259
q12	399	210	206	206
q13	17795	2992	2988	2988
q14	228	214	210	210
q15	515	459	454	454
q16	473	379	379	379
q17	980	555	558	555
q18	7192	6705	6707	6705
q19	1328	1035	996	996
q20	464	199	197	197
q21	3906	2885	3073	2885
q22	1110	988	966	966
Total cold run time: 111261 ms
Total hot run time: 39689 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6581	6552	6540	6540
q2	324	231	235	231
q3	2876	2880	2897	2880
q4	2051	1878	1805	1805
q5	5683	5669	5674	5669
q6	200	122	122	122
q7	2174	1759	1797	1759
q8	3295	3444	3500	3444
q9	8847	8823	8808	8808
q10	3549	3541	3496	3496
q11	585	488	484	484
q12	834	596	629	596
q13	8297	3179	3203	3179
q14	308	271	273	271
q15	514	458	470	458
q16	477	431	438	431
q17	1802	1592	1550	1550
q18	8238	7803	7784	7784
q19	1680	1468	1535	1468
q20	2112	1878	1854	1854
q21	5177	4996	4772	4772
q22	1085	1009	1001	1001
Total cold run time: 66689 ms
Total hot run time: 58602 ms

@doris-robot
Copy link

doris-robot commented Jun 24, 2025

TPC-DS: Total hot run time: 189461 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 79665717530d2fdc8cadf537969bfbdfad99ad3e, data reload: false

query1	966	363	370	363
query2	6535	1921	1921	1921
query3	6704	209	222	209
query4	33735	23542	23472	23472
query5	4392	448	429	429
query6	266	167	172	167
query7	4614	304	322	304
query8	276	232	225	225
query9	9571	2579	2579	2579
query10	470	255	249	249
query11	18694	15075	15163	15075
query12	162	107	102	102
query13	1648	426	420	420
query14	9218	6807	6895	6807
query15	228	166	173	166
query16	7998	468	478	468
query17	1627	581	561	561
query18	2086	311	312	311
query19	238	160	154	154
query20	114	110	108	108
query21	208	107	106	106
query22	4245	4211	4002	4002
query23	34192	33489	33610	33489
query24	11242	2799	2912	2799
query25	703	414	405	405
query26	1507	169	167	167
query27	2967	357	341	341
query28	7556	2121	2129	2121
query29	967	437	433	433
query30	332	156	167	156
query31	1057	767	792	767
query32	103	58	58	58
query33	799	312	303	303
query34	907	495	509	495
query35	865	725	713	713
query36	1100	933	920	920
query37	142	79	68	68
query38	3848	3803	3791	3791
query39	1480	1433	1431	1431
query40	290	104	104	104
query41	54	52	52	52
query42	116	102	100	100
query43	522	476	487	476
query44	1212	805	791	791
query45	185	170	171	170
query46	1141	707	717	707
query47	1948	1858	1834	1834
query48	420	345	346	345
query49	1225	410	408	408
query50	819	402	403	402
query51	7373	7080	7051	7051
query52	106	90	92	90
query53	253	181	182	181
query54	1172	461	468	461
query55	81	78	78	78
query56	278	258	255	255
query57	1283	1168	1166	1166
query58	250	220	212	212
query59	3094	2988	2922	2922
query60	280	245	251	245
query61	121	111	107	107
query62	853	684	680	680
query63	211	192	196	192
query64	5316	660	627	627
query65	3284	3223	3177	3177
query66	1448	306	307	306
query67	15980	15784	15532	15532
query68	4668	579	574	574
query69	454	266	296	266
query70	1126	1057	1068	1057
query71	420	262	256	256
query72	6430	3830	3986	3830
query73	743	341	353	341
query74	10466	9165	9055	9055
query75	3403	2677	2636	2636
query76	2980	1088	1109	1088
query77	416	270	278	270
query78	10444	9552	9540	9540
query79	1600	584	598	584
query80	1080	433	416	416
query81	528	220	218	218
query82	958	90	90	90
query83	218	149	147	147
query84	240	73	78	73
query85	1304	301	301	301
query86	360	294	285	285
query87	4433	4209	4213	4209
query88	3607	2371	2327	2327
query89	406	295	291	291
query90	1977	178	176	176
query91	146	109	123	109
query92	58	51	58	51
query93	1216	563	547	547
query94	928	298	288	288
query95	344	247	258	247
query96	600	272	285	272
query97	3344	3156	3116	3116
query98	209	199	196	196
query99	1476	1326	1279	1279
Total cold run time: 299659 ms
Total hot run time: 189461 ms

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 24, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.33% (10963/26524)
Line Coverage 32.19% (94224/292694)
Region Coverage 31.27% (48584/155391)
Branch Coverage 27.94% (25079/89760)

@doris-robot
Copy link

doris-robot commented Jun 24, 2025

ClickBench: Total hot run time: 29.73 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 79665717530d2fdc8cadf537969bfbdfad99ad3e, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.03	0.03
query3	0.23	0.06	0.07
query4	1.62	0.10	0.10
query5	0.54	0.52	0.50
query6	1.13	0.72	0.73
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.56	0.50	0.51
query10	0.56	0.55	0.54
query11	0.14	0.10	0.10
query12	0.15	0.12	0.11
query13	0.60	0.60	0.60
query14	0.77	0.77	0.80
query15	0.84	0.82	0.83
query16	0.38	0.40	0.40
query17	1.04	1.02	1.08
query18	0.23	0.21	0.21
query19	1.86	1.73	1.83
query20	0.01	0.01	0.01
query21	15.40	0.62	0.57
query22	2.25	2.18	1.72
query23	17.09	0.85	0.86
query24	3.62	1.49	0.83
query25	0.13	0.24	0.06
query26	0.63	0.13	0.13
query27	0.05	0.04	0.04
query28	9.69	0.51	0.46
query29	12.60	3.17	3.18
query30	0.25	0.06	0.06
query31	2.87	0.38	0.38
query32	3.28	0.46	0.45
query33	2.96	2.99	3.01
query34	17.06	4.50	4.47
query35	4.60	4.59	4.49
query36	0.64	0.46	0.48
query37	0.08	0.05	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 104.4 s
Total hot run time: 29.73 s

@swjtu-zhanglei
Copy link
Contributor

swjtu-zhanglei commented Jun 24, 2025

run cloud_p0

@morrySnow morrySnow merged commit 48149e4 into branch-3.1 Jun 24, 2025
21 of 22 checks passed
@github-actions github-actions bot deleted the auto-pick-52185-branch-3.1 branch June 24, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hello-stephen @doris-robot @swjtu-zhanglei @morrySnow @dataroaring