Skip to content

[enhance](meta-service)collect fdb kv meta range info as metrics #52430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gavinchou merged 12 commits into from
Jul 11, 2025
Merged

[enhance](meta-service)collect fdb kv meta range info as metrics #52430

gavinchou merged 12 commits into from
Jul 11, 2025

Conversation

@koarz
Copy link
Contributor

@koarz koarz commented Jun 27, 2025 •
edited by gavinchou
Loading

such as these key:

recycle|default_instance_id|txn: 1
meta|default_instance_id|tablet_index: 1
meta|default_instance_id|rowset_tmp: 1

collect to result:

fdb_kv_ranges_count{category="recycle",instance_id="default_instance_id",sub_category="txn"} 1
fdb_kv_ranges_count{category="meta",instance_id="default_instance_id",sub_category="tablet_index"} 1
fdb_kv_ranges_count{category="meta",instance_id="default_instance_id",sub_category="rowset_tmp"} 1

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 27, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@koarz
Copy link
Contributor Author

koarz commented Jun 27, 2025

run buildall

3 similar comments
@koarz
Copy link
Contributor Author

koarz commented Jun 27, 2025

run buildall

@koarz
Copy link
Contributor Author

koarz commented Jun 27, 2025

run buildall

@koarz
Copy link
Contributor Author

koarz commented Jun 28, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jun 28, 2025

Cloud UT Coverage Report

Increment line coverage 11.59% (8/69) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.48% (1172/1404)
Line Coverage 67.37% (20665/30676)
Region Coverage 67.00% (10271/15329)
Branch Coverage 56.25% (5374/9554)

@koarz
Copy link
Contributor Author

koarz commented Jun 29, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 29, 2025

Cloud UT Coverage Report

Increment line coverage 10.67% (8/75) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.48% (1172/1404)
Line Coverage 67.41% (20659/30646)
Region Coverage 67.01% (10261/15313)
Branch Coverage 56.31% (5373/9542)

@koarz
Copy link
Contributor Author

koarz commented Jun 29, 2025

run cloud_p0

@koarz
Copy link
Contributor Author

koarz commented Jun 30, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 30, 2025

Cloud UT Coverage Report

Increment line coverage 10.81% (8/74) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.48% (1172/1404)
Line Coverage 67.36% (20644/30645)
Region Coverage 67.01% (10261/15313)
Branch Coverage 56.28% (5370/9542)

gavinchou
gavinchou requested changes Jul 1, 2025
View reviewed changes
@koarz
Copy link
Contributor Author

koarz commented Jul 3, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 3, 2025

Cloud UT Coverage Report

Increment line coverage 8.16% (8/98) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 82.51% (1189/1441)
Line Coverage 67.26% (20747/30847)
Region Coverage 66.87% (10317/15429)
Branch Coverage 56.19% (5392/9596)

gavinchou
gavinchou reviewed Jul 3, 2025
View reviewed changes
gavinchou
gavinchou reviewed Jul 3, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 11, 2025

Cloud UT Coverage Report

Increment line coverage 10.13% (8/79) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.98% (1269/1548)
Line Coverage 67.69% (21616/31936)
Region Coverage 67.36% (10732/15932)
Branch Coverage 56.87% (5652/9938)

dataroaring
dataroaring previously approved these changes Jul 11, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koarz koarz dismissed stale reviews from dataroaring and gavinchou via f6637fe July 11, 2025 06:18
@koarz
Copy link
Contributor Author

koarz commented Jul 11, 2025

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 11, 2025
@doris-robot
Copy link

doris-robot commented Jul 11, 2025

Cloud UT Coverage Report

Increment line coverage 10.13% (8/79) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 82.02% (1273/1552)
Line Coverage 67.83% (21749/32062)
Region Coverage 67.43% (10762/15960)
Branch Coverage 56.97% (5671/9954)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025

PR approved by at least one committer and no changes requested.

@gavinchou gavinchou changed the title [enhance](meta-service)collect meta range info as metrics [enhance](meta-service)collect fdb kv meta range info as metrics Jul 11, 2025
@gavinchou gavinchou merged commit 5ad2b74 into apache:master Jul 11, 2025
30 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 11, 2025
@koarz
[enhance](meta-service)collect fdb kv meta range info as metrics (#52430
60b3257 
)

API show_meta_ranges http response
```text
recycle|default_instance_id|txn: 1
meta|default_instance_id|tablet_index: 1
meta|default_instance_id|rowset_tmp: 1
```

metrics
```text
fdb_kv_ranges_count{category="recycle",instance_id="default_instance_id",sub_category="txn"} 1
fdb_kv_ranges_count{category="meta",instance_id="default_instance_id",sub_category="tablet_index"} 1
fdb_kv_ranges_count{category="meta",instance_id="default_instance_id",sub_category="rowset_tmp"} 1
```
@github-actions github-actions bot mentioned this pull request Jul 11, 2025
Merged
@koarz koarz deleted the show_meta_ranges branch July 11, 2025 08:59
dataroaring pushed a commit that referenced this pull request Jul 12, 2025
@github-actions @koarz
branch-3.0: [enhance](meta-service)collect fdb kv meta range info as …
358c2aa 
…metrics #52430 (#53116)

Cherry-picked from #52430

Co-authored-by: koarz <lihao@selectdb.com>
koarz added a commit to koarz/doris that referenced this pull request Jul 14, 2025
@koarz
[enhance](meta-service)collect fdb kv meta range info as metrics (apa…
d9290bd 
…che#52430)

API show_meta_ranges http response
```text
recycle|default_instance_id|txn: 1
meta|default_instance_id|tablet_index: 1
meta|default_instance_id|rowset_tmp: 1
```

metrics
```text
fdb_kv_ranges_count{category="recycle",instance_id="default_instance_id",sub_category="txn"} 1
fdb_kv_ranges_count{category="meta",instance_id="default_instance_id",sub_category="tablet_index"} 1
fdb_kv_ranges_count{category="meta",instance_id="default_instance_id",sub_category="rowset_tmp"} 1
```
@koarz koarz mentioned this pull request Jul 14, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jul 14, 2025
@koarz
branch-3.1: [enhance](meta-service)collect fdb kv meta range info as …
a90c803 
…metrics #52430 (#53179)

picked from #52430
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring left review comments

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

@CalvinKirs CalvinKirs Awaiting requested review from CalvinKirs

@yiguolei yiguolei Awaiting requested review from yiguolei

@morningman morningman Awaiting requested review from morningman

+1 more reviewer

@Hastyshell Hastyshell Hastyshell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. cloud dev/3.0.7-merged dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@koarz @hello-stephen @doris-robot @gavinchou @Hastyshell @dataroaring @morrySnow