[Opt](cloud-mow) Do fast retry when commit compaction job for mow tablet #52476

bobhan1 · 2025-06-30T02:39:41Z

What problem does this PR solve?

Before:

After

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-06-30T02:39:46Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

bobhan1 · 2025-06-30T06:56:30Z

run buildall

hello-stephen · 2025-06-30T07:13:09Z

Cloud UT Coverage Report

Increment line coverage 79.03% (49/62) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	83.51% (1170/1401)
Line Coverage	67.40% (20616/30586)
Region Coverage	67.02% (10256/15302)
Branch Coverage	56.23% (5362/9536)

zhannngchen

LGTM

github-actions · 2025-07-01T06:11:02Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-07-01T06:11:04Z

PR approved by anyone and no changes requested.

dataroaring · 2025-07-01T07:00:20Z

cloud/src/meta-service/meta_service_job.cpp

-        return;
-    }
+    for (int retry = 0; retry <= 1; retry++) {
+        response->Clear();


msg should be empty.

mymeiyi · 2025-07-01T08:08:50Z

cloud/src/meta-service/meta_service_job.cpp

                }
            }
+
+            if (retry == 0 && !request->job().compaction().empty() &&


fast retry only when the err is TxnErrorCode::TXN_CONFLICT?

bobhan1 · 2025-07-01T09:00:05Z

run buildall

doris-robot · 2025-07-01T09:16:08Z

Cloud UT Coverage Report

Increment line coverage 75.38% (49/65) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	83.51% (1170/1401)
Line Coverage	67.42% (20622/30589)
Region Coverage	67.02% (10256/15302)
Branch Coverage	56.25% (5364/9536)

zhannngchen

LGTM

github-actions · 2025-07-04T02:32:20Z

PR approved by at least one committer and no changes requested.

dataroaring

LGTM

…let (#52476) ### What problem does this PR solve? #### Before: ![image](https://github.com/user-attachments/assets/7494627e-f13b-4293-8eba-43e08dffd427) #### After ![image](https://github.com/user-attachments/assets/e03de5b7-8ddd-403c-bd1d-79d57fc22d6d)

… for mow tablet #52476 (#52843) Cherry-picked from #52476 Co-authored-by: bobhan1 <baohan@selectdb.com>

… for mow tablet apache#52476 (apache#52843) Cherry-picked from apache#52476 Co-authored-by: bobhan1 <baohan@selectdb.com>

…let (apache#52476) ![image](https://github.com/user-attachments/assets/7494627e-f13b-4293-8eba-43e08dffd427) ![image](https://github.com/user-attachments/assets/e03de5b7-8ddd-403c-bd1d-79d57fc22d6d)

… for mow tablet (#52476) (#52952) pick #52476

… job for mow tablet apache#52476 (apache#4149) pick apache#52476

bobhan1 force-pushed the fast-retry-for-mow-compaction-job-commit branch from 922e0ed to 142bae5 Compare June 30, 2025 02:40

bobhan1 marked this pull request as ready for review June 30, 2025 07:52

bobhan1 requested review from dataroaring, gavinchou and w41ter as code owners June 30, 2025 07:52

dataroaring added dev/3.0.x dev/3.1.x labels Jun 30, 2025

bobhan1 force-pushed the fast-retry-for-mow-compaction-job-commit branch 2 times, most recently from 97ee8a6 to abde7f0 Compare July 1, 2025 02:30

zhannngchen previously approved these changes Jul 1, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 1, 2025

github-actions bot added the reviewed label Jul 1, 2025

dataroaring reviewed Jul 1, 2025

View reviewed changes

mymeiyi reviewed Jul 1, 2025

View reviewed changes

bobhan1 added 3 commits July 1, 2025 16:18

update

81298e3

clear resp beofre retry

aa4860a

only fast retry when TxnErrorCode::TXN_CONFLICT

233e234

bobhan1 dismissed zhannngchen’s stale review via 233e234 July 1, 2025 08:21

bobhan1 force-pushed the fast-retry-for-mow-compaction-job-commit branch from abde7f0 to 233e234 Compare July 1, 2025 08:21

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 1, 2025

reset all state before retry

07b7d67

zhannngchen approved these changes Jul 4, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 4, 2025

mymeiyi approved these changes Jul 7, 2025

View reviewed changes

dataroaring approved these changes Jul 7, 2025

View reviewed changes

dataroaring merged commit 285b1e4 into apache:master Jul 7, 2025
29 checks passed

github-actions bot added the dev/3.0.x-conflict label Jul 7, 2025

github-actions bot mentioned this pull request Jul 7, 2025

branch-3.1: [Opt](cloud-mow) Do fast retry when commit compaction job for mow tablet #52476 #52843

Merged

morrySnow pushed a commit that referenced this pull request Jul 7, 2025

branch-3.1: [Opt](cloud-mow) Do fast retry when commit compaction job…

a236d1f

… for mow tablet #52476 (#52843) Cherry-picked from #52476 Co-authored-by: bobhan1 <baohan@selectdb.com>

morrySnow added dev/3.1.0-merged and removed dev/3.1.x labels Jul 7, 2025

etah000 pushed a commit to etah000/doris that referenced this pull request Jul 7, 2025

branch-3.1: [Opt](cloud-mow) Do fast retry when commit compaction job…

37c8e96

… for mow tablet apache#52476 (apache#52843) Cherry-picked from apache#52476 Co-authored-by: bobhan1 <baohan@selectdb.com>

bobhan1 mentioned this pull request Jul 8, 2025

branch-3.0; [Opt](cloud-mow) Do fast retry when commit compaction job for mow tablet (#52476) #52952

Merged

dataroaring pushed a commit that referenced this pull request Jul 9, 2025

branch-3.0; [Opt](cloud-mow) Do fast retry when commit compaction job…

9c5e721

… for mow tablet (#52476) (#52952) pick #52476

dataroaring added dev/3.0.7-merged and removed dev/3.0.x dev/3.0.x-conflict labels Jul 9, 2025

gavinchou mentioned this pull request Aug 15, 2025

Release Note 3.0.7 #54868

Open

csun5285 pushed a commit to csun5285/doris that referenced this pull request Sep 23, 2025

(hubspot 4.0.5) [Opt](cloud-mow) Do fast retry when commit compaction…

e9fe181

… job for mow tablet apache#52476 (apache#4149) pick apache#52476

[Opt](cloud-mow) Do fast retry when commit compaction job for mow tablet #52476

[Opt](cloud-mow) Do fast retry when commit compaction job for mow tablet #52476

Uh oh!

Conversation

bobhan1 commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Before:

After

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Jun 30, 2025

Uh oh!

bobhan1 commented Jun 30, 2025

Uh oh!

hello-stephen commented Jun 30, 2025

Cloud UT Coverage Report

Uh oh!

zhannngchen left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

dataroaring Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

mymeiyi Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

bobhan1 commented Jul 1, 2025

Uh oh!

doris-robot commented Jul 1, 2025

Cloud UT Coverage Report

Uh oh!

zhannngchen left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 4, 2025

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

bobhan1 commented Jun 30, 2025 •

edited

Loading