[Enhancement](sql-dialect) Support multiple sql-converter service urls #52636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
TPC-H: Total hot run time: 33685 ms |
TPC-DS: Total hot run time: 185849 ms |
ClickBench: Total hot run time: 29.66 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
zy-kkk
force-pushed
the
sql_converter_multi_url
branch
from
239ef24 to
008b2fa
Compare
Member
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
morningman
reviewed
Jul 3, 2025
| private static final ConcurrentHashMap<String, UrlManager> urlManagerCache = new ConcurrentHashMap<>(); | ||
|
|
||
| // Blacklist recovery time (ms): 5 minutes | ||
| private static final long BLACKLIST_RECOVERY_TIME_MS = 5 * 60 * 1000; |
Contributor
There was a problem hiding this comment.
Too long, 1min is enough, because the sql convertor should be restart very soon
|
|
||
| public static String convertSql(String targetURLs, String originStmt, String dialect, | ||
| String[] features, String config) { | ||
| if (targetURLs == null || targetURLs.trim().isEmpty()) { |
Contributor
There was a problem hiding this comment.
This can be done when setting the variable. See checker() in public @interface VarAttr
| BlacklistEntry existingEntry = blacklist.get(url); | ||
| if (existingEntry != null) { | ||
| // If URL is already in blacklist, limit maximum recovery time to avoid infinite extension | ||
| // Maximum recovery time is 2 times the original recovery time |
Contributor
There was a problem hiding this comment.
No need, that is too complicated. I think just return if the url is already in black list.
| } | ||
|
|
||
| // Randomly shuffle the order to avoid always trying from the first URL | ||
| Collections.shuffle(healthy, ThreadLocalRandom.current()); |
Contributor
There was a problem hiding this comment.
Do not shuffle. Because actually we always want to select the local one (with 127.0.0.1).
So the logic should be: Always try to select url with 127.0.0.1. If it is not available, select another one randomly.
| List<String> prioritizedUrls = Lists.newArrayList(); | ||
|
|
||
| // First: Add all healthy URLs | ||
| List<String> healthyUrls = getHealthyUrls(); |
Contributor
There was a problem hiding this comment.
You traverse the parsedUrls twice, both in getHealthyUrls() and in getBlacklistedUrls(), which is low efficiency. I think we can only traverse the list once.
- first, add
127.0.01if available. - add other available url.
- add url in black list
zy-kkk
force-pushed
the
sql_converter_multi_url
branch
from
008b2fa to
f384cd7
Compare
morningman
reviewed
Jul 7, 2025
| for (String url : allUrls) { | ||
| try { | ||
| String result = doConvertSql(url, requestStr); | ||
| if (result != null && !result.equals(originStmt)) { |
Contributor
There was a problem hiding this comment.
Why need this condition? !result.equals(originStmt)
| } | ||
| } | ||
|
|
||
| LOG.warn("All URLs failed to convert SQL, return original SQL"); |
Contributor
There was a problem hiding this comment.
remove this log, no useful info
|
|
||
| public static String convertSql(String targetURL, String originStmt, String dialect, | ||
| // Cache URL manager instances to avoid duplicate parsing | ||
| private static final ConcurrentHashMap<String, UrlManager> urlManagerCache = new ConcurrentHashMap<>(); |
Contributor
There was a problem hiding this comment.
We need to consider how to remove the unused entries.
So I suggest to use a Caffein Cache, and set a expire time so that it can remote unused entries automatically.
zy-kkk
force-pushed
the
sql_converter_multi_url
branch
from
f384cd7 to
9c86e78
Compare
Member
Author
|
run buildall |
TPC-H: Total hot run time: 33339 ms |
TPC-DS: Total hot run time: 188004 ms |
ClickBench: Total hot run time: 29.77 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
morningman
approved these changes
Jul 9, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
CalvinKirs
approved these changes
Jul 9, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jul 9, 2025
#52636) ### What problem does this PR solve? Problem Summary: **Set up two service addresses** ``` Doris > set global sql_converter_service_url = 'http://127.0.0.1:5001/api/v1/convert,http://127.0.0.1:5002/api/v1/convert'; Query OK, 0 rows affected (0.04 sec) Doris > set sql_dialect = 'clickhouse'; Query OK, 0 rows affected (0.05 sec) Doris > SELECT arrayElement(arr, 2) FROM (SELECT [1, 2, 3] AS arr); +--------------------+ | ELEMENT_AT(arr, 2) | +--------------------+ | 2 | +--------------------+ 1 row in set (0.11 sec) ``` **Stop one of the services** ``` Doris > SELECT arrayElement(arr, 2) FROM (SELECT [1, 2, 3] AS arr); +--------------------+ | ELEMENT_AT(arr, 2) | +--------------------+ | 2 | +--------------------+ 1 row in set (0.14 sec) ``` **Stopping all services resulted in expected errors** ``` Doris > SELECT arrayElement(arr, 2) FROM (SELECT [1, 2, 3] AS arr); ERROR 1105 (HY000): errCode = 2, detailMessage = Every derived table must have its own alias(line 1, pos 33) == SQL == SELECT arrayElement(arr, 2) FROM (SELECT [1, 2, 3] AS arr) ---------------------------------^^^ Doris > SELECT arrayElement(arr, 2) FROM (SELECT [1, 2, 3] AS arr); ERROR 1105 (HY000): errCode = 2, detailMessage = Every derived table must have its own alias(line 1, pos 33) == SQL == SELECT arrayElement(arr, 2) FROM (SELECT [1, 2, 3] AS arr) ---------------------------------^^^ ``` **Restart one of the services** ``` Doris > SELECT arrayElement(arr, 2) FROM (SELECT [1, 2, 3] AS arr); +--------------------+ | ELEMENT_AT(arr, 2) | +--------------------+ | 2 | +--------------------+ 1 row in set (0.16 sec) ```
github-actions bot
pushed a commit
that referenced
this pull request
Jul 9, 2025
#52636) ### What problem does this PR solve? Problem Summary: **Set up two service addresses** ``` Doris > set global sql_converter_service_url = 'http://127.0.0.1:5001/api/v1/convert,http://127.0.0.1:5002/api/v1/convert'; Query OK, 0 rows affected (0.04 sec) Doris > set sql_dialect = 'clickhouse'; Query OK, 0 rows affected (0.05 sec) Doris > SELECT arrayElement(arr, 2) FROM (SELECT [1, 2, 3] AS arr); +--------------------+ | ELEMENT_AT(arr, 2) | +--------------------+ | 2 | +--------------------+ 1 row in set (0.11 sec) ``` **Stop one of the services** ``` Doris > SELECT arrayElement(arr, 2) FROM (SELECT [1, 2, 3] AS arr); +--------------------+ | ELEMENT_AT(arr, 2) | +--------------------+ | 2 | +--------------------+ 1 row in set (0.14 sec) ``` **Stopping all services resulted in expected errors** ``` Doris > SELECT arrayElement(arr, 2) FROM (SELECT [1, 2, 3] AS arr); ERROR 1105 (HY000): errCode = 2, detailMessage = Every derived table must have its own alias(line 1, pos 33) == SQL == SELECT arrayElement(arr, 2) FROM (SELECT [1, 2, 3] AS arr) ---------------------------------^^^ Doris > SELECT arrayElement(arr, 2) FROM (SELECT [1, 2, 3] AS arr); ERROR 1105 (HY000): errCode = 2, detailMessage = Every derived table must have its own alias(line 1, pos 33) == SQL == SELECT arrayElement(arr, 2) FROM (SELECT [1, 2, 3] AS arr) ---------------------------------^^^ ``` **Restart one of the services** ``` Doris > SELECT arrayElement(arr, 2) FROM (SELECT [1, 2, 3] AS arr); +--------------------+ | ELEMENT_AT(arr, 2) | +--------------------+ | 2 | +--------------------+ 1 row in set (0.16 sec) ```
morningman
added a commit
to morningman/doris
that referenced
this pull request
Jan 7, 2026
…vice urls (apache#52636)" This reverts commit 8c3c54e.
morningman
added a commit
to morningman/doris
that referenced
this pull request
Jan 7, 2026
…vice urls (apache#52636)" This reverts commit 8c3c54e.
zzzxl1993
pushed a commit
to zzzxl1993/doris
that referenced
this pull request
Jan 13, 2026
…vice urls (apache#52636)" (apache#59610) This may cause sql convertor read timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Set up two service addresses
Stop one of the services
Stopping all services resulted in expected errors
Restart one of the services
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)