Skip to content

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented Jul 2, 2025

What problem does this PR solve?

/home/zcp/repo_center/doris_master/doris/be/src/vec/data_types/data_type_hll.cpp:105:16: runtime error: null pointer passed as argument 1, which is declared to never be null
/usr/local/ldb-toolchain-v0.24/bin/../usr/include/string.h:43:28: note: nonnull attribute specified here
    #0 0x564a261d7c01 in doris::vectorized::DataTypeHLL::deserialize(char const*, doris::COW<doris::vectorized::IColumn>::mutable_ptr<doris::vectorized::IColumn>*, int) const /home/zcp/repo_center/doris_master/doris/be/src/vec/data_types/data_type_hll.cpp:105:9
    #1 0x564a260e8f66 in doris::vectorized::Block::deserialize(doris::PBlock const&) /home/zcp/repo_center/doris_master/doris/be/src/vec/core/block.cpp:156:9
    #2 0x564a37fe02eb in doris::vectorized::VDataStreamRecvr::SenderQueue::BlockItem::get_block(std::unique_ptr<doris::vectorized::Block, std::default_delete<doris::vectorized::Block>>&) /home/zcp/repo_center/doris_master/doris/be/src/vec/runtime/vdata_stream_recvr.h:272:17
    #3 0x564a37fccdd3 in doris::vectorized::VDataStreamRecvr::SenderQueue::get_batch(doris::vectorized::Block*, bool*) 

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange
Copy link
Contributor Author

Mryange commented Jul 2, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33878 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d315f1de62d174605d34caa0448d474a7a1d749d, data reload: false

------ Round 1 ----------------------------------
q1	17672	5166	5057	5057
q2	1936	277	187	187
q3	10539	1292	754	754
q4	10260	1021	538	538
q5	8012	2352	2387	2352
q6	182	161	126	126
q7	887	751	592	592
q8	9295	1312	1036	1036
q9	6827	5201	5094	5094
q10	6878	2367	1952	1952
q11	470	283	276	276
q12	339	351	217	217
q13	17785	3642	3052	3052
q14	224	235	231	231
q15	528	482	473	473
q16	432	425	377	377
q17	597	871	375	375
q18	7752	7314	7122	7122
q19	1217	955	542	542
q20	331	358	221	221
q21	3993	3158	2359	2359
q22	1029	987	945	945
Total cold run time: 107185 ms
Total hot run time: 33878 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5071	5051	5060	5051
q2	251	328	217	217
q3	2195	2676	2297	2297
q4	1373	1765	1372	1372
q5	4191	4640	4572	4572
q6	211	166	125	125
q7	1998	1961	1787	1787
q8	2690	2602	2573	2573
q9	7415	7369	7461	7369
q10	3174	3318	2852	2852
q11	600	530	493	493
q12	684	767	607	607
q13	3614	3920	3438	3438
q14	289	304	282	282
q15	525	505	491	491
q16	439	483	460	460
q17	1189	1593	1418	1418
q18	8085	7732	7500	7500
q19	822	810	839	810
q20	1998	2264	1900	1900
q21	5094	4627	4583	4583
q22	1115	1070	1024	1024
Total cold run time: 53023 ms
Total hot run time: 51221 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185261 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d315f1de62d174605d34caa0448d474a7a1d749d, data reload: false

query1	1024	383	409	383
query2	6514	1802	1760	1760
query3	6738	211	218	211
query4	26514	23559	22947	22947
query5	4392	591	433	433
query6	309	218	204	204
query7	4627	494	287	287
query8	272	236	211	211
query9	8612	2642	2657	2642
query10	478	347	269	269
query11	15538	15067	14802	14802
query12	160	107	106	106
query13	1650	522	412	412
query14	8425	5660	5707	5660
query15	207	200	178	178
query16	7815	632	459	459
query17	1213	735	592	592
query18	2028	413	324	324
query19	194	195	162	162
query20	124	120	114	114
query21	211	128	110	110
query22	4125	4182	4632	4182
query23	34929	33943	33665	33665
query24	8402	2368	2404	2368
query25	517	454	393	393
query26	1223	265	143	143
query27	2726	500	347	347
query28	4282	2125	2102	2102
query29	702	558	430	430
query30	285	211	180	180
query31	909	822	731	731
query32	72	60	64	60
query33	565	391	298	298
query34	792	842	518	518
query35	772	813	734	734
query36	941	966	868	868
query37	108	96	68	68
query38	4151	4161	4065	4065
query39	1494	1429	1387	1387
query40	208	118	104	104
query41	54	54	50	50
query42	123	110	110	110
query43	515	508	489	489
query44	1330	827	818	818
query45	183	170	171	170
query46	858	998	642	642
query47	1734	1805	1745	1745
query48	378	404	324	324
query49	731	480	388	388
query50	629	688	412	412
query51	4100	4282	4040	4040
query52	109	108	98	98
query53	229	258	183	183
query54	586	574	510	510
query55	84	83	78	78
query56	297	286	302	286
query57	1173	1184	1115	1115
query58	273	258	261	258
query59	2626	2790	2717	2717
query60	335	326	314	314
query61	122	146	118	118
query62	799	726	629	629
query63	231	182	180	180
query64	4253	1022	643	643
query65	4242	4217	4173	4173
query66	1078	400	297	297
query67	15731	15443	15246	15246
query68	8671	907	528	528
query69	471	312	267	267
query70	1240	1112	1070	1070
query71	486	318	307	307
query72	5814	4854	5023	4854
query73	759	742	356	356
query74	9060	9163	8791	8791
query75	3970	3183	2696	2696
query76	3738	1179	733	733
query77	788	383	291	291
query78	10040	10159	9288	9288
query79	2267	835	622	622
query80	611	504	448	448
query81	457	269	225	225
query82	432	122	93	93
query83	278	256	234	234
query84	291	115	81	81
query85	829	340	307	307
query86	328	314	295	295
query87	4355	4401	4295	4295
query88	3386	2286	2265	2265
query89	382	319	289	289
query90	1937	213	212	212
query91	140	139	108	108
query92	75	60	54	54
query93	1219	964	583	583
query94	670	391	304	304
query95	372	293	286	286
query96	500	580	281	281
query97	2686	2756	2701	2701
query98	226	204	205	204
query99	1481	1408	1251	1251
Total cold run time: 275010 ms
Total hot run time: 185261 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.62 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d315f1de62d174605d34caa0448d474a7a1d749d, data reload: false

query1	0.05	0.04	0.04
query2	0.07	0.04	0.04
query3	0.25	0.08	0.07
query4	1.62	0.11	0.11
query5	0.45	0.44	0.42
query6	1.18	0.66	0.65
query7	0.02	0.01	0.02
query8	0.05	0.03	0.04
query9	0.61	0.50	0.52
query10	0.58	0.57	0.58
query11	0.16	0.11	0.12
query12	0.16	0.12	0.11
query13	0.64	0.61	0.61
query14	0.81	0.82	0.83
query15	0.88	0.88	0.88
query16	0.38	0.41	0.39
query17	1.07	1.10	1.08
query18	0.23	0.21	0.22
query19	1.98	1.85	1.89
query20	0.02	0.01	0.01
query21	15.41	0.90	0.56
query22	0.74	1.27	0.66
query23	14.89	1.34	0.61
query24	7.06	0.87	0.94
query25	0.51	0.22	0.08
query26	0.58	0.16	0.14
query27	0.07	0.06	0.06
query28	9.66	0.89	0.45
query29	12.56	3.96	3.31
query30	0.24	0.10	0.06
query31	2.82	0.59	0.38
query32	3.22	0.56	0.49
query33	3.02	3.04	3.10
query34	16.09	5.36	4.77
query35	4.87	4.85	4.82
query36	0.68	0.52	0.49
query37	0.09	0.07	0.07
query38	0.05	0.04	0.03
query39	0.03	0.03	0.02
query40	0.17	0.14	0.13
query41	0.08	0.03	0.03
query42	0.03	0.02	0.03
query43	0.04	0.03	0.02
Total cold run time: 104.12 s
Total hot run time: 29.62 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (4/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.12% (15375/26916)
Line Coverage 46.16% (139506/302250)
Region Coverage 45.46% (70692/155494)
Branch Coverage 40.22% (37318/92784)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 50cdda9 into apache:master Jul 3, 2025
26 of 29 checks passed
koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025
```
/home/zcp/repo_center/doris_master/doris/be/src/vec/data_types/data_type_hll.cpp:105:16: runtime error: null pointer passed as argument 1, which is declared to never be null
/usr/local/ldb-toolchain-v0.24/bin/../usr/include/string.h:43:28: note: nonnull attribute specified here
    #0 0x564a261d7c01 in doris::vectorized::DataTypeHLL::deserialize(char const*, doris::COW<doris::vectorized::IColumn>::mutable_ptr<doris::vectorized::IColumn>*, int) const /home/zcp/repo_center/doris_master/doris/be/src/vec/data_types/data_type_hll.cpp:105:9
    apache#1 0x564a260e8f66 in doris::vectorized::Block::deserialize(doris::PBlock const&) /home/zcp/repo_center/doris_master/doris/be/src/vec/core/block.cpp:156:9
    apache#2 0x564a37fe02eb in doris::vectorized::VDataStreamRecvr::SenderQueue::BlockItem::get_block(std::unique_ptr<doris::vectorized::Block, std::default_delete<doris::vectorized::Block>>&) /home/zcp/repo_center/doris_master/doris/be/src/vec/runtime/vdata_stream_recvr.h:272:17
    apache#3 0x564a37fccdd3 in doris::vectorized::VDataStreamRecvr::SenderQueue::get_batch(doris::vectorized::Block*, bool*) 
```
koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025
```
/home/zcp/repo_center/doris_master/doris/be/src/vec/data_types/data_type_hll.cpp:105:16: runtime error: null pointer passed as argument 1, which is declared to never be null
/usr/local/ldb-toolchain-v0.24/bin/../usr/include/string.h:43:28: note: nonnull attribute specified here
    #0 0x564a261d7c01 in doris::vectorized::DataTypeHLL::deserialize(char const*, doris::COW<doris::vectorized::IColumn>::mutable_ptr<doris::vectorized::IColumn>*, int) const /home/zcp/repo_center/doris_master/doris/be/src/vec/data_types/data_type_hll.cpp:105:9
    apache#1 0x564a260e8f66 in doris::vectorized::Block::deserialize(doris::PBlock const&) /home/zcp/repo_center/doris_master/doris/be/src/vec/core/block.cpp:156:9
    apache#2 0x564a37fe02eb in doris::vectorized::VDataStreamRecvr::SenderQueue::BlockItem::get_block(std::unique_ptr<doris::vectorized::Block, std::default_delete<doris::vectorized::Block>>&) /home/zcp/repo_center/doris_master/doris/be/src/vec/runtime/vdata_stream_recvr.h:272:17
    apache#3 0x564a37fccdd3 in doris::vectorized::VDataStreamRecvr::SenderQueue::get_batch(doris::vectorized::Block*, bool*) 
```
koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025
```
/home/zcp/repo_center/doris_master/doris/be/src/vec/data_types/data_type_hll.cpp:105:16: runtime error: null pointer passed as argument 1, which is declared to never be null
/usr/local/ldb-toolchain-v0.24/bin/../usr/include/string.h:43:28: note: nonnull attribute specified here
    #0 0x564a261d7c01 in doris::vectorized::DataTypeHLL::deserialize(char const*, doris::COW<doris::vectorized::IColumn>::mutable_ptr<doris::vectorized::IColumn>*, int) const /home/zcp/repo_center/doris_master/doris/be/src/vec/data_types/data_type_hll.cpp:105:9
    apache#1 0x564a260e8f66 in doris::vectorized::Block::deserialize(doris::PBlock const&) /home/zcp/repo_center/doris_master/doris/be/src/vec/core/block.cpp:156:9
    apache#2 0x564a37fe02eb in doris::vectorized::VDataStreamRecvr::SenderQueue::BlockItem::get_block(std::unique_ptr<doris::vectorized::Block, std::default_delete<doris::vectorized::Block>>&) /home/zcp/repo_center/doris_master/doris/be/src/vec/runtime/vdata_stream_recvr.h:272:17
    apache#3 0x564a37fccdd3 in doris::vectorized::VDataStreamRecvr::SenderQueue::get_batch(doris::vectorized::Block*, bool*) 
```
seawinde pushed a commit to seawinde/doris that referenced this pull request Jul 4, 2025
```
/home/zcp/repo_center/doris_master/doris/be/src/vec/data_types/data_type_hll.cpp:105:16: runtime error: null pointer passed as argument 1, which is declared to never be null
/usr/local/ldb-toolchain-v0.24/bin/../usr/include/string.h:43:28: note: nonnull attribute specified here
    #0 0x564a261d7c01 in doris::vectorized::DataTypeHLL::deserialize(char const*, doris::COW<doris::vectorized::IColumn>::mutable_ptr<doris::vectorized::IColumn>*, int) const /home/zcp/repo_center/doris_master/doris/be/src/vec/data_types/data_type_hll.cpp:105:9
    #1 0x564a260e8f66 in doris::vectorized::Block::deserialize(doris::PBlock const&) /home/zcp/repo_center/doris_master/doris/be/src/vec/core/block.cpp:156:9
    #2 0x564a37fe02eb in doris::vectorized::VDataStreamRecvr::SenderQueue::BlockItem::get_block(std::unique_ptr<doris::vectorized::Block, std::default_delete<doris::vectorized::Block>>&) /home/zcp/repo_center/doris_master/doris/be/src/vec/runtime/vdata_stream_recvr.h:272:17
    apache#3 0x564a37fccdd3 in doris::vectorized::VDataStreamRecvr::SenderQueue::get_batch(doris::vectorized::Block*, bool*) 
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants