Skip to content

[fix](mow) fix potential mem leak for DeleteBitmap::get_agg #52718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhannngchen merged 1 commit into from
Jul 3, 2025
Merged

[fix](mow) fix potential mem leak for DeleteBitmap::get_agg #52718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion be/src/olap/tablet_meta.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1432,13 +1432,13 @@ std::shared_ptr<roaring::Roaring> DeleteBitmap::get_agg(const BitmapKey& bmk) co
val->bitmap |= reinterpret_cast<DeleteBitmapAggCache::Value*>(
DeleteBitmapAggCache::instance()->value(handle2))
->bitmap;
DeleteBitmapAggCache::instance()->release(handle2);
VLOG_DEBUG << "get agg cache version=" << start_version
<< " for tablet=" << _tablet_id
<< ", rowset=" << std::get<0>(bmk).to_string()
<< ", segment=" << std::get<1>(bmk);
start_version += 1;
}
DeleteBitmapAggCache::instance()->release(handle2);
Copy link
Contributor

@mymeiyi mymeiyi Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should check handle2 is not nullptr?

Copy link
Contributor Author

@zhannngchen zhannngchen Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the release function has already handled nullptr.

Copy link
Contributor Author

@zhannngchen zhannngchen Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mymeiyi LRUCache::release handed nullptr, but ShardedLRUCache::release not, 😑

}
{
std::shared_lock l(lock);
Expand Down
Loading