Skip to content

branch-3.0: [Opt](cloud-mow) Retry to commit txn when encounter stale calc delete bitmap response regardless of status code (#52547) #52848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jul 8, 2025
Merged

branch-3.0: [Opt](cloud-mow) Retry to commit txn when encounter stale calc delete bitmap response regardless of status code (#52547) #52848

dataroaring merged 1 commit into from
Jul 8, 2025

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Jul 7, 2025

pick #52547

@bobhan1
[Opt](cloud-mow) Retry to commit txn when encounter stale calc delete…
36cd94b 
… bitmap response regardless of status code (apache#52547)

apache#49710 add a check in MS to forbid
stale calc delete bitmap task to wrongly update delete bitmaps in MS.
But this may lead to load fail due to the check on FE.
This PR let FE retry to commit the txn when encounter stale calc delete
bitmap response regardless of task's status code to avoid the problem.
@bobhan1 bobhan1 requested a review from dataroaring as a code owner July 7, 2025 02:48
@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 7, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 7, 2025

run buildall

dataroaring
dataroaring approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 28c6664 into apache:branch-3.0 Jul 8, 2025
21 of 24 checks passed
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bobhan1 @hello-stephen @dataroaring