Skip to content

[fix](audit) fix invalid audit log column and line separator #52968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Jul 9, 2025
Merged

[fix](audit) fix invalid audit log column and line separator #52968

morningman merged 1 commit into from
Jul 9, 2025

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Jul 8, 2025

followup #52032, the separator is wrong

@Thearas
Copy link
Contributor

Thearas commented Jul 8, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

morningman commented Jul 8, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 8, 2025

TPC-H: Total hot run time: 33209 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 115c3ace6402ce60c0ba531d24822fcd5005d288, data reload: false

------ Round 1 ----------------------------------
q1	17634	5367	5075	5075
q2	1949	303	186	186
q3	10277	1304	693	693
q4	10223	992	525	525
q5	7525	2384	2338	2338
q6	174	161	133	133
q7	903	746	596	596
q8	9321	1280	1068	1068
q9	6914	5153	5017	5017
q10	6883	2372	2012	2012
q11	482	299	259	259
q12	331	344	214	214
q13	17780	3708	3076	3076
q14	229	219	220	219
q15	541	489	468	468
q16	415	419	380	380
q17	573	861	353	353
q18	7527	7201	7202	7201
q19	1206	929	531	531
q20	323	361	225	225
q21	3784	2520	2345	2345
q22	363	309	295	295
Total cold run time: 105357 ms
Total hot run time: 33209 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5143	5042	5079	5042
q2	235	322	223	223
q3	2160	2713	2295	2295
q4	1386	1792	1302	1302
q5	4205	4154	4620	4154
q6	210	167	124	124
q7	2034	1965	1825	1825
q8	2659	2665	2603	2603
q9	7337	7374	7238	7238
q10	3090	3308	2889	2889
q11	563	527	502	502
q12	708	765	654	654
q13	3623	4110	3251	3251
q14	275	306	304	304
q15	550	479	478	478
q16	449	498	454	454
q17	1197	1565	1420	1420
q18	7969	7763	7623	7623
q19	758	784	875	784
q20	2029	2151	1908	1908
q21	5010	4597	4511	4511
q22	597	602	582	582
Total cold run time: 52187 ms
Total hot run time: 50166 ms

@doris-robot
Copy link

doris-robot commented Jul 8, 2025

TPC-DS: Total hot run time: 185860 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 115c3ace6402ce60c0ba531d24822fcd5005d288, data reload: false

query1	1006	389	385	385
query2	6529	1785	1755	1755
query3	6744	224	213	213
query4	26077	23654	23269	23269
query5	4354	569	425	425
query6	297	214	221	214
query7	4621	492	302	302
query8	270	221	213	213
query9	8599	2587	2597	2587
query10	469	324	261	261
query11	15510	15516	14829	14829
query12	152	110	109	109
query13	1662	524	413	413
query14	9018	5756	5774	5756
query15	200	195	166	166
query16	7290	420	249	249
query17	1353	697	569	569
query18	1972	398	302	302
query19	190	177	166	166
query20	118	141	121	121
query21	214	120	103	103
query22	4060	3989	4628	3989
query23	34511	34026	33712	33712
query24	8430	2339	2391	2339
query25	512	456	382	382
query26	1233	259	138	138
query27	2781	493	352	352
query28	4289	2118	2098	2098
query29	740	552	415	415
query30	282	215	183	183
query31	902	824	784	784
query32	75	63	67	63
query33	536	321	268	268
query34	776	857	506	506
query35	623	640	559	559
query36	931	966	882	882
query37	107	98	76	76
query38	4095	4107	4026	4026
query39	1448	1410	1393	1393
query40	204	120	105	105
query41	54	53	50	50
query42	122	105	111	105
query43	508	501	470	470
query44	1304	845	820	820
query45	173	174	162	162
query46	816	1006	626	626
query47	1755	1808	1727	1727
query48	395	404	312	312
query49	729	484	381	381
query50	616	692	411	411
query51	4101	4136	4176	4136
query52	102	105	94	94
query53	218	251	185	185
query54	567	555	493	493
query55	79	79	83	79
query56	293	292	279	279
query57	1153	1194	1093	1093
query58	261	255	269	255
query59	2742	2709	2682	2682
query60	337	309	300	300
query61	124	179	126	126
query62	788	705	670	670
query63	219	186	180	180
query64	4374	1234	818	818
query65	4257	4156	4162	4156
query66	1135	395	292	292
query67	15771	15531	15191	15191
query68	7531	888	514	514
query69	513	301	271	271
query70	1190	1166	1121	1121
query71	389	308	293	293
query72	5769	4733	4931	4733
query73	674	657	350	350
query74	8843	9089	8657	8657
query75	3178	3188	2733	2733
query76	3221	1140	703	703
query77	486	363	290	290
query78	10848	11130	10289	10289
query79	1098	936	579	579
query80	639	537	442	442
query81	447	260	229	229
query82	175	125	94	94
query83	255	260	242	242
query84	245	110	82	82
query85	752	363	398	363
query86	314	312	282	282
query87	4437	4455	4365	4365
query88	2928	2295	2297	2295
query89	369	311	286	286
query90	1758	216	219	216
query91	134	162	110	110
query92	65	63	54	54
query93	984	971	591	591
query94	634	325	200	200
query95	376	285	288	285
query96	485	616	279	279
query97	2666	2765	2644	2644
query98	221	204	202	202
query99	1319	1439	1296	1296
Total cold run time: 269116 ms
Total hot run time: 185860 ms

@doris-robot
Copy link

doris-robot commented Jul 8, 2025

ClickBench: Total hot run time: 29.35 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 115c3ace6402ce60c0ba531d24822fcd5005d288, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.05
query3	0.24	0.07	0.08
query4	1.62	0.12	0.11
query5	0.43	0.41	0.41
query6	1.16	0.67	0.66
query7	0.02	0.03	0.02
query8	0.04	0.03	0.04
query9	0.60	0.51	0.50
query10	0.56	0.57	0.59
query11	0.16	0.10	0.10
query12	0.15	0.11	0.12
query13	0.63	0.61	0.62
query14	0.78	0.81	0.81
query15	0.92	0.87	0.88
query16	0.40	0.38	0.40
query17	1.07	1.03	1.05
query18	0.22	0.21	0.21
query19	1.89	1.90	1.83
query20	0.02	0.01	0.01
query21	15.43	0.90	0.55
query22	0.77	1.11	0.61
query23	15.09	1.41	0.61
query24	7.86	0.62	0.63
query25	0.47	0.24	0.19
query26	0.61	0.18	0.14
query27	0.07	0.05	0.05
query28	9.09	0.85	0.45
query29	12.56	4.01	3.33
query30	0.25	0.08	0.06
query31	2.84	0.61	0.39
query32	3.24	0.56	0.48
query33	3.05	3.06	3.18
query34	16.08	5.41	4.77
query35	4.80	4.84	4.86
query36	0.69	0.52	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.03
query40	0.17	0.14	0.14
query41	0.09	0.02	0.03
query42	0.03	0.03	0.02
query43	0.04	0.02	0.02
Total cold run time: 104.43 s
Total hot run time: 29.35 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 8, 2025

FE UT Coverage Report

Increment line coverage 100% (0/0) 🎉
Increment coverage report
Complete coverage report

Thearas
Thearas approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@Thearas Thearas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

PR approved by anyone and no changes requested.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

PR approved by anyone and no changes requested.

@morningman morningman merged commit fa3b5dd into apache:master Jul 9, 2025
33 checks passed
morningman added a commit to morningman/doris that referenced this pull request Jul 9, 2025
@morningman
[fix](audit) fix invalid audit log column and line separator (apache#…
4f200d7 
…52968)

followup apache#52032, the separator is wrong
@morningman morningman mentioned this pull request Jul 9, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jul 10, 2025
@morningman @yagagagaga
branch-3.1: [opt](audit) use one line in audit log and origin stateme…
ec5936c 
…nt in audit table #52032 #52587 #52968 (#53022)

bp 

---------

Co-authored-by: yagagagaga <zhangminke@selectdb.com>
morningman added a commit to morningman/doris that referenced this pull request Jul 29, 2025
@morningman
branch-3.0: [fix](audit) fix invalid audit log column and line separa…
f78b2e8 
…tor apache#52968
@morningman morningman mentioned this pull request Jul 29, 2025
Merged
dataroaring pushed a commit that referenced this pull request Jul 30, 2025
@morningman
branch-3.0: [fix](audit) fix invalid audit log column and line separa…
063767a 
…tor #52968 (#54059)

bp #52968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@zy-kkk zy-kkk zy-kkk approved these changes

+2 more reviewers

@Thearas Thearas Thearas approved these changes

@hubgeter hubgeter hubgeter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.7-merged dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@morningman @Thearas @doris-robot @hello-stephen @CalvinKirs @zy-kkk @hubgeter @dataroaring @morrySnow