Skip to content

branch-3.0: [Fix](mow) Fix DeleteBitmap's assignment operator and constructor #52582 #52974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jul 9, 2025
Merged

branch-3.0: [Fix](mow) Fix DeleteBitmap's assignment operator and constructor #52582 #52974

dataroaring merged 1 commit into from
Jul 9, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jul 9, 2025

Cherry-picked from #52582

@bobhan1
[Fix](mow) Fix DeleteBitmap's assignment operator and constructor (#…
acff91d 
…52582)

### What problem does this PR solve?

Currently, `DeleteBitmap`'s wrong move assignment operator can cause
correctness problem on mow table if SC's alter process produce delete
bitmaps when calculating delete bitmaps for incremental rowsets after
the modification in `CloudSchemaChangeJob::_process_delete_bitmap` of
#52440 because `origin_dbm` and
`delete_bitmap` refer to the same `DeleteBitmap` object.

![image](https://github.com/user-attachments/assets/254d975a-594a-4b47-b028-64e47a05cb72)
@github-actions github-actions bot requested a review from dataroaring as a code owner July 9, 2025 02:06
@Thearas
Copy link
Contributor

Thearas commented Jul 9, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Jul 9, 2025
@dataroaring dataroaring reopened this Jul 9, 2025
@Thearas
Copy link
Contributor

Thearas commented Jul 9, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 9, 2025

BE UT Coverage Report

Increment line coverage 8.70% (2/23) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.22% (10952/26568)
Line Coverage 31.98% (93802/293319)
Region Coverage 31.13% (48372/155394)
Branch Coverage 27.57% (24781/89884)

@doris-robot
Copy link

doris-robot commented Jul 9, 2025

TPC-H: Total hot run time: 39917 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit acff91dca654d94a7cf38e2e268afce98f7df93e, data reload: false

------ Round 1 ----------------------------------
q1	17937	6964	6617	6617
q2	2082	194	165	165
q3	10643	1158	1169	1158
q4	10393	717	755	717
q5	7779	2932	2810	2810
q6	214	133	130	130
q7	983	645	594	594
q8	9346	1978	1996	1978
q9	6651	6361	6390	6361
q10	6985	2306	2324	2306
q11	456	264	258	258
q12	389	207	216	207
q13	17790	3007	2988	2988
q14	250	203	215	203
q15	508	468	458	458
q16	465	381	366	366
q17	975	606	593	593
q18	7298	6651	6777	6651
q19	1416	1103	1031	1031
q20	483	201	200	200
q21	3883	3134	3165	3134
q22	1132	1017	992	992
Total cold run time: 108058 ms
Total hot run time: 39917 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6632	6592	6574	6574
q2	339	232	238	232
q3	2917	2911	2948	2911
q4	2048	1868	1824	1824
q5	5696	5729	5691	5691
q6	214	125	125	125
q7	2287	1766	1841	1766
q8	3365	3524	3575	3524
q9	8738	8887	8944	8887
q10	3584	3538	3532	3532
q11	584	504	489	489
q12	806	626	593	593
q13	5622	3165	3196	3165
q14	288	288	259	259
q15	511	487	460	460
q16	502	449	432	432
q17	1855	1623	1599	1599
q18	8183	7840	7770	7770
q19	1706	1479	1552	1479
q20	2065	1869	1822	1822
q21	5223	5039	5043	5039
q22	1079	1058	1055	1055
Total cold run time: 64244 ms
Total hot run time: 59228 ms

@doris-robot
Copy link

doris-robot commented Jul 9, 2025

TPC-DS: Total hot run time: 196019 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit acff91dca654d94a7cf38e2e268afce98f7df93e, data reload: false

query1	1332	908	898	898
query2	6386	1827	1811	1811
query3	10810	4218	4359	4218
query4	32824	23660	23481	23481
query5	3591	456	437	437
query6	260	170	177	170
query7	3984	320	327	320
query8	275	214	210	210
query9	9476	2580	2579	2579
query10	475	260	256	256
query11	18466	15240	15436	15240
query12	182	102	103	102
query13	1545	425	424	424
query14	9363	6700	7019	6700
query15	239	177	188	177
query16	7816	498	487	487
query17	1579	567	565	565
query18	2085	316	308	308
query19	206	165	158	158
query20	124	111	110	110
query21	213	105	103	103
query22	4662	4451	4354	4354
query23	35111	33886	34117	33886
query24	12449	2920	2925	2920
query25	741	417	453	417
query26	1812	171	169	169
query27	2964	348	354	348
query28	7988	2199	2199	2199
query29	1128	472	464	464
query30	271	160	156	156
query31	1064	862	904	862
query32	104	60	59	59
query33	784	305	318	305
query34	974	528	541	528
query35	896	731	729	729
query36	1154	975	963	963
query37	273	68	73	68
query38	4125	4000	4056	4000
query39	1534	1479	1470	1470
query40	267	102	104	102
query41	51	50	53	50
query42	121	103	105	103
query43	521	477	486	477
query44	1318	824	815	815
query45	192	175	172	172
query46	1178	724	762	724
query47	1968	1873	1881	1873
query48	475	385	391	385
query49	1063	419	440	419
query50	829	431	427	427
query51	7459	7276	7290	7276
query52	108	91	97	91
query53	287	185	188	185
query54	1263	497	462	462
query55	81	79	81	79
query56	287	246	256	246
query57	1323	1192	1173	1173
query58	229	225	214	214
query59	3189	2978	3016	2978
query60	293	258	260	258
query61	112	107	162	107
query62	881	688	706	688
query63	220	201	195	195
query64	5265	668	638	638
query65	3407	3296	3309	3296
query66	1421	294	297	294
query67	16227	15527	15355	15355
query68	4566	588	567	567
query69	447	257	262	257
query70	1170	1095	1087	1087
query71	330	253	254	253
query72	6164	4009	4089	4009
query73	752	344	357	344
query74	10158	8982	8892	8892
query75	3428	2674	2636	2636
query76	2719	1001	1106	1001
query77	389	266	266	266
query78	10557	9618	9573	9573
query79	2320	604	617	604
query80	1154	417	417	417
query81	545	225	223	223
query82	924	88	89	88
query83	240	138	138	138
query84	238	81	83	81
query85	1334	309	290	290
query86	440	308	292	292
query87	4356	4275	4252	4252
query88	4243	2385	2386	2385
query89	414	296	290	290
query90	1915	184	179	179
query91	180	144	148	144
query92	68	48	51	48
query93	2369	550	567	550
query94	842	286	298	286
query95	356	253	254	253
query96	623	281	277	277
query97	3293	3162	3132	3132
query98	232	207	197	197
query99	1465	1311	1275	1275
Total cold run time: 307531 ms
Total hot run time: 196019 ms

@doris-robot
Copy link

doris-robot commented Jul 9, 2025

ClickBench: Total hot run time: 29.87 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit acff91dca654d94a7cf38e2e268afce98f7df93e, data reload: false

query1	0.04	0.04	0.03
query2	0.06	0.03	0.03
query3	0.23	0.07	0.06
query4	1.63	0.10	0.10
query5	0.53	0.53	0.54
query6	1.13	0.75	0.73
query7	0.02	0.01	0.02
query8	0.05	0.03	0.03
query9	0.55	0.49	0.49
query10	0.56	0.56	0.56
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.60	0.60	0.61
query14	0.79	0.79	0.81
query15	0.84	0.84	0.82
query16	0.39	0.39	0.39
query17	1.03	1.08	1.06
query18	0.23	0.22	0.22
query19	1.97	1.88	1.83
query20	0.01	0.02	0.01
query21	15.42	0.58	0.56
query22	2.23	2.10	1.58
query23	17.20	0.98	0.93
query24	3.01	1.68	0.76
query25	0.28	0.10	0.21
query26	0.34	0.14	0.13
query27	0.06	0.05	0.04
query28	10.21	0.49	0.48
query29	12.55	3.28	3.26
query30	0.24	0.05	0.06
query31	2.87	0.39	0.38
query32	3.23	0.47	0.46
query33	3.00	2.94	3.03
query34	16.82	4.46	4.49
query35	4.53	4.55	4.47
query36	0.67	0.47	0.48
query37	0.09	0.06	0.06
query38	0.05	0.03	0.04
query39	0.04	0.02	0.02
query40	0.17	0.12	0.12
query41	0.07	0.02	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.09 s
Total hot run time: 29.87 s

@bobhan1
Copy link
Contributor

bobhan1 commented Jul 9, 2025

run cloud_p0

dataroaring
dataroaring approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 632b033 into branch-3.0 Jul 9, 2025
22 of 25 checks passed
@github-actions github-actions bot deleted the auto-pick-52582-branch-3.0 branch July 9, 2025 07:43
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Thearas @doris-robot @bobhan1 @dataroaring