Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jul 9, 2025

Cherry-picked from #52582

…52582)

### What problem does this PR solve?

Currently, `DeleteBitmap`'s wrong move assignment operator can cause
correctness problem on mow table if SC's alter process produce delete
bitmaps when calculating delete bitmaps for incremental rowsets after
the modification in `CloudSchemaChangeJob::_process_delete_bitmap` of
#52440 because `origin_dbm` and
`delete_bitmap` refer to the same `DeleteBitmap` object.

![image](https://github.com/user-attachments/assets/254d975a-594a-4b47-b028-64e47a05cb72)
@github-actions github-actions bot requested a review from morrySnow as a code owner July 9, 2025 02:06
@Thearas
Copy link
Contributor

Thearas commented Jul 9, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Jul 9, 2025
@dataroaring dataroaring reopened this Jul 9, 2025
@Thearas
Copy link
Contributor

Thearas commented Jul 9, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40023 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 46851d053159eab97328e6df7e08a9b3a37e89c1, data reload: false

------ Round 1 ----------------------------------
q1	17612	6971	6648	6648
q2	2093	183	163	163
q3	10633	1137	1174	1137
q4	10385	764	772	764
q5	7740	2899	2817	2817
q6	218	132	130	130
q7	988	632	624	624
q8	9352	1973	1988	1973
q9	6724	6405	6420	6405
q10	7047	2247	2309	2247
q11	483	269	276	269
q12	412	229	217	217
q13	17789	3010	3052	3010
q14	239	213	209	209
q15	505	469	475	469
q16	470	379	382	379
q17	1000	588	566	566
q18	7165	6722	6584	6584
q19	1311	1037	1031	1031
q20	493	204	201	201
q21	3975	3178	3292	3178
q22	1128	1002	1006	1002
Total cold run time: 107762 ms
Total hot run time: 40023 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6636	6635	6559	6559
q2	332	232	243	232
q3	2907	2965	2945	2945
q4	2099	1868	1875	1868
q5	5719	5710	5727	5710
q6	214	126	126	126
q7	2215	1801	1801	1801
q8	3382	3548	3529	3529
q9	8746	8958	8911	8911
q10	3577	3521	3565	3521
q11	586	485	484	484
q12	828	626	598	598
q13	9668	3244	3179	3179
q14	307	275	266	266
q15	516	460	470	460
q16	506	432	448	432
q17	1856	1644	1626	1626
q18	8362	7869	7756	7756
q19	1670	1604	1543	1543
q20	2064	1817	1865	1817
q21	5185	4927	4926	4926
q22	1164	1043	1069	1043
Total cold run time: 68539 ms
Total hot run time: 59332 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196651 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 46851d053159eab97328e6df7e08a9b3a37e89c1, data reload: false

query1	1278	917	893	893
query2	6255	1926	1910	1910
query3	10949	4552	4182	4182
query4	33371	23286	23402	23286
query5	3497	484	448	448
query6	265	187	181	181
query7	3995	320	323	320
query8	290	244	229	229
query9	9303	2583	2560	2560
query10	491	270	282	270
query11	17862	15158	15256	15158
query12	169	100	105	100
query13	1564	447	420	420
query14	9154	7377	6582	6582
query15	245	188	183	183
query16	8047	504	515	504
query17	1645	608	605	605
query18	2140	315	327	315
query19	227	174	164	164
query20	125	109	109	109
query21	223	115	106	106
query22	4885	4641	4616	4616
query23	35312	34325	34269	34269
query24	11049	2900	2965	2900
query25	655	445	442	442
query26	1263	175	176	175
query27	2558	358	381	358
query28	7677	2216	2184	2184
query29	910	434	428	428
query30	275	160	163	160
query31	1020	816	803	803
query32	102	52	56	52
query33	768	296	302	296
query34	972	504	518	504
query35	867	735	732	732
query36	1128	966	955	955
query37	132	70	68	68
query38	4160	3986	3929	3929
query39	1510	1499	1510	1499
query40	202	99	102	99
query41	54	49	45	45
query42	111	107	104	104
query43	520	494	483	483
query44	1324	822	809	809
query45	181	173	170	170
query46	1186	762	723	723
query47	2010	1940	1983	1940
query48	420	340	358	340
query49	955	397	406	397
query50	858	431	422	422
query51	7395	7389	7215	7215
query52	105	90	92	90
query53	265	193	177	177
query54	1368	482	494	482
query55	86	79	79	79
query56	257	253	256	253
query57	1313	1237	1237	1237
query58	227	218	219	218
query59	3347	3158	3104	3104
query60	283	264	256	256
query61	108	153	113	113
query62	868	682	702	682
query63	228	188	187	187
query64	4105	670	663	663
query65	3380	3268	3186	3186
query66	763	298	299	298
query67	15883	15577	15583	15577
query68	4529	595	576	576
query69	455	267	266	266
query70	1183	1109	1091	1091
query71	337	257	262	257
query72	6288	4038	4133	4038
query73	754	354	348	348
query74	10555	9414	8948	8948
query75	3399	2650	2673	2650
query76	2615	1013	1058	1013
query77	452	289	265	265
query78	10486	9617	9672	9617
query79	1706	615	599	599
query80	1199	418	434	418
query81	553	216	219	216
query82	936	89	88	88
query83	233	147	146	146
query84	228	82	75	75
query85	1395	301	291	291
query86	442	278	302	278
query87	4422	4260	4224	4224
query88	3596	2379	2364	2364
query89	423	300	291	291
query90	1902	183	197	183
query91	139	107	109	107
query92	61	51	52	51
query93	2191	552	556	552
query94	847	304	302	302
query95	360	252	252	252
query96	618	284	284	284
query97	3267	3154	3216	3154
query98	221	214	193	193
query99	1528	1270	1322	1270
Total cold run time: 301460 ms
Total hot run time: 196651 ms

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 8.70% (2/23) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.17% (12475/27619)
Line Coverage 36.04% (110602/306856)
Region Coverage 35.21% (57346/162862)
Branch Coverage 32.28% (31090/96300)

@doris-robot
Copy link

ClickBench: Total hot run time: 30.53 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 46851d053159eab97328e6df7e08a9b3a37e89c1, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.63	0.10	0.11
query5	0.53	0.53	0.53
query6	1.13	0.73	0.73
query7	0.02	0.02	0.02
query8	0.04	0.02	0.03
query9	0.58	0.52	0.52
query10	0.58	0.57	0.57
query11	0.15	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.59	0.59
query14	0.78	0.78	0.80
query15	0.84	0.83	0.81
query16	0.39	0.38	0.38
query17	1.03	1.03	0.95
query18	0.23	0.22	0.21
query19	1.98	1.88	1.89
query20	0.02	0.01	0.01
query21	15.42	0.57	0.56
query22	2.40	1.85	1.78
query23	16.99	0.85	0.97
query24	3.02	1.36	1.72
query25	0.25	0.19	0.12
query26	0.44	0.13	0.13
query27	0.04	0.04	0.04
query28	9.65	0.49	0.46
query29	12.64	3.21	3.15
query30	0.24	0.06	0.06
query31	2.88	0.38	0.37
query32	3.25	0.47	0.46
query33	2.98	3.01	3.04
query34	17.25	4.50	4.49
query35	4.58	4.58	4.46
query36	0.67	0.47	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.16	0.12	0.11
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 104.21 s
Total hot run time: 30.53 s

@bobhan1
Copy link
Contributor

bobhan1 commented Jul 9, 2025

run cloud_p0

@morrySnow morrySnow merged commit af846b2 into branch-3.1 Jul 9, 2025
21 of 22 checks passed
@github-actions github-actions bot deleted the auto-pick-52582-branch-3.1 branch July 9, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants