Skip to content

branch-3.1: [Bug](function) fix bitmap_from_base64 function cause heap-buffer-overflow error #53018 #53045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morrySnow merged 1 commit into from
Jul 11, 2025
Merged

branch-3.1: [Bug](function) fix bitmap_from_base64 function cause heap-buffer-overflow error #53018 #53045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions be/src/vec/functions/function_bitmap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,8 +289,8 @@ struct BitmapFromBase64 {
} else {
BitmapValue bitmap_val;
if (!bitmap_val.deserialize(decode_buff.data())) {
return Status::RuntimeError(
fmt::format("bitmap_from_base64 decode failed: base64: {}", src_str));
return Status::RuntimeError("bitmap_from_base64 decode failed: base64: {}",
std::string(src_str, src_size));
}
res.emplace_back(std::move(bitmap_val));
}
Expand Down
5 changes: 5 additions & 0 deletions regression-test/suites/query_p0/sql_functions/bitmap_functions/test_bitmap_function.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,4 +927,9 @@ suite("test_bitmap_function") {
// BITMAP_FROM_ARRAY
sql """ set experimental_enable_nereids_planner=true; """
qt_sql """ select bitmap_to_string(BITMAP_FROM_ARRAY([]));"""

test {
sql """ SELECT bitmap_from_base64('CQoL') AS result; """
exception "bitmap_from_base64 decode failed"
}
}
Loading