Skip to content

[regression](filecache) fix regression failures #53057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 3 commits into from
Jul 17, 2025
Merged

[regression](filecache) fix regression failures #53057

dataroaring merged 3 commits into from
Jul 17, 2025

Conversation

@freemandealer
Copy link
Contributor

@freemandealer freemandealer commented Jul 10, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@freemandealer
[regression](filecache) fix regression failures
9e7ab83 
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 10, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

dataroaring
dataroaring previously approved these changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2025

PR approved by anyone and no changes requested.

@dataroaring
Copy link
Contributor

dataroaring commented Jul 11, 2025

run buildall

@dataroaring
Copy link
Contributor

dataroaring commented Jul 14, 2025

run buildall

@freemandealer
fix regression
42496d7 
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 14, 2025
gavinchou
gavinchou previously approved these changes Jul 14, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 14, 2025
@dataroaring
Copy link
Contributor

dataroaring commented Jul 15, 2025

run buildall

@freemandealer
3rd fix
a3ea5a3 
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 15, 2025
@dataroaring
Copy link
Contributor

dataroaring commented Jul 16, 2025

run buildall

dataroaring
dataroaring approved these changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 16, 2025
@dataroaring dataroaring merged commit c772c44 into apache:master Jul 17, 2025
27 of 30 checks passed
freemandealer added a commit to freemandealer/doris that referenced this pull request Jul 29, 2025
@freemandealer
[regression](filecache) fix regression failures (apache#53057)
8147903
freemandealer added a commit to freemandealer/doris that referenced this pull request Jul 29, 2025
@freemandealer
[regression](filecache) fix regression failures (apache#53057)
92175f1
@morrySnow morrySnow mentioned this pull request Jul 29, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jul 29, 2025
@freemandealer
branch-3.1: [test](filecache) fix regression failures #53057 #53783 (#…
748fde7 
…54004)

picked from #53057 #53783
dataroaring pushed a commit that referenced this pull request Aug 1, 2025
@freemandealer
[regression](filecache) fix regression failures (#53057) (#54001)
6c48b63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

@gavinchou gavinchou gavinchou left review comments

+1 more reviewer

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@freemandealer @hello-stephen @dataroaring @gavinchou @Yukang-Lian @morrySnow