Skip to content

Conversation

@kaijchen
Copy link
Member

pick #52991

Add the following metrics:

  • file_cache_once_or_periodic_warm_up_submitted_tablet_num
  • file_cache_once_or_periodic_warm_up_finished_tablet_num

Fix the following metrics:

  • file_cache_once_or_periodic_warm_up_finished_segment_num
  • file_cache_once_or_periodic_warm_up_finished_segment_size
  • file_cache_once_or_periodic_warm_up_finished_index_num
  • file_cache_once_or_periodic_warm_up_finished_index_size

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…he#52739)

pick apache#52991 

Add the following metrics:

* `file_cache_once_or_periodic_warm_up_submitted_tablet_num`
* `file_cache_once_or_periodic_warm_up_finished_tablet_num`

Fix the following metrics:

* `file_cache_once_or_periodic_warm_up_finished_segment_num`
* `file_cache_once_or_periodic_warm_up_finished_segment_size`
* `file_cache_once_or_periodic_warm_up_finished_index_num`
* `file_cache_once_or_periodic_warm_up_finished_index_size`
@kaijchen kaijchen requested a review from dataroaring as a code owner July 14, 2025 06:31
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@kaijchen
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39996 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e264e70e1f1703ed577edc911238b32b0a24c3a2, data reload: false

------ Round 1 ----------------------------------
q1	17568	6797	6646	6646
q2	2077	214	180	180
q3	10465	1119	1102	1102
q4	10209	750	704	704
q5	7770	2888	2877	2877
q6	216	135	135	135
q7	974	619	618	618
q8	9348	1973	2011	1973
q9	6640	6394	6434	6394
q10	7066	2246	2336	2246
q11	460	263	258	258
q12	403	212	224	212
q13	17783	2964	2965	2964
q14	235	204	215	204
q15	523	474	472	472
q16	496	392	401	392
q17	968	620	567	567
q18	7299	6688	6518	6518
q19	1396	1136	1105	1105
q20	479	202	198	198
q21	4014	3271	3254	3254
q22	1090	977	985	977
Total cold run time: 107479 ms
Total hot run time: 39996 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6646	6641	6619	6619
q2	330	227	223	223
q3	2915	2972	2951	2951
q4	2011	1830	1866	1830
q5	5688	5754	5681	5681
q6	215	129	134	129
q7	2238	1804	1811	1804
q8	3360	3536	3605	3536
q9	8754	8928	8834	8834
q10	3544	3474	3520	3474
q11	596	505	489	489
q12	812	590	592	590
q13	8344	3130	3185	3130
q14	304	272	267	267
q15	516	471	460	460
q16	508	432	440	432
q17	1839	1636	1626	1626
q18	8250	7728	7769	7728
q19	1724	1638	1562	1562
q20	2090	1806	1797	1797
q21	5314	5099	5132	5099
q22	1154	1086	1057	1057
Total cold run time: 67152 ms
Total hot run time: 59318 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196374 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e264e70e1f1703ed577edc911238b32b0a24c3a2, data reload: false

query1	1306	910	901	901
query2	6293	1849	1878	1849
query3	10824	4467	4406	4406
query4	32780	23672	23768	23672
query5	4290	473	436	436
query6	276	175	191	175
query7	3995	320	315	315
query8	281	212	220	212
query9	9491	2598	2572	2572
query10	492	260	257	257
query11	18319	15245	15296	15245
query12	156	101	102	101
query13	1554	422	419	419
query14	9905	6917	7575	6917
query15	268	179	178	178
query16	8018	477	500	477
query17	1673	569	585	569
query18	2152	311	298	298
query19	367	153	166	153
query20	118	123	114	114
query21	209	110	102	102
query22	4625	4666	4358	4358
query23	34461	35022	33685	33685
query24	11531	2910	2913	2910
query25	625	401	421	401
query26	1191	174	168	168
query27	2785	358	365	358
query28	7598	2180	2193	2180
query29	887	462	476	462
query30	275	152	155	152
query31	1046	810	836	810
query32	102	59	57	57
query33	774	303	308	303
query34	1044	531	529	529
query35	847	736	736	736
query36	1111	955	938	938
query37	133	68	66	66
query38	4035	3998	3975	3975
query39	1575	1527	1493	1493
query40	215	103	104	103
query41	51	52	53	52
query42	125	106	99	99
query43	517	468	475	468
query44	1298	861	840	840
query45	187	170	174	170
query46	1167	752	730	730
query47	2057	1920	1910	1910
query48	513	394	409	394
query49	922	434	410	410
query50	846	444	458	444
query51	7276	7232	7226	7226
query52	117	94	89	89
query53	260	200	201	200
query54	1319	497	481	481
query55	84	82	84	82
query56	280	283	265	265
query57	1329	1230	1207	1207
query58	246	219	228	219
query59	3241	2969	2931	2931
query60	293	262	263	262
query61	113	148	143	143
query62	867	676	707	676
query63	231	200	191	191
query64	4112	669	636	636
query65	3360	3287	3348	3287
query66	773	312	305	305
query67	15934	15576	15437	15437
query68	4784	588	570	570
query69	432	263	268	263
query70	1165	1078	1154	1078
query71	319	253	254	253
query72	6297	3770	3994	3770
query73	767	347	345	345
query74	10480	9252	9039	9039
query75	3346	2639	2704	2639
query76	2753	1197	1024	1024
query77	396	277	277	277
query78	10691	9547	9486	9486
query79	1349	605	604	604
query80	923	435	446	435
query81	529	222	221	221
query82	1169	95	89	89
query83	240	141	146	141
query84	244	81	79	79
query85	1098	308	290	290
query86	354	294	303	294
query87	4411	4257	4209	4209
query88	3610	2424	2399	2399
query89	425	295	291	291
query90	1916	189	187	187
query91	187	151	147	147
query92	55	53	51	51
query93	1293	546	550	546
query94	760	303	289	289
query95	365	263	262	262
query96	607	275	290	275
query97	3298	3125	3133	3125
query98	209	198	203	198
query99	1627	1296	1292	1292
Total cold run time: 301244 ms
Total hot run time: 196374 ms

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/19) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.21% (10949/26572)
Line Coverage 31.94% (93800/293640)
Region Coverage 31.08% (48357/155566)
Branch Coverage 27.53% (24773/89988)

@doris-robot
Copy link

ClickBench: Total hot run time: 29.81 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e264e70e1f1703ed577edc911238b32b0a24c3a2, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.06	0.06
query4	1.63	0.11	0.11
query5	0.51	0.50	0.52
query6	1.13	0.73	0.74
query7	0.02	0.02	0.01
query8	0.03	0.03	0.02
query9	0.56	0.51	0.50
query10	0.55	0.55	0.56
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.60	0.59	0.61
query14	0.78	0.78	0.80
query15	0.85	0.83	0.83
query16	0.38	0.38	0.39
query17	1.07	1.01	1.05
query18	0.23	0.21	0.22
query19	1.95	1.90	1.77
query20	0.01	0.01	0.02
query21	15.40	0.59	0.58
query22	2.47	2.23	1.98
query23	17.07	0.92	0.86
query24	2.72	1.51	0.39
query25	0.26	0.15	0.16
query26	0.38	0.13	0.14
query27	0.04	0.04	0.06
query28	10.92	0.47	0.47
query29	12.58	3.29	3.24
query30	0.26	0.07	0.06
query31	2.86	0.38	0.37
query32	3.29	0.46	0.45
query33	2.93	3.00	3.01
query34	17.32	4.53	4.46
query35	4.45	4.52	4.52
query36	0.67	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.12	0.14
query41	0.07	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.99 s
Total hot run time: 29.81 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 13ed5b7 into apache:branch-3.0 Jul 15, 2025
22 of 25 checks passed
dataroaring pushed a commit that referenced this pull request Aug 28, 2025
…rics (#55283)

### What problem does this PR solve?

Problem Summary:
Some metrics were added twice, remove duplicated adding.
This is caused by #53189 PR merge issue.

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants