Skip to content

Conversation

@gavinchou
Copy link
Contributor

@gavinchou gavinchou commented Jul 16, 2025

cumu point in job is from base tablet which may be fetched long time ago
since the new tablet may have done cumu compactions with alter_version as initial cumu point
current cumu point of new tablet may be larger than job.alter_version
we need to keep the larger one in case of cumu point roll-back to
break the basic assumptions of non-decreasing cumu point

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@gavinchou gavinchou force-pushed the gavin-fix-new-tablet-compaction branch from ec23295 to 8c40ce1 Compare July 16, 2025 12:25
@gavinchou
Copy link
Contributor Author

run buildall

@gavinchou gavinchou force-pushed the gavin-fix-new-tablet-compaction branch from 8c40ce1 to 7ab5e53 Compare July 16, 2025 12:33
@gavinchou
Copy link
Contributor Author

run buildall

Copy link
Collaborator

@Hastyshell Hastyshell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 25.00% (1/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 80.36% (1297/1614)
Line Coverage 65.80% (21708/32992)
Region Coverage 67.05% (10894/16247)
Branch Coverage 56.65% (5730/10114)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 17, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@gavinchou gavinchou merged commit 23170d6 into apache:master Jul 17, 2025
31 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 17, 2025
…g schema change (#53402)

cumu point in job is from base tablet which may be fetched long time ago
since the new tablet may have done cumu compactions with alter_version
as initial cumu point
current cumu point of new tablet may be larger than job.alter_version
we need to keep the larger one in case of cumu point roll-back to
break the basic assumptions of non-decreasing cumu point
github-actions bot pushed a commit that referenced this pull request Jul 17, 2025
…g schema change (#53402)

cumu point in job is from base tablet which may be fetched long time ago
since the new tablet may have done cumu compactions with alter_version
as initial cumu point
current cumu point of new tablet may be larger than job.alter_version
we need to keep the larger one in case of cumu point roll-back to
break the basic assumptions of non-decreasing cumu point
morrySnow pushed a commit that referenced this pull request Jul 18, 2025
…et when doing schema change #53402 (#53447)

Cherry-picked from #53402

Co-authored-by: Gavin Chou <gavin@selectdb.com>
dataroaring pushed a commit that referenced this pull request Jul 18, 2025
…et when doing schema change #53402 (#53446)

Cherry-picked from #53402

Co-authored-by: Gavin Chou <gavin@selectdb.com>
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. cloud dev/3.0.7-merged dev/3.1.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants