Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #53555

### What problem does this PR solve?

Issue Number: DORIS-21489

Problem Summary:

In older versions, the `tables` field doesn't exist.
When a newer version reads this data, the field becomes `null`, leading
to a `NullPointerException`.
This fix adds a null check to handle the upgrade path safely.
@github-actions github-actions bot requested a review from dataroaring as a code owner July 21, 2025 11:58
@Thearas
Copy link
Contributor

Thearas commented Jul 21, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jul 21, 2025
@Thearas
Copy link
Contributor

Thearas commented Jul 21, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40172 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 603bd41d62695f50e83d953442186039a0c9ceb5, data reload: false

------ Round 1 ----------------------------------
q1	17608	6787	6661	6661
q2	2081	181	176	176
q3	10511	1137	1154	1137
q4	10264	717	834	717
q5	7740	2884	2850	2850
q6	211	130	130	130
q7	959	628	595	595
q8	9586	1990	2069	1990
q9	8151	6427	6474	6427
q10	6979	2272	2360	2272
q11	467	265	271	265
q12	413	213	225	213
q13	17794	2996	3007	2996
q14	234	204	211	204
q15	526	492	478	478
q16	504	393	369	369
q17	984	568	560	560
q18	7294	6714	6795	6714
q19	1414	1093	1099	1093
q20	488	200	213	200
q21	3962	3246	3132	3132
q22	1130	993	1006	993
Total cold run time: 109300 ms
Total hot run time: 40172 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6640	6599	6604	6599
q2	325	225	227	225
q3	3078	2956	2954	2954
q4	2106	1821	1800	1800
q5	5673	5743	5806	5743
q6	209	129	131	129
q7	2274	1792	1814	1792
q8	3410	3551	3419	3419
q9	8949	8884	8839	8839
q10	3593	3537	3576	3537
q11	587	519	492	492
q12	810	588	627	588
q13	6147	3099	3157	3099
q14	293	262	276	262
q15	512	471	458	458
q16	540	438	449	438
q17	1853	1647	1604	1604
q18	8349	7817	7710	7710
q19	1700	1451	1551	1451
q20	2088	1853	1862	1853
q21	5267	5118	4969	4969
q22	1158	1090	1001	1001
Total cold run time: 65561 ms
Total hot run time: 58962 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196808 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 603bd41d62695f50e83d953442186039a0c9ceb5, data reload: false

query1	1270	929	895	895
query2	6379	1953	1998	1953
query3	10967	4438	4765	4438
query4	33363	23981	23250	23250
query5	3849	460	451	451
query6	284	188	183	183
query7	4005	324	326	324
query8	298	229	228	228
query9	9556	2602	2580	2580
query10	462	260	255	255
query11	18377	15271	15315	15271
query12	153	109	102	102
query13	1564	424	430	424
query14	9102	7311	6866	6866
query15	253	191	181	181
query16	8001	529	539	529
query17	1607	603	625	603
query18	2175	328	321	321
query19	227	163	170	163
query20	128	117	116	116
query21	208	109	115	109
query22	4642	4407	4479	4407
query23	35355	34280	33866	33866
query24	12310	2953	2908	2908
query25	709	429	426	426
query26	1834	176	168	168
query27	2989	349	354	349
query28	7675	2175	2215	2175
query29	1080	487	458	458
query30	265	155	155	155
query31	1046	844	827	827
query32	96	55	61	55
query33	778	297	295	295
query34	1253	508	533	508
query35	854	737	707	707
query36	1118	970	959	959
query37	263	68	72	68
query38	4066	3930	3948	3930
query39	1536	1456	1481	1456
query40	274	102	104	102
query41	50	50	47	47
query42	110	101	103	101
query43	537	494	487	487
query44	1246	812	810	810
query45	183	169	166	166
query46	1163	734	746	734
query47	2017	1938	1966	1938
query48	484	387	389	387
query49	1051	405	386	386
query50	823	430	440	430
query51	7547	7205	7366	7205
query52	104	90	89	89
query53	258	183	201	183
query54	1429	486	505	486
query55	79	83	78	78
query56	287	252	296	252
query57	1340	1229	1195	1195
query58	239	220	239	220
query59	3250	3053	3058	3053
query60	290	278	262	262
query61	113	121	140	121
query62	873	704	705	704
query63	232	193	186	186
query64	4948	684	640	640
query65	3416	3325	3292	3292
query66	1317	310	337	310
query67	15894	15674	15587	15587
query68	5574	571	567	567
query69	452	272	254	254
query70	1187	1084	1059	1059
query71	347	262	249	249
query72	6192	4052	4042	4042
query73	745	340	353	340
query74	10182	8967	8984	8967
query75	3382	2626	2642	2626
query76	3192	1090	971	971
query77	389	274	264	264
query78	10570	9608	9598	9598
query79	1438	587	601	587
query80	1142	424	420	420
query81	541	222	228	222
query82	951	85	89	85
query83	234	146	144	144
query84	237	87	77	77
query85	1373	298	291	291
query86	401	305	312	305
query87	4397	4242	4262	4242
query88	3617	2431	2398	2398
query89	427	296	288	288
query90	1875	185	186	185
query91	183	148	148	148
query92	61	48	51	48
query93	1771	556	562	556
query94	876	309	293	293
query95	361	263	266	263
query96	612	292	278	278
query97	3308	3184	3162	3162
query98	215	193	201	193
query99	1497	1331	1276	1276
Total cold run time: 307380 ms
Total hot run time: 196808 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.04 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 603bd41d62695f50e83d953442186039a0c9ceb5, data reload: false

query1	0.03	0.04	0.03
query2	0.07	0.03	0.04
query3	0.24	0.06	0.06
query4	1.63	0.10	0.10
query5	0.51	0.49	0.50
query6	1.13	0.76	0.75
query7	0.02	0.02	0.01
query8	0.05	0.03	0.03
query9	0.56	0.50	0.49
query10	0.56	0.56	0.60
query11	0.14	0.09	0.10
query12	0.13	0.11	0.10
query13	0.60	0.60	0.59
query14	0.77	0.78	0.81
query15	0.84	0.81	0.83
query16	0.39	0.39	0.39
query17	1.06	1.07	1.01
query18	0.24	0.22	0.22
query19	1.95	1.81	1.76
query20	0.01	0.01	0.01
query21	15.39	0.58	0.57
query22	2.57	2.58	1.70
query23	16.92	1.05	0.84
query24	3.33	1.04	2.08
query25	0.28	0.26	0.11
query26	0.37	0.13	0.15
query27	0.03	0.03	0.04
query28	9.31	0.49	0.46
query29	12.58	3.23	3.20
query30	0.24	0.05	0.05
query31	2.86	0.41	0.40
query32	3.22	0.46	0.45
query33	2.99	3.02	2.98
query34	17.18	4.49	4.46
query35	4.57	4.56	4.53
query36	0.68	0.48	0.48
query37	0.08	0.06	0.07
query38	0.04	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.13	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 103.9 s
Total hot run time: 30.04 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 0bc9f88 into branch-3.0 Jul 23, 2025
24 of 25 checks passed
@github-actions github-actions bot deleted the auto-pick-53555-branch-3.0 branch July 23, 2025 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants