Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #53694

### What problem does this PR solve?

If show create load with not exist label, the error message is `Database
does not exist`, it make users confused and not correct, and it should
be `Label does not exist`
@github-actions github-actions bot requested a review from dataroaring as a code owner July 22, 2025 13:02
@Thearas
Copy link
Contributor

Thearas commented Jul 22, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jul 22, 2025
@Thearas
Copy link
Contributor

Thearas commented Jul 22, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40602 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6de5d15420634d50c6f84c3a06ab32c56cc9fec2, data reload: false

------ Round 1 ----------------------------------
q1	17591	7046	6803	6803
q2	2063	198	178	178
q3	10590	1180	1163	1163
q4	10444	797	820	797
q5	7743	3020	2896	2896
q6	231	132	132	132
q7	1020	615	607	607
q8	9578	2055	2080	2055
q9	8246	6524	6538	6524
q10	7084	2258	2355	2258
q11	459	262	261	261
q12	423	214	211	211
q13	17809	2939	2998	2939
q14	230	203	205	203
q15	523	481	459	459
q16	468	387	368	368
q17	1028	678	609	609
q18	7186	6743	6598	6598
q19	1386	1115	1102	1102
q20	513	199	203	199
q21	3998	3243	3280	3243
q22	1131	1011	997	997
Total cold run time: 109744 ms
Total hot run time: 40602 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7388	6810	6800	6800
q2	353	257	242	242
q3	3096	2931	3003	2931
q4	2111	1836	1790	1790
q5	5743	5773	5820	5773
q6	225	129	124	124
q7	2247	1796	1778	1778
q8	3471	3622	3540	3540
q9	9080	8992	8964	8964
q10	3628	3604	3532	3532
q11	595	505	499	499
q12	842	636	608	608
q13	6869	3142	3162	3142
q14	309	269	274	269
q15	534	466	459	459
q16	492	441	437	437
q17	1882	1668	1617	1617
q18	8231	7782	7563	7563
q19	1838	1785	1615	1615
q20	2108	1888	1929	1888
q21	5367	5341	5117	5117
q22	1150	1065	1056	1056
Total cold run time: 67559 ms
Total hot run time: 59744 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196778 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6de5d15420634d50c6f84c3a06ab32c56cc9fec2, data reload: false

query1	1319	948	916	916
query2	6260	1943	1899	1899
query3	10929	4321	4748	4321
query4	33037	23787	23627	23627
query5	3503	456	446	446
query6	276	186	190	186
query7	3988	309	307	307
query8	303	229	224	224
query9	9345	2582	2587	2582
query10	473	267	254	254
query11	18153	15196	15379	15196
query12	157	98	102	98
query13	1542	436	430	430
query14	9647	6917	7079	6917
query15	254	192	182	182
query16	8055	498	502	498
query17	1615	606	591	591
query18	2123	319	314	314
query19	282	160	154	154
query20	123	114	116	114
query21	204	104	109	104
query22	4819	4547	4442	4442
query23	35529	34122	34541	34122
query24	11761	2889	2853	2853
query25	665	397	401	397
query26	1698	169	168	168
query27	2816	344	353	344
query28	8008	2163	2146	2146
query29	920	466	453	453
query30	265	161	156	156
query31	1059	815	813	813
query32	92	55	55	55
query33	776	321	329	321
query34	1143	509	528	509
query35	933	741	717	717
query36	1100	932	947	932
query37	243	68	70	68
query38	4100	3987	3978	3978
query39	1537	1461	1490	1461
query40	255	106	109	106
query41	51	52	51	51
query42	116	105	103	103
query43	506	476	497	476
query44	1307	828	813	813
query45	187	181	173	173
query46	1199	733	724	724
query47	1997	1935	1984	1935
query48	469	384	379	379
query49	1154	441	404	404
query50	840	440	426	426
query51	7474	7241	7127	7127
query52	102	92	94	92
query53	275	193	192	192
query54	1234	472	484	472
query55	87	80	81	80
query56	297	263	260	260
query57	1334	1240	1203	1203
query58	240	225	226	225
query59	3124	3057	2916	2916
query60	270	245	243	243
query61	105	127	108	108
query62	879	629	681	629
query63	209	184	186	184
query64	4943	653	611	611
query65	3285	3226	3198	3198
query66	1326	295	283	283
query67	15921	15547	15529	15529
query68	5459	565	549	549
query69	446	276	270	270
query70	1123	1119	1070	1070
query71	329	263	261	261
query72	6106	4102	4070	4070
query73	745	348	340	340
query74	10665	9134	9171	9134
query75	3336	2612	2695	2612
query76	3270	1013	1080	1013
query77	378	269	266	266
query78	10501	9628	9609	9609
query79	2381	604	603	603
query80	1170	426	437	426
query81	544	217	215	215
query82	925	89	85	85
query83	232	146	143	143
query84	236	85	76	76
query85	1538	294	285	285
query86	486	318	300	300
query87	4389	4220	4280	4220
query88	3836	2381	2337	2337
query89	416	290	295	290
query90	2123	181	180	180
query91	178	150	145	145
query92	66	51	50	50
query93	2415	547	545	545
query94	1092	307	299	299
query95	354	252	256	252
query96	617	282	292	282
query97	3306	3139	3175	3139
query98	218	205	196	196
query99	1489	1279	1288	1279
Total cold run time: 308607 ms
Total hot run time: 196778 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.28 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6de5d15420634d50c6f84c3a06ab32c56cc9fec2, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.02
query3	0.23	0.07	0.07
query4	1.62	0.11	0.10
query5	0.51	0.52	0.53
query6	1.14	0.72	0.73
query7	0.02	0.02	0.04
query8	0.04	0.03	0.04
query9	0.55	0.52	0.50
query10	0.55	0.56	0.60
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.60	0.58	0.59
query14	0.78	0.77	0.81
query15	0.84	0.83	0.81
query16	0.40	0.38	0.41
query17	1.00	1.07	1.06
query18	0.23	0.21	0.21
query19	1.90	1.86	1.89
query20	0.02	0.02	0.01
query21	15.38	0.61	0.59
query22	2.24	2.33	1.35
query23	17.15	0.94	0.70
query24	3.58	1.65	0.36
query25	0.22	0.27	0.17
query26	0.34	0.14	0.14
query27	0.05	0.04	0.04
query28	10.08	0.53	0.52
query29	12.69	3.20	3.17
query30	0.24	0.06	0.06
query31	2.85	0.38	0.38
query32	3.26	0.46	0.46
query33	2.97	3.02	3.03
query34	17.00	4.52	4.53
query35	4.52	4.61	4.55
query36	0.65	0.48	0.51
query37	0.08	0.06	0.07
query38	0.05	0.04	0.03
query39	0.03	0.03	0.02
query40	0.16	0.13	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 104.49 s
Total hot run time: 29.28 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 23, 2025
@github-actions
Copy link
Contributor Author

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 7844a65 into branch-3.0 Jul 23, 2025
24 of 25 checks passed
@github-actions github-actions bot deleted the auto-pick-53694-branch-3.0 branch July 23, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants