Skip to content

[fix](vcg) use "vcg cancel" as cancel message for warm up jobs #53751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Aug 7, 2025
Merged

[fix](vcg) use "vcg cancel" as cancel message for warm up jobs #53751

dataroaring merged 1 commit into from
Aug 7, 2025

Conversation

@kaijchen
Copy link
Member

@kaijchen kaijchen commented Jul 23, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 23, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@kaijchen kaijchen changed the title [opt](vcg) use "vcg cancel" as cancel message for warm up jobs [fix](vcg) use "vcg cancel" as cancel message for warm up jobs Jul 23, 2025
This was referenced Jul 23, 2025
Merged
Merged
dataroaring pushed a commit that referenced this pull request Jul 23, 2025
@kaijchen
[fix](vcg) use "vcg cancel" as cancel message for warm up jobs (#53752)
93dc6e7 
cherry-pick #53751
morrySnow pushed a commit that referenced this pull request Jul 24, 2025
@kaijchen
branch-3.1: [fix](vcg) use "vcg cancel" as cancel message for warm up…
8cfd731 
… jobs #53751 (#53753)

cherry-pick #53751
@kaijchen kaijchen marked this pull request as ready for review August 6, 2025 08:35
@kaijchen
Copy link
Member Author

kaijchen commented Aug 6, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 6, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/3) 🎉
Increment coverage report
Complete coverage report

dataroaring
dataroaring approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

PR approved by anyone and no changes requested.

@gavinchou gavinchou added the cloud label Aug 7, 2025
@doris-robot
Copy link

doris-robot commented Aug 7, 2025

TPC-H: Total hot run time: 33857 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5645c157c0e58402beb551651358d59bdac36c3b, data reload: false

------ Round 1 ----------------------------------
q1	17621	5422	5336	5336
q2	1912	283	197	197
q3	10311	1590	724	724
q4	10223	1057	535	535
q5	7558	2246	2321	2246
q6	175	166	131	131
q7	885	753	603	603
q8	9294	1258	1033	1033
q9	6895	5014	5091	5014
q10	6902	2385	1983	1983
q11	449	280	264	264
q12	355	363	228	228
q13	17784	3450	2971	2971
q14	235	235	228	228
q15	531	488	471	471
q16	432	431	365	365
q17	567	800	356	356
q18	7584	7078	7124	7078
q19	3087	967	564	564
q20	324	319	215	215
q21	3340	3315	2312	2312
q22	1052	1031	1003	1003
Total cold run time: 107516 ms
Total hot run time: 33857 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5470	5255	5294	5255
q2	233	315	214	214
q3	2103	2540	2212	2212
q4	1341	1713	1306	1306
q5	4227	4466	4413	4413
q6	261	178	137	137
q7	1938	1937	1781	1781
q8	2559	2527	2465	2465
q9	7244	7716	7184	7184
q10	3818	3327	2918	2918
q11	546	511	498	498
q12	1016	828	638	638
q13	3259	3933	3492	3492
q14	287	316	289	289
q15	509	467	456	456
q16	441	482	492	482
q17	1205	1365	1318	1318
q18	7911	7303	7222	7222
q19	2144	869	1067	869
q20	2854	1938	1824	1824
q21	10556	4472	4327	4327
q22	1107	1003	985	985
Total cold run time: 61029 ms
Total hot run time: 50285 ms

@doris-robot
Copy link

doris-robot commented Aug 7, 2025

TPC-DS: Total hot run time: 170484 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5645c157c0e58402beb551651358d59bdac36c3b, data reload: false

============================================
query1	978	368	413	368
query2	6522	1765	1685	1685
query3	6751	228	225	225
query4	26889	23326	23448	23326
query5	4295	617	522	522
query6	329	243	230	230
query7	4640	528	298	298
query8	302	266	225	225
query9	8612	2962	2949	2949
query10	470	329	278	278
query11	15615	14901	14658	14658
query12	177	138	133	133
query13	1659	547	399	399
query14	9294	5814	5810	5810
query15	210	190	166	166
query16	7129	667	461	461
query17	970	764	649	649
query18	2023	458	369	369
query19	220	215	185	185
query20	146	158	141	141
query21	213	123	107	107
query22	4193	3926	3903	3903
query23	34386	34598	34303	34303
query24	7517	2390	2435	2390
query25	578	518	439	439
query26	1224	285	162	162
query27	2619	481	362	362
query28	4355	2333	2326	2326
query29	823	602	504	504
query30	294	235	198	198
query31	890	796	713	713
query32	87	73	77	73
query33	574	420	356	356
query34	855	830	519	519
query35	814	848	800	800
query36	1032	1019	933	933
query37	135	114	94	94
query38	3987	3980	3866	3866
query39	1492	1358	1383	1358
query40	242	142	135	135
query41	59	58	53	53
query42	141	125	129	125
query43	515	509	495	495
query44	1400	880	861	861
query45	198	191	185	185
query46	941	1051	666	666
query47	1790	1866	1765	1765
query48	394	424	308	308
query49	729	491	403	403
query50	678	673	435	435
query51	4238	4199	4158	4158
query52	129	134	113	113
query53	263	287	220	220
query54	658	640	557	557
query55	92	86	89	86
query56	356	364	350	350
query57	1188	1243	1150	1150
query58	335	330	335	330
query59	2601	2665	2651	2651
query60	407	411	398	398
query61	126	124	125	124
query62	793	737	700	700
query63	253	206	214	206
query64	4403	1132	833	833
query65	4279	4124	4164	4124
query66	1158	482	347	347
query67	query68	16381	868	836	836
query69	1314	294	297	294
query70	1555	1085	1100	1085
query71	697	316	319	316
query72	9227	2301	2251	2251
query73	2967	717	364	364
query74	9004	9023	8659	8659
query75	7586	3142	2652	2652
query76	8769	1214	794	794
query77	1169	409	341	341
query78	9578	10689	9521	9521
query79	14767	598	575	575
query80	1538	663	491	491
query81	541	258	235	235
query82	444	148	117	117
query83	343	284	269	269
query84	308	93	84	84
query85	925	381	340	340
query86	357	330	302	302
query87	4380	4160	4078	4078
query88	5516	2210	2203	2203
query89	479	366	314	314
query90	2500	225	220	220
query91	163	143	112	112
query92	89	72	68	68
query93	6085	960	667	667
query94	1021	388	289	289
query95	425	327	330	327
query96	499	592	276	276
query97	2711	2710	2592	2592
query98	252	240	229	229
query99	1468	1435	1322	1322
Total cold run time: 304723 ms
Total hot run time: 170484 ms

@doris-robot
Copy link

doris-robot commented Aug 7, 2025

ClickBench: Total hot run time: 32.67 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5645c157c0e58402beb551651358d59bdac36c3b, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.04	0.05
query3	0.25	0.07	0.07
query4	1.63	0.11	0.12
query5	0.43	0.43	0.44
query6	1.19	0.65	0.65
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.57	0.48	0.48
query10	0.53	0.53	0.52
query11	0.16	0.11	0.10
query12	0.14	0.11	0.10
query13	0.64	0.63	0.63
query14	0.93	1.05	1.08
query15	0.95	0.88	0.89
query16	0.38	0.39	0.39
query17	1.06	1.02	1.06
query18	0.22	0.21	0.21
query19	2.00	1.84	1.77
query20	0.02	0.01	0.01
query21	15.39	0.86	0.54
query22	0.80	1.15	0.67
query23	14.96	1.13	0.64
query24	6.79	1.70	0.60
query25	0.51	0.29	0.11
query26	0.60	0.15	0.12
query27	0.07	0.05	0.05
query28	9.23	0.80	0.44
query29	12.73	3.81	3.28
query30	3.07	2.94	3.02
query31	2.82	0.57	0.40
query32	3.24	0.55	0.49
query33	3.00	3.21	3.14
query34	16.19	5.21	4.94
query35	4.88	5.02	4.90
query36	0.71	0.54	0.51
query37	0.09	0.08	0.07
query38	0.06	0.05	0.05
query39	0.03	0.03	0.02
query40	0.17	0.14	0.13
query41	0.08	0.03	0.03
query42	0.03	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 106.76 s
Total hot run time: 32.67 s

@dataroaring dataroaring merged commit 6951299 into apache:master Aug 7, 2025
27 of 29 checks passed
freemandealer pushed a commit to freemandealer/doris that referenced this pull request Aug 7, 2025
@kaijchen @freemandealer
[fix](vcg) use "vcg cancel" as cancel message for warm up jobs (apach…
64101cd 
…e#53751)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. cloud dev/3.0.7-merged dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kaijchen @hello-stephen @doris-robot @gavinchou @dataroaring @morrySnow