Skip to content

Conversation

@zddr
Copy link
Contributor

@zddr zddr commented Jul 24, 2025

pick #50139

…ons when enabling ranger/LDAP (apache#50139)

- According to the current design of LDAP, if the user doesn't exist in
LDAP, Doris will check again to see if the user exists internally. If
there is, login will also be allowed. Therefore, creating users should
not be prohibited

pr for branch-2.1: apache#50137

doc pr: apache/doris-website#2557

# Conflicts:
#	fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/DropUserCommand.java
#	fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/CreateUserInfo.java
@zddr zddr requested a review from morrySnow as a code owner July 24, 2025 03:31
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zddr
Copy link
Contributor Author

zddr commented Jul 24, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32463 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5e3435c5c1bfe623c2435dae22a79767bcdf55f2, data reload: false

------ Round 1 ----------------------------------
q1	17600	5469	5377	5377
q2	2063	311	163	163
q3	10553	1231	768	768
q4	10229	864	464	464
q5	8322	2377	2143	2143
q6	182	159	131	131
q7	907	748	614	614
q8	9333	1424	1148	1148
q9	5246	4922	4898	4898
q10	6780	2278	1815	1815
q11	470	280	265	265
q12	348	359	213	213
q13	17763	3605	3025	3025
q14	233	226	201	201
q15	522	474	475	474
q16	430	437	377	377
q17	602	865	379	379
q18	7170	6459	6254	6254
q19	1201	960	549	549
q20	331	359	214	214
q21	2956	2206	2008	2008
q22	1036	1065	983	983
Total cold run time: 104277 ms
Total hot run time: 32463 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5513	5480	5491	5480
q2	236	340	235	235
q3	2248	2646	2290	2290
q4	1341	1776	1315	1315
q5	4432	4807	4939	4807
q6	172	160	133	133
q7	2074	1973	1871	1871
q8	2623	2793	2669	2669
q9	7259	7205	7242	7205
q10	3037	3354	2797	2797
q11	572	493	482	482
q12	631	772	618	618
q13	3447	3771	3139	3139
q14	274	302	266	266
q15	531	477	472	472
q16	434	480	435	435
q17	1248	1742	1243	1243
q18	7559	7611	7368	7368
q19	783	1023	1120	1023
q20	2008	1995	1898	1898
q21	5341	4944	4755	4755
q22	1062	1045	1007	1007
Total cold run time: 52825 ms
Total hot run time: 51508 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198053 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5e3435c5c1bfe623c2435dae22a79767bcdf55f2, data reload: false

query1	1293	915	919	915
query2	6171	1905	1888	1888
query3	10929	4442	4792	4442
query4	33048	23779	23913	23779
query5	4113	600	441	441
query6	276	184	168	168
query7	3989	483	316	316
query8	292	245	238	238
query9	9527	2579	2554	2554
query10	462	324	281	281
query11	17936	15343	15661	15343
query12	158	110	106	106
query13	1566	544	421	421
query14	9962	7233	7282	7233
query15	224	214	186	186
query16	7989	670	491	491
query17	1566	756	621	621
query18	2140	441	317	317
query19	209	185	171	171
query20	131	119	116	116
query21	210	126	109	109
query22	4803	4523	4542	4523
query23	35059	34047	34363	34047
query24	7788	2672	2750	2672
query25	535	489	424	424
query26	905	290	172	172
query27	2104	485	355	355
query28	5261	2227	2185	2185
query29	685	610	493	493
query30	249	200	163	163
query31	983	924	872	872
query32	88	63	63	63
query33	505	358	297	297
query34	716	863	512	512
query35	801	831	720	720
query36	1009	1062	978	978
query37	104	93	72	72
query38	4038	4044	4038	4038
query39	1496	1470	1445	1445
query40	204	115	101	101
query41	49	51	49	49
query42	119	104	105	104
query43	507	519	488	488
query44	1332	826	843	826
query45	188	173	174	173
query46	890	1082	702	702
query47	1997	2016	1914	1914
query48	425	416	345	345
query49	738	509	416	416
query50	705	699	431	431
query51	7419	7484	7325	7325
query52	102	98	95	95
query53	233	250	184	184
query54	547	541	487	487
query55	87	81	80	80
query56	266	261	278	261
query57	1276	1240	1212	1212
query58	244	221	229	221
query59	3255	3312	3074	3074
query60	294	291	274	274
query61	161	137	116	116
query62	805	777	709	709
query63	231	201	193	193
query64	4788	974	639	639
query65	3381	3237	3231	3231
query66	1074	413	323	323
query67	16105	15700	15506	15506
query68	8322	846	571	571
query69	495	307	268	268
query70	1180	1093	1088	1088
query71	382	291	260	260
query72	5688	3765	3894	3765
query73	637	747	358	358
query74	10614	9401	9262	9262
query75	3174	3183	2677	2677
query76	3113	1200	775	775
query77	445	369	262	262
query78	10630	10512	9606	9606
query79	3087	905	603	603
query80	627	513	431	431
query81	509	268	230	230
query82	650	121	89	89
query83	162	156	143	143
query84	243	101	79	79
query85	792	359	299	299
query86	409	323	293	293
query87	4281	4308	4263	4263
query88	4785	2414	2369	2369
query89	415	335	291	291
query90	1810	191	188	188
query91	133	132	110	110
query92	60	56	54	54
query93	1828	896	557	557
query94	690	415	291	291
query95	346	275	266	266
query96	481	606	282	282
query97	3204	3270	3171	3171
query98	218	216	199	199
query99	1585	1420	1307	1307
Total cold run time: 297737 ms
Total hot run time: 198053 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.09 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5e3435c5c1bfe623c2435dae22a79767bcdf55f2, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.07	0.07
query4	1.63	0.11	0.11
query5	0.52	0.52	0.53
query6	1.13	0.72	0.72
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.56	0.50	0.51
query10	0.55	0.55	0.57
query11	0.14	0.11	0.10
query12	0.14	0.10	0.11
query13	0.61	0.60	0.60
query14	0.77	0.78	0.82
query15	0.86	0.84	0.82
query16	0.38	0.38	0.39
query17	1.06	1.07	1.03
query18	0.24	0.23	0.23
query19	1.98	1.89	1.87
query20	0.02	0.02	0.01
query21	15.37	0.89	0.59
query22	0.74	0.73	0.60
query23	15.29	1.41	0.60
query24	3.41	0.89	1.01
query25	0.26	0.14	0.07
query26	0.27	0.15	0.14
query27	0.07	0.05	0.05
query28	13.72	1.03	0.45
query29	12.60	3.98	3.30
query30	0.24	0.08	0.06
query31	2.83	0.59	0.37
query32	3.22	0.53	0.46
query33	3.00	3.02	3.03
query34	16.60	5.23	4.62
query35	4.60	4.59	4.59
query36	0.65	0.47	0.47
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.02
query40	0.16	0.14	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 104.33 s
Total hot run time: 29.09 s

@morrySnow morrySnow changed the title branch-3.1:[enhance](auth)Remove restrictions on user creation and other operati… branch-3.1: [enhance](auth)Remove restrictions on user creation and other operations when enabling ranger/LDAP #50139 Jul 24, 2025
@morrySnow morrySnow merged commit 7a58f5c into apache:branch-3.1 Jul 24, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants