Skip to content

Conversation

@kaijchen
Copy link
Member

@kaijchen kaijchen commented Jul 24, 2025

picked from #53860

@kaijchen kaijchen requested a review from morrySnow as a code owner July 24, 2025 11:58
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@kaijchen
Copy link
Member Author

run buildall

Copy link
Contributor

@freemandealer freemandealer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.29% (12572/27761)
Line Coverage 36.19% (111935/309319)
Region Coverage 35.25% (57868/164169)
Branch Coverage 32.44% (31460/96990)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 33.33% (1/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.12% (20877/27428)
Line Coverage 69.45% (214657/309084)
Region Coverage 67.49% (128437/190302)
Branch Coverage 61.07% (66826/109426)

@doris-robot
Copy link

TPC-H: Total hot run time: 32344 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e2ee6f8b7ad411a8b529745518893230d90bb119, data reload: false

------ Round 1 ----------------------------------
q1	17581	5571	5432	5432
q2	2063	285	159	159
q3	10790	1280	743	743
q4	10524	875	446	446
q5	9459	2354	2107	2107
q6	188	163	134	134
q7	902	743	594	594
q8	9323	1454	1189	1189
q9	5249	4882	4890	4882
q10	6731	2266	1831	1831
q11	505	282	259	259
q12	337	353	209	209
q13	17784	3610	2997	2997
q14	224	231	207	207
q15	522	464	485	464
q16	424	417	373	373
q17	606	872	349	349
q18	6781	6288	6476	6288
q19	1347	959	544	544
q20	335	343	204	204
q21	2954	2142	1958	1958
q22	1056	1009	975	975
Total cold run time: 105685 ms
Total hot run time: 32344 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5583	5511	5547	5511
q2	232	330	246	246
q3	2259	2602	2342	2342
q4	1356	1796	1396	1396
q5	4445	4919	5044	4919
q6	170	165	130	130
q7	2076	1959	1841	1841
q8	2614	2825	2702	2702
q9	7231	7245	7194	7194
q10	3064	3301	2698	2698
q11	575	495	496	495
q12	645	769	624	624
q13	3485	3801	3139	3139
q14	300	307	264	264
q15	515	469	472	469
q16	435	503	430	430
q17	1220	1716	1240	1240
q18	7718	7319	7297	7297
q19	791	1057	1104	1057
q20	2027	2034	1887	1887
q21	5300	4857	4511	4511
q22	1105	1053	1007	1007
Total cold run time: 53146 ms
Total hot run time: 51399 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196873 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e2ee6f8b7ad411a8b529745518893230d90bb119, data reload: false

query1	1262	896	940	896
query2	6257	1980	1932	1932
query3	10929	4543	4458	4458
query4	32905	23658	23479	23479
query5	3700	610	467	467
query6	302	194	183	183
query7	3981	483	325	325
query8	293	248	247	247
query9	9417	2608	2587	2587
query10	472	323	259	259
query11	18222	15437	15209	15209
query12	152	114	105	105
query13	1559	554	391	391
query14	9535	7047	7483	7047
query15	210	195	190	190
query16	7949	628	408	408
query17	1579	764	617	617
query18	2087	407	314	314
query19	237	186	174	174
query20	127	118	116	116
query21	205	131	107	107
query22	4505	4500	4400	4400
query23	35031	34897	33833	33833
query24	7535	2675	2708	2675
query25	510	488	438	438
query26	973	289	175	175
query27	2180	477	349	349
query28	5522	2240	2176	2176
query29	683	598	461	461
query30	245	191	160	160
query31	1029	930	837	837
query32	71	61	58	58
query33	495	391	328	328
query34	747	855	543	543
query35	767	810	735	735
query36	1032	1073	948	948
query37	103	97	71	71
query38	4034	4044	4005	4005
query39	1530	1479	1473	1473
query40	205	110	100	100
query41	46	45	47	45
query42	118	104	103	103
query43	508	532	494	494
query44	1298	808	802	802
query45	187	176	176	176
query46	883	1072	668	668
query47	1954	1997	1939	1939
query48	407	424	342	342
query49	751	488	399	399
query50	682	717	449	449
query51	7404	7324	7327	7324
query52	105	100	91	91
query53	231	252	185	185
query54	543	554	466	466
query55	83	84	80	80
query56	281	273	260	260
query57	1297	1272	1227	1227
query58	243	218	221	218
query59	3167	3225	2966	2966
query60	304	280	274	274
query61	155	116	143	116
query62	816	737	690	690
query63	242	196	195	195
query64	3764	1020	672	672
query65	3360	3296	3286	3286
query66	1044	429	306	306
query67	15940	15724	15453	15453
query68	7071	820	526	526
query69	507	310	268	268
query70	1164	1139	1083	1083
query71	395	297	258	258
query72	5957	3787	3851	3787
query73	630	730	347	347
query74	10407	9333	9250	9250
query75	3190	3158	2664	2664
query76	3094	1186	762	762
query77	513	369	272	272
query78	10414	10521	9610	9610
query79	3957	842	585	585
query80	727	523	434	434
query81	507	267	228	228
query82	671	113	89	89
query83	161	160	141	141
query84	249	106	84	84
query85	788	370	307	307
query86	413	310	304	304
query87	4315	4336	4244	4244
query88	4918	2389	2389	2389
query89	426	340	290	290
query90	1761	192	189	189
query91	139	145	112	112
query92	64	56	51	51
query93	2606	925	534	534
query94	694	404	302	302
query95	337	273	269	269
query96	477	600	283	283
query97	3186	3266	3160	3160
query98	225	210	213	210
query99	1320	1399	1339	1339
Total cold run time: 295673 ms
Total hot run time: 196873 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.5 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e2ee6f8b7ad411a8b529745518893230d90bb119, data reload: false

query1	0.04	0.03	0.02
query2	0.08	0.03	0.03
query3	0.24	0.07	0.07
query4	1.61	0.11	0.10
query5	0.54	0.53	0.51
query6	1.15	0.73	0.72
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.55	0.49	0.52
query10	0.55	0.55	0.57
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.60	0.58	0.59
query14	0.77	0.80	0.80
query15	0.84	0.82	0.80
query16	0.39	0.38	0.38
query17	1.02	1.04	1.01
query18	0.23	0.22	0.21
query19	1.80	1.90	1.87
query20	0.01	0.01	0.01
query21	15.42	0.96	0.57
query22	0.73	0.68	0.56
query23	15.29	1.40	0.51
query24	2.96	1.70	1.64
query25	0.19	0.14	0.15
query26	0.18	0.15	0.13
query27	0.06	0.04	0.05
query28	14.45	0.97	0.42
query29	12.61	3.99	3.35
query30	0.24	0.08	0.06
query31	2.82	0.59	0.38
query32	3.22	0.54	0.46
query33	2.96	3.00	3.00
query34	16.55	5.21	4.49
query35	4.61	4.57	4.61
query36	0.63	0.49	0.47
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.14	0.12
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.16 s
Total hot run time: 29.5 s

@morrySnow morrySnow changed the title [fix](warmup) fix warm up jobs missing last batch (#53860) branch-3.1: [fix](warmup) fix warm up jobs missing last batch #53860 Jul 25, 2025
@morrySnow morrySnow merged commit 7e7230c into apache:branch-3.1 Jul 25, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants