Skip to content

[fix](cloud) Fix std::sleep_for in bthread sync_rowset #53925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jul 28, 2025
Merged

[fix](cloud) Fix std::sleep_for in bthread sync_rowset #53925

dataroaring merged 1 commit into from
Jul 28, 2025

Conversation

@gavinchou
Copy link
Contributor

@gavinchou gavinchou commented Jul 25, 2025

No description provided.

@gavinchou gavinchou requested a review from dataroaring as a code owner July 25, 2025 17:01
@Thearas
Copy link
Contributor

Thearas commented Jul 25, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring
Copy link
Contributor

dataroaring commented Jul 25, 2025

run buildall

1 similar comment
@gavinchou
Copy link
Contributor Author

gavinchou commented Jul 25, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 25, 2025

TPC-H: Total hot run time: 33435 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b4e33e7e566b1ad66eeb3a74396a89ea79ae1d71, data reload: false

------ Round 1 ----------------------------------
q1	17571	5468	5104	5104
q2	1926	274	186	186
q3	10313	1260	687	687
q4	10258	959	503	503
q5	7522	2381	2194	2194
q6	179	162	131	131
q7	884	763	600	600
q8	9283	1296	1123	1123
q9	6826	5083	5094	5083
q10	6902	2344	1959	1959
q11	462	290	275	275
q12	343	372	220	220
q13	17785	3435	3022	3022
q14	225	232	227	227
q15	515	475	459	459
q16	425	428	382	382
q17	581	827	376	376
q18	7406	7149	6931	6931
q19	1233	956	523	523
q20	334	330	221	221
q21	3388	2401	2248	2248
q22	1076	1081	981	981
Total cold run time: 105437 ms
Total hot run time: 33435 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5327	5356	5303	5303
q2	235	306	207	207
q3	2068	2545	2232	2232
q4	1300	1675	1331	1331
q5	4113	4197	4484	4197
q6	239	181	130	130
q7	2026	1953	1795	1795
q8	2548	2621	2438	2438
q9	7627	7139	7166	7139
q10	3141	3329	2923	2923
q11	567	543	497	497
q12	689	737	608	608
q13	3537	3700	3234	3234
q14	293	310	297	297
q15	489	462	479	462
q16	468	553	449	449
q17	1184	1418	1416	1416
q18	9211	7734	7607	7607
q19	9657	969	1061	969
q20	2024	1985	1955	1955
q21	13208	4290	4141	4141
q22	1063	1027	1013	1013
Total cold run time: 71014 ms
Total hot run time: 50343 ms

@doris-robot
Copy link

doris-robot commented Jul 25, 2025

TPC-DS: Total hot run time: 172441 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b4e33e7e566b1ad66eeb3a74396a89ea79ae1d71, data reload: false

============================================
query1	986	401	399	399
query2	6527	1828	1684	1684
query3	6743	236	224	224
query4	26762	23440	23205	23205
query5	4343	615	524	524
query6	325	253	236	236
query7	4625	516	300	300
query8	273	253	222	222
query9	8559	2985	2970	2970
query10	451	339	297	297
query11	15443	14944	14766	14766
query12	181	140	132	132
query13	1674	547	427	427
query14	8754	5929	5918	5918
query15	225	193	176	176
query16	7813	660	455	455
query17	1620	778	639	639
query18	2101	438	330	330
query19	296	211	189	189
query20	148	148	134	134
query21	222	128	109	109
query22	4036	4090	4182	4090
query23	34600	33926	33991	33926
query24	8009	2414	2417	2414
query25	582	511	446	446
query26	932	294	170	170
query27	2630	504	352	352
query28	4248	2283	2277	2277
query29	716	607	505	505
query30	302	231	197	197
query31	903	781	712	712
query32	86	75	75	75
query33	569	402	384	384
query34	820	842	518	518
query35	826	834	757	757
query36	1024	1037	939	939
query37	137	112	89	89
query38	4069	4074	3970	3970
query39	1458	1409	1381	1381
query40	243	142	135	135
query41	65	62	54	54
query42	149	128	129	128
query43	512	523	479	479
query44	1422	875	877	875
query45	195	192	184	184
query46	920	1050	661	661
query47	1798	1842	1762	1762
query48	408	431	318	318
query49	671	505	440	440
query50	669	678	427	427
query51	5386	5455	5538	5455
query52	137	125	119	119
query53	253	287	212	212
query54	668	662	575	575
query55	94	91	98	91
query56	362	365	353	353
query57	1214	1213	1135	1135
query58	338	353	331	331
query59	2545	2676	2507	2507
query60	409	412	376	376
query61	144	123	122	122
query62	835	723	669	669
query63	252	221	213	213
query64	3652	1076	743	743
query65	4172	4108	4132	4108
query66	898	474	361	361
query67	query68	17362	964	1231	964
query69	1013	274	281	274
query70	1412	1097	1142	1097
query71	700	347	348	347
query72	9120	2273	2371	2273
query73	3366	631	357	357
query74	8998	8969	8846	8846
query75	7364	3162	2712	2712
query76	8671	1218	793	793
query77	1168	490	334	334
query78	9573	11349	9714	9714
query79	14989	641	590	590
query80	1504	572	486	486
query81	535	269	234	234
query82	456	152	116	116
query83	372	286	268	268
query84	292	105	81	81
query85	838	448	335	335
query86	373	333	281	281
query87	4357	4299	4326	4299
query88	5457	2282	2287	2282
query89	493	371	324	324
query90	2486	226	227	226
query91	140	135	112	112
query92	91	75	71	71
query93	6379	963	652	652
query94	1016	393	275	275
query95	426	334	316	316
query96	516	594	290	290
query97	2717	2800	2624	2624
query98	252	240	226	226
query99	1491	1432	1271	1271
Total cold run time: 306356 ms
Total hot run time: 172441 ms

@doris-robot
Copy link

doris-robot commented Jul 25, 2025

ClickBench: Total hot run time: 33.35 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b4e33e7e566b1ad66eeb3a74396a89ea79ae1d71, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.24	0.07	0.08
query4	1.61	0.11	0.11
query5	0.41	0.44	0.44
query6	1.18	0.68	0.69
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.56	0.49	0.46
query10	0.54	0.54	0.51
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.65	0.64	0.66
query14	0.90	1.19	0.98
query15	0.91	0.88	0.90
query16	0.38	0.38	0.38
query17	1.07	1.03	1.07
query18	0.22	0.21	0.20
query19	1.92	1.81	1.89
query20	0.01	0.01	0.01
query21	15.39	0.81	0.53
query22	0.79	1.10	0.71
query23	14.93	1.16	0.61
query24	6.67	1.65	1.18
query25	0.58	0.17	0.07
query26	0.60	0.16	0.14
query27	0.06	0.05	0.05
query28	10.68	0.84	0.43
query29	12.56	3.84	3.34
query30	3.00	2.97	2.93
query31	2.81	0.56	0.38
query32	3.23	0.59	0.50
query33	2.98	3.23	3.22
query34	16.13	5.31	4.96
query35	4.90	4.89	4.94
query36	0.69	0.52	0.49
query37	0.09	0.08	0.07
query38	0.05	0.06	0.04
query39	0.03	0.03	0.03
query40	0.18	0.15	0.14
query41	0.08	0.03	0.03
query42	0.03	0.02	0.03
query43	0.05	0.04	0.04
Total cold run time: 107.6 s
Total hot run time: 33.35 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 25, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.57% (15942/27691)
Line Coverage 46.35% (143336/309216)
Region Coverage 35.79% (107989/301766)
Branch Coverage 38.31% (47655/124406)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 25, 2025

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.13% (22054/27185)
Line Coverage 73.77% (227799/308792)
Region Coverage 61.37% (189940/309518)
Branch Coverage 65.15% (81973/125814)

@dataroaring
Copy link
Contributor

dataroaring commented Jul 26, 2025

run check_coverage

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 26, 2025

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.13% (22054/27185)
Line Coverage 73.77% (227799/308792)
Region Coverage 61.37% (189940/309518)
Branch Coverage 65.15% (81973/125814)

1 similar comment
@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 26, 2025

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.13% (22054/27185)
Line Coverage 73.77% (227799/308792)
Region Coverage 61.37% (189940/309518)
Branch Coverage 65.15% (81973/125814)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2025

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit fe48611 into apache:master Jul 28, 2025
33 of 35 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 28, 2025
@gavinchou
[fix](cloud) Fix std::sleep_for in bthread sync_rowset (#53925)
99531f4
@github-actions github-actions bot mentioned this pull request Jul 28, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jul 28, 2025
@gavinchou
[fix](cloud) Fix std::sleep_for in bthread sync_rowset (#53925)
1fff4f6
@github-actions github-actions bot mentioned this pull request Jul 28, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jul 29, 2025
@github-actions @gavinchou
branch-3.1: [fix](cloud) Fix std::sleep_for in bthread sync_rowset #5…
9e67559 
…3925 (#53954)

Cherry-picked from #53925

Co-authored-by: Gavin Chou <gavin@selectdb.com>
dataroaring pushed a commit that referenced this pull request Aug 1, 2025
@github-actions @gavinchou
branch-3.0: [fix](cloud) Fix std::sleep_for in bthread sync_rowset #5…
c577d2e 
…3925 (#53953)

Cherry-picked from #53925

Co-authored-by: Gavin Chou <gavin@selectdb.com>
zhiqiang-hhhh pushed a commit to zhiqiang-hhhh/doris that referenced this pull request Aug 4, 2025
@gavinchou @zhiqiang-hhhh
[fix](cloud) Fix std::sleep_for in bthread sync_rowset (apache#53925)
d19e050
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@hello-stephen hello-stephen hello-stephen approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. cloud dev/3.0.7-merged dev/3.1.0-merged p0_b reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gavinchou @Thearas @dataroaring @doris-robot @hello-stephen @yiguolei @morrySnow