Skip to content

[fix](schema-change) Rebuild distribution info should update default distribution info #54072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jul 30, 2025
Merged

[fix](schema-change) Rebuild distribution info should update default distribution info #54072

dataroaring merged 1 commit into from
Jul 30, 2025

Conversation

@Hastyshell
Copy link
Collaborator

@Hastyshell Hastyshell commented Jul 30, 2025

What problem does this PR solve?

Related PR: #54024

Problem Summary:

As title.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 30, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Jul 30, 2025

run buildall

This was referenced Jul 30, 2025
Closed
Closed
@doris-robot
Copy link

doris-robot commented Jul 30, 2025

TPC-H: Total hot run time: 34139 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4ab3b23d35f055282ef7fb5fab88396056241f45, data reload: false

------ Round 1 ----------------------------------
q1	17674	5673	5548	5548
q2	1950	304	194	194
q3	10270	1335	719	719
q4	10218	986	527	527
q5	7505	2236	2333	2236
q6	179	165	131	131
q7	891	760	621	621
q8	9301	1360	1134	1134
q9	6779	5149	5155	5149
q10	6899	2385	1973	1973
q11	475	289	281	281
q12	358	373	224	224
q13	17798	3476	2962	2962
q14	231	251	212	212
q15	528	471	469	469
q16	415	432	372	372
q17	547	851	353	353
q18	7374	6995	7028	6995
q19	1637	978	535	535
q20	322	314	212	212
q21	3393	2525	2279	2279
q22	1005	1053	1013	1013
Total cold run time: 105749 ms
Total hot run time: 34139 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5957	5841	5860	5841
q2	236	309	212	212
q3	2102	2627	2195	2195
q4	1315	1705	1340	1340
q5	4148	4474	4466	4466
q6	221	175	132	132
q7	2048	1911	1687	1687
q8	2732	2600	2455	2455
q9	7333	7187	7495	7187
q10	3132	3322	2862	2862
q11	544	505	500	500
q12	708	813	665	665
q13	3440	3730	3224	3224
q14	289	305	306	305
q15	493	454	437	437
q16	448	644	503	503
q17	1163	1418	1352	1352
q18	7908	7876	7692	7692
q19	11434	949	940	940
q20	2071	2062	1918	1918
q21	15224	4345	4225	4225
q22	1024	1006	981	981
Total cold run time: 73970 ms
Total hot run time: 51119 ms

@doris-robot
Copy link

doris-robot commented Jul 30, 2025

TPC-DS: Total hot run time: 173706 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4ab3b23d35f055282ef7fb5fab88396056241f45, data reload: false

============================================
query1	1027	408	439	408
query2	6527	1945	1650	1650
query3	6744	228	222	222
query4	26937	23365	23175	23175
query5	4375	626	526	526
query6	336	234	227	227
query7	4639	519	299	299
query8	286	239	230	230
query9	8563	3165	3143	3143
query10	445	330	291	291
query11	15727	15374	14780	14780
query12	187	139	130	130
query13	1654	554	436	436
query14	9561	7781	7867	7781
query15	217	198	172	172
query16	7141	674	477	477
query17	1217	783	642	642
query18	1998	438	329	329
query19	224	242	178	178
query20	145	152	148	148
query21	214	128	106	106
query22	3903	3967	3830	3830
query23	34483	33982	34221	33982
query24	5192	2415	2448	2415
query25	493	525	444	444
query26	719	303	163	163
query27	2192	509	377	377
query28	3122	2284	2270	2270
query29	650	602	503	503
query30	288	241	214	214
query31	859	783	705	705
query32	91	75	83	75
query33	521	426	368	368
query34	802	851	520	520
query35	837	829	749	749
query36	1035	1025	967	967
query37	143	113	96	96
query38	4042	4028	3974	3974
query39	1439	1386	1368	1368
query40	239	140	136	136
query41	61	64	58	58
query42	141	127	132	127
query43	493	507	472	472
query44	1407	886	879	879
query45	204	189	190	189
query46	933	1060	669	669
query47	1805	1829	1764	1764
query48	392	421	320	320
query49	698	530	430	430
query50	677	687	425	425
query51	5492	5626	5481	5481
query52	129	135	118	118
query53	264	297	208	208
query54	642	655	565	565
query55	96	89	87	87
query56	364	358	357	357
query57	1214	1228	1133	1133
query58	350	334	336	334
query59	2543	2581	2502	2502
query60	421	411	408	408
query61	148	145	149	145
query62	778	743	662	662
query63	255	220	217	217
query64	2503	1099	778	778
query65	4226	4068	4095	4068
query66	1063	454	377	377
query67	query68	17043	882	991	882
query69	1030	272	293	272
query70	1378	1141	1158	1141
query71	730	325	333	325
query72	9178	2336	2129	2129
query73	3480	687	361	361
query74	8930	9102	8920	8920
query75	7638	3175	2686	2686
query76	8871	1219	793	793
query77	1146	406	377	377
query78	9665	10790	9375	9375
query79	15458	583	597	583
query80	2351	592	487	487
query81	536	261	235	235
query82	528	149	119	119
query83	351	281	270	270
query84	302	92	78	78
query85	953	382	324	324
query86	361	329	297	297
query87	4262	4231	4186	4186
query88	5518	2223	2269	2223
query89	496	364	328	328
query90	2494	227	223	223
query91	140	138	110	110
query92	83	71	65	65
query93	6462	1013	659	659
query94	1105	393	283	283
query95	425	324	316	316
query96	497	589	280	280
query97	2670	2751	2619	2619
query98	268	234	237	234
query99	1469	1414	1247	1247
Total cold run time: 302331 ms
Total hot run time: 173706 ms

@doris-robot
Copy link

doris-robot commented Jul 30, 2025

ClickBench: Total hot run time: 33.27 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4ab3b23d35f055282ef7fb5fab88396056241f45, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.24	0.07	0.08
query4	1.62	0.10	0.11
query5	0.42	0.42	0.47
query6	1.17	0.69	0.68
query7	0.03	0.02	0.02
query8	0.05	0.03	0.03
query9	0.58	0.47	0.46
query10	0.53	0.53	0.53
query11	0.16	0.10	0.10
query12	0.14	0.11	0.11
query13	0.64	0.65	0.66
query14	0.94	1.25	0.92
query15	0.94	0.89	0.88
query16	0.39	0.41	0.39
query17	1.08	1.02	1.07
query18	0.21	0.20	0.20
query19	2.00	1.98	1.92
query20	0.01	0.01	0.01
query21	15.36	0.85	0.56
query22	0.76	1.12	0.70
query23	14.97	1.13	0.66
query24	6.74	0.92	0.94
query25	0.51	0.29	0.12
query26	0.69	0.15	0.13
query27	0.05	0.05	0.06
query28	10.50	0.88	0.45
query29	12.64	3.81	3.31
query30	2.98	3.08	2.97
query31	2.82	0.55	0.39
query32	3.26	0.56	0.50
query33	3.01	3.22	3.18
query34	15.93	5.36	4.96
query35	4.99	4.97	4.94
query36	0.68	0.51	0.50
query37	0.09	0.08	0.07
query38	0.06	0.05	0.04
query39	0.04	0.03	0.03
query40	0.17	0.15	0.13
query41	0.08	0.04	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.04
Total cold run time: 107.68 s
Total hot run time: 33.27 s

dataroaring
dataroaring approved these changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2025

PR approved by anyone and no changes requested.

This was referenced Jul 30, 2025
Merged
Merged
Merged
@dataroaring dataroaring merged commit 488b291 into apache:master Jul 30, 2025
31 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 30, 2025
@Hastyshell
[fix](schema-change) Rebuild distribution info should update default …
56b3e14 
…distribution info (#54072)

### What problem does this PR solve?

Related PR: #54024
@github-actions github-actions bot mentioned this pull request Jul 30, 2025
Closed
github-actions bot pushed a commit that referenced this pull request Jul 30, 2025
@Hastyshell
[fix](schema-change) Rebuild distribution info should update default …
7d684fe 
…distribution info (#54072)

### What problem does this PR solve?

Related PR: #54024
@github-actions github-actions bot mentioned this pull request Jul 30, 2025
Closed
dataroaring pushed a commit that referenced this pull request Jul 30, 2025
@Hastyshell
[fix](schema-change) Rebuild distribution info according to original …
6bb8596 
…order (#54024) (#54072) (#54109)

### What problem does this PR solve?

cherry-pick: #54024 #54072
morrySnow pushed a commit that referenced this pull request Jul 31, 2025
@Hastyshell
branch-3.1: [fix](schema-change) Rebuild distribution info according …
fc0bbd0 
…to original order #54024 #54072 (#54110)

Cherry-pick: #54024 #54072
yiguolei pushed a commit that referenced this pull request Aug 1, 2025
@Hastyshell
[fix](schema-change) Rebuild distribution info according to original …
c9e1435 
…order (#54024) (#54072) (#54111)

### What problem does this PR solve?

Cherry-pick: #54024 #54072

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@bobhan1 bobhan1 mentioned this pull request Aug 5, 2025
Merged
16 tasks
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Aug 8, 2025
@Hastyshell
[fix](schema-change) Rebuild distribution info according to original …
61a20a1 
…order apache#54024 apache#54072  (apache#4233)

pick: 
apache#54024
apache#54072
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
@gavinchou gavinchou mentioned this pull request Sep 1, 2025
Open
Gabriel39 pushed a commit to Gabriel39/incubator-doris that referenced this pull request Sep 25, 2025
@Hastyshell
[fix](schema-change) Rebuild distribution info according to original …
7a1429b 
…order apache#54024 apache#54072 (apache#4231)

pick: 
apache#54024
apache#54072
deardeng pushed a commit to deardeng/incubator-doris that referenced this pull request Dec 19, 2025
@Hastyshell
[fix](schema-change) Rebuild distribution info according to original …
f37a834 
…order (apache#54024) (apache#54072) (apache#54109) (apache#380)

### What problem does this PR solve?

cherry-pick: apache#54024 apache#54072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.11-merged dev/3.0.7-merged dev/3.1.0-merged p0_w reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Hastyshell @hello-stephen @doris-robot @gavinchou @dataroaring @yiguolei @morrySnow