Skip to content

Conversation

@deardeng
Copy link
Contributor

…scheduling time errors #51647 (#51687)"

This reverts commit 75d29d8.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@deardeng deardeng requested a review from dataroaring as a code owner July 30, 2025 03:29
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@deardeng
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39391 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4d222fa86c9689b48094acfdd1dc04dc52439c37, data reload: false

------ Round 1 ----------------------------------
q1	17591	7296	6543	6543
q2	2079	179	159	159
q3	10656	1151	1148	1148
q4	10467	700	703	700
q5	7744	2858	2862	2858
q6	216	133	128	128
q7	966	607	602	602
q8	9593	1931	1983	1931
q9	7974	6363	6414	6363
q10	6995	2235	2259	2235
q11	460	255	268	255
q12	396	213	207	207
q13	17778	2969	2960	2960
q14	226	211	200	200
q15	512	459	471	459
q16	507	376	372	372
q17	967	565	569	565
q18	7103	6741	6661	6661
q19	1396	1115	931	931
q20	470	195	201	195
q21	4245	3147	2949	2949
q22	1114	1014	970	970
Total cold run time: 109455 ms
Total hot run time: 39391 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6632	6553	6524	6524
q2	324	225	232	225
q3	2943	2925	2903	2903
q4	2056	1843	1776	1776
q5	5658	5719	5734	5719
q6	211	132	127	127
q7	2178	1821	1781	1781
q8	3337	3582	3462	3462
q9	8772	8830	8824	8824
q10	3538	3509	3522	3509
q11	594	479	479	479
q12	769	587	599	587
q13	6294	3205	3145	3145
q14	321	262	272	262
q15	516	479	464	464
q16	498	440	426	426
q17	1814	1637	1610	1610
q18	8207	7691	7736	7691
q19	1703	1506	1525	1506
q20	2085	1830	1868	1830
q21	5064	4984	5042	4984
q22	1110	1120	1020	1020
Total cold run time: 64624 ms
Total hot run time: 58854 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197153 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4d222fa86c9689b48094acfdd1dc04dc52439c37, data reload: false

query1	1254	912	930	912
query2	6364	1879	1821	1821
query3	10925	4326	4600	4326
query4	33078	23686	23659	23659
query5	3561	429	433	429
query6	272	178	183	178
query7	4004	306	314	306
query8	288	221	219	219
query9	9510	2566	2574	2566
query10	480	261	245	245
query11	18302	15184	15288	15184
query12	165	100	102	100
query13	1552	428	417	417
query14	10367	7237	7339	7237
query15	255	170	196	170
query16	8020	493	498	493
query17	1584	592	566	566
query18	2190	324	327	324
query19	317	161	158	158
query20	125	116	115	115
query21	208	114	111	111
query22	4670	4390	4404	4390
query23	35077	34244	34136	34136
query24	11237	2978	2954	2954
query25	624	447	419	419
query26	751	176	171	171
query27	2343	370	363	363
query28	6392	2152	2136	2136
query29	792	459	448	448
query30	280	166	162	162
query31	1043	792	828	792
query32	96	60	57	57
query33	806	331	314	314
query34	956	517	512	512
query35	894	753	739	739
query36	1130	931	955	931
query37	119	68	69	68
query38	4146	3954	3943	3943
query39	1561	1466	1471	1466
query40	203	101	103	101
query41	52	76	47	47
query42	113	104	108	104
query43	530	482	480	480
query44	1246	822	814	814
query45	194	168	167	167
query46	1162	768	743	743
query47	2014	1886	1892	1886
query48	500	390	386	386
query49	889	387	375	375
query50	830	441	440	440
query51	7427	7214	7123	7123
query52	102	89	91	89
query53	269	191	190	190
query54	1188	476	484	476
query55	78	75	80	75
query56	268	243	256	243
query57	1298	1203	1173	1173
query58	228	215	210	210
query59	3185	2999	2967	2967
query60	283	254	266	254
query61	121	123	116	116
query62	881	718	690	690
query63	249	208	197	197
query64	3994	659	629	629
query65	3416	3312	3319	3312
query66	837	297	300	297
query67	16206	15516	15611	15516
query68	4371	572	584	572
query69	433	265	260	260
query70	1195	1094	1044	1044
query71	343	256	245	245
query72	6304	4077	3962	3962
query73	793	349	360	349
query74	10570	9180	9248	9180
query75	3449	2662	2696	2662
query76	2725	1120	1042	1042
query77	405	267	285	267
query78	10632	9723	9523	9523
query79	2531	622	620	620
query80	1199	434	436	434
query81	554	223	224	223
query82	672	86	86	86
query83	232	143	141	141
query84	238	77	76	76
query85	1509	309	275	275
query86	491	288	283	283
query87	4437	4333	4257	4257
query88	4216	2367	2386	2367
query89	412	292	290	290
query90	1906	183	183	183
query91	188	151	147	147
query92	66	48	51	48
query93	2339	561	545	545
query94	764	297	301	297
query95	361	251	251	251
query96	624	291	287	287
query97	3306	3105	3113	3105
query98	223	201	195	195
query99	1519	1321	1300	1300
Total cold run time: 302508 ms
Total hot run time: 197153 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.46 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4d222fa86c9689b48094acfdd1dc04dc52439c37, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.06
query4	1.63	0.10	0.10
query5	0.52	0.52	0.52
query6	1.15	0.74	0.73
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.56	0.51	0.48
query10	0.58	0.56	0.55
query11	0.14	0.09	0.10
query12	0.13	0.11	0.10
query13	0.62	0.59	0.60
query14	0.77	0.78	0.79
query15	0.85	0.82	0.81
query16	0.36	0.36	0.39
query17	1.09	1.05	1.05
query18	0.24	0.21	0.22
query19	1.98	1.78	1.74
query20	0.01	0.02	0.01
query21	15.40	0.59	0.58
query22	2.37	1.84	2.08
query23	16.90	1.06	0.75
query24	3.07	1.49	1.69
query25	0.13	0.06	0.21
query26	0.62	0.13	0.14
query27	0.04	0.04	0.04
query28	9.32	0.54	0.49
query29	12.58	3.17	3.17
query30	0.24	0.06	0.07
query31	2.84	0.39	0.38
query32	3.25	0.46	0.45
query33	2.95	3.04	2.93
query34	16.99	4.51	4.58
query35	4.58	4.52	4.55
query36	0.69	0.48	0.47
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.03	0.02
query40	0.16	0.13	0.12
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.5 s
Total hot run time: 30.46 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.90% (11136/26580)
Line Coverage 32.43% (95405/294178)
Region Coverage 31.56% (49263/156114)
Branch Coverage 27.99% (25241/90186)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 967df47 into apache:branch-3.0 Jul 31, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants