Skip to content

Conversation

@zhiqiang-hhhh
Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh commented Aug 5, 2025

What problem does this PR solve?

Tablet schema that contains virtual column should not be added into SchemaCache.

Related PR: #52701

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Aug 5, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhiqiang-hhhh zhiqiang-hhhh force-pushed the fix-virtual-slot-schema-cache branch from 724e104 to 6222fbe Compare August 5, 2025 06:30
@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

1 similar comment
@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@zhiqiang-hhhh
Copy link
Contributor Author

run performance

@doris-robot
Copy link

TPC-H: Total hot run time: 33505 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6222fbef0727ef5edbe08e602442fd8ba130b742, data reload: false

------ Round 1 ----------------------------------
q1	17573	5231	5118	5118
q2	1933	306	191	191
q3	10329	1452	711	711
q4	10232	997	500	500
q5	7520	2349	2287	2287
q6	182	167	134	134
q7	893	768	602	602
q8	9295	1218	1089	1089
q9	6676	5025	5060	5025
q10	6888	2344	1951	1951
q11	450	283	270	270
q12	346	360	224	224
q13	17798	3452	3000	3000
q14	238	230	220	220
q15	508	458	465	458
q16	432	441	376	376
q17	562	803	361	361
q18	7491	6981	7115	6981
q19	2024	973	542	542
q20	317	309	210	210
q21	3408	3056	2248	2248
q22	1078	1060	1007	1007
Total cold run time: 106173 ms
Total hot run time: 33505 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5432	5361	5332	5332
q2	236	309	221	221
q3	2103	2539	2187	2187
q4	1301	1685	1324	1324
q5	4128	4337	4267	4267
q6	224	181	134	134
q7	1975	1884	1821	1821
q8	2508	2438	2446	2438
q9	7212	7075	7380	7075
q10	3231	3271	2939	2939
q11	594	519	529	519
q12	711	756	628	628
q13	3432	3700	3279	3279
q14	302	305	308	305
q15	485	453	443	443
q16	455	493	460	460
q17	1163	1444	1323	1323
q18	8184	7506	7870	7506
q19	12603	909	956	909
q20	1840	1906	1794	1794
q21	14940	4274	4274	4274
q22	1093	1018	984	984
Total cold run time: 74152 ms
Total hot run time: 50162 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 170708 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6222fbef0727ef5edbe08e602442fd8ba130b742, data reload: false

============================================
query1	1001	456	390	390
query2	6513	1823	1669	1669
query3	6734	226	222	222
query4	27155	24209	23123	23123
query5	4311	629	511	511
query6	328	239	240	239
query7	4640	521	301	301
query8	298	247	237	237
query9	8603	2986	2945	2945
query10	491	323	300	300
query11	15859	14947	14679	14679
query12	184	140	135	135
query13	1680	598	421	421
query14	9569	6038	5999	5999
query15	209	195	174	174
query16	7799	656	468	468
query17	1466	798	646	646
query18	2057	464	329	329
query19	235	213	189	189
query20	160	145	145	145
query21	225	134	121	121
query22	4033	4152	3833	3833
query23	34312	34320	34032	34032
query24	6836	2412	2438	2412
query25	506	509	458	458
query26	723	290	163	163
query27	1814	477	361	361
query28	2661	2355	2384	2355
query29	628	606	502	502
query30	293	236	200	200
query31	883	792	701	701
query32	97	82	81	81
query33	557	410	374	374
query34	824	845	532	532
query35	808	890	754	754
query36	1014	1061	958	958
query37	138	113	89	89
query38	3970	3966	4021	3966
query39	1448	1423	1390	1390
query40	234	145	133	133
query41	61	60	59	59
query42	144	131	130	130
query43	507	499	478	478
query44	1442	876	880	876
query45	201	204	188	188
query46	951	1074	682	682
query47	1764	1838	1803	1803
query48	397	428	323	323
query49	682	508	432	432
query50	655	690	417	417
query51	4188	4189	4126	4126
query52	133	141	116	116
query53	258	287	215	215
query54	661	656	561	561
query55	92	91	96	91
query56	360	363	352	352
query57	1172	1195	1138	1138
query58	346	327	341	327
query59	2685	2724	2544	2544
query60	418	397	384	384
query61	128	142	126	126
query62	732	737	654	654
query63	255	212	220	212
query64	2530	1118	764	764
query65	4279	4148	4176	4148
query66	925	462	323	323
query67	query68	19455	880	605	605
query69	1014	334	289	289
query70	1418	1131	1113	1113
query71	734	358	321	321
query72	9184	2360	2376	2360
query73	3567	647	358	358
query74	9064	8947	8794	8794
query75	7851	3140	2666	2666
query76	8905	1223	802	802
query77	1142	421	377	377
query78	9571	11373	9777	9777
query79	14537	653	579	579
query80	2002	554	489	489
query81	576	251	237	237
query82	432	157	118	118
query83	412	293	269	269
query84	305	111	90	90
query85	923	378	390	378
query86	375	298	314	298
query87	4146	4206	4092	4092
query88	5188	2268	2272	2268
query89	489	374	320	320
query90	2678	236	244	236
query91	145	140	115	115
query92	94	78	66	66
query93	6304	1027	669	669
query94	1020	396	289	289
query95	407	333	327	327
query96	516	597	282	282
query97	2685	2717	2605	2605
query98	253	248	229	229
query99	1485	1418	1284	1284
Total cold run time: 304139 ms
Total hot run time: 170708 ms

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 58.19% (16342/28085)
Line Coverage 47.08% (147582/313439)
Region Coverage 36.07% (110458/306249)
Branch Coverage 38.94% (49013/125877)

@doris-robot
Copy link

ClickBench: Total hot run time: 34 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6222fbef0727ef5edbe08e602442fd8ba130b742, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.24	0.07	0.07
query4	1.61	0.11	0.11
query5	0.40	0.40	0.45
query6	1.18	0.65	0.64
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.56	0.47	0.48
query10	0.53	0.54	0.54
query11	0.16	0.11	0.11
query12	0.15	0.11	0.12
query13	0.66	0.62	0.64
query14	0.94	1.08	1.08
query15	0.94	0.89	0.88
query16	0.39	0.39	0.38
query17	1.07	1.13	1.10
query18	0.23	0.21	0.20
query19	1.96	1.79	1.88
query20	0.02	0.01	0.01
query21	15.37	0.84	0.54
query22	0.77	1.19	0.79
query23	14.75	1.16	0.64
query24	6.57	1.62	1.59
query25	0.54	0.25	0.15
query26	0.53	0.15	0.13
query27	0.06	0.05	0.06
query28	10.00	0.89	0.44
query29	12.82	3.81	3.34
query30	3.02	2.96	2.93
query31	2.81	0.58	0.40
query32	3.26	0.55	0.50
query33	3.06	3.19	3.19
query34	15.90	5.28	4.91
query35	4.90	4.91	4.90
query36	0.71	0.51	0.49
query37	0.11	0.08	0.08
query38	0.06	0.04	0.04
query39	0.03	0.03	0.03
query40	0.17	0.14	0.13
query41	0.09	0.03	0.03
query42	0.04	0.04	0.03
query43	0.04	0.03	0.02
Total cold run time: 106.85 s
Total hot run time: 34 s

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.17% (22380/27572)
Line Coverage 73.89% (231563/313405)
Region Coverage 61.31% (192812/314474)
Branch Coverage 65.21% (83093/127419)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

PR approved by anyone and no changes requested.

Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airborne12 airborne12 merged commit a20d8a6 into apache:master Aug 18, 2025
27 of 30 checks passed
@zhiqiang-hhhh zhiqiang-hhhh deleted the fix-virtual-slot-schema-cache branch August 18, 2025 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants