Skip to content

branch-3.1: [fix](case) remove global variable declarations in compaction test files #54360 #54399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Aug 7, 2025
Merged

branch-3.1: [fix](case) remove global variable declarations in compaction test files #54360 #54399

morrySnow merged 1 commit into from
Aug 7, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Aug 6, 2025

Cherry-picked from #54360

@dataroaring
[fix](case) remove global variable declarations in compaction test [f… (
d2835b7 
#54360)

…iles

- Add 'def' declaration for tabletId variables in for loops
- Add 'def result = null' declaration before using result variables
- Fix global variable issues in compaction1-11 test files
- Ensure proper local variable scope in Groovy test scripts

Co-authored-by: Yongqiang YANG <yangyogqiang@selectdb.com>
@github-actions github-actions bot requested a review from morrySnow as a code owner August 6, 2025 08:47
@Thearas
Copy link
Contributor

Thearas commented Aug 6, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Aug 6, 2025
@dataroaring dataroaring reopened this Aug 6, 2025
@Thearas
Copy link
Contributor

Thearas commented Aug 6, 2025

run buildall

@morrySnow morrySnow changed the title branch-3.1: [fix](case) remove global variable declarations in compaction test [f… #54360 branch-3.1: [fix](case) remove global variable declarations in compaction test files #54360 Aug 7, 2025
@morrySnow morrySnow merged commit 35d318e into branch-3.1 Aug 7, 2025
24 checks passed
@github-actions github-actions bot deleted the auto-pick-54360-branch-3.1 branch August 7, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Thearas @morrySnow @dataroaring