[support](orc)support orc file meta cache. #54591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33897 ms |
TPC-DS: Total hot run time: 184447 ms |
ClickBench: Total hot run time: 32.46 s |
hubgeter
commented
Aug 12, 2025
| return buf.str(); | ||
| } | ||
|
|
||
| void FieldDescriptor::iceberg_sanitize(const std::vector<std::string>& read_columns) { |
Contributor
Author
There was a problem hiding this comment.
This code is currently unused.
reason :
Prior to pull request #27108, the Iceberg Parquet reader parsed the field ID and file name from the Parquet file's Properties iceberg.schema.
Since iceberg.schema stores the table name, which is not in valid Avro format, the PR #27108 needs to convert it (sanitize_avro_name).
In the current master code implementation, the field ID comes from the schema.
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33906 ms |
TPC-DS: Total hot run time: 184961 ms |
ClickBench: Total hot run time: 32.91 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33751 ms |
TPC-DS: Total hot run time: 184313 ms |
ClickBench: Total hot run time: 32.26 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
morningman
reviewed
Aug 15, 2025
| : _file_reader; | ||
| } | ||
| if (_file_metadata) { | ||
| std::cout << "_file_metadata not null\n"; |
hubgeter
force-pushed
the
support_orc_cache
branch
from
cbc1456 to
b6aea5b
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33785 ms |
TPC-DS: Total hot run time: 184179 ms |
ClickBench: Total hot run time: 32.7 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34002 ms |
TPC-DS: Total hot run time: 185159 ms |
ClickBench: Total hot run time: 32.41 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morningman
approved these changes
Aug 24, 2025
Contributor
|
run check_coverage |
gavinchou
approved these changes
Sep 2, 2025
hubgeter
added a commit
to hubgeter/doris
that referenced
this pull request
Sep 2, 2025
Problem Summary:
This PR includes three changes:
1. Support for file meta cache for ORC files.
2. Changed the file meta cache key from `file name + modification time`
to `file name + modification time / file size` , reduce the chance of
reading old meta.
3. Removed some unused code in the parquet meta.
4. Users can use profile to observe whether the cache hits or not.
`FileFooterHitCache`: hit cache.
`FileFooterReadCalls`: not hit cache or disable cache.
BTW : disable cache : be conf `max_external_file_meta_cache_num` <= 0
morrySnow
pushed a commit
that referenced
this pull request
Sep 4, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
This PR includes three changes:
file name + modification timetofile name + modification time / file size, reduce the chance of reading old meta.FileFooterHitCache: hit cache.FileFooterReadCalls: not hit cache or disable cache.BTW : disable cache : be conf
max_external_file_meta_cache_num<= 0Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)