-
Notifications
You must be signed in to change notification settings - Fork 3.7k
branch-3.0: [fix](load)fix load json format boolean type to int column. #54397 #54640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
### What problem does this PR solve? Related PR: #43469 Problem Summary: PR #43469 accidentally removed the logic for reading boolean "true"/"false" values in the simd join reader. Before PR #43469, "true"/"false" were treated as "1"/"0", allowing a bool column in a JSON file to be imported into an Doris int column. This PR restores this logic.
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 39879 ms |
TPC-DS: Total hot run time: 197366 ms |
ClickBench: Total hot run time: 29.8 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cherry-picked from #54397