-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](ubsan) Fix ubsan from glibc-compatibility/musl/logf.c #54737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 33981 ms |
TPC-DS: Total hot run time: 183865 ms |
ClickBench: Total hot run time: 32.07 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run external |
|
run vault_p0 |
|
run cloud_p0 |
zzzxl1993
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by anyone and no changes requested. |
|
Do not use image in problem description, paste text instead |
Fixed |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run cloud_p0 |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 33629 ms |
TPC-DS: Total hot run time: 184446 ms |
ClickBench: Total hot run time: 32.34 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
airborne12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
What problem does this PR solve?
Related PR: #54598
before 54598, logf is using impl from toolchain, after 54598, logf is using impl from doris glibc-compatibility
Analysis from gpt5:
Fix the problem below
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)